Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6050b8f6-2cb8-3b1a-5068-cfed7737207d@talpey.com>
Date:   Wed, 17 May 2023 10:00:52 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 05/12] cifs: Pass a pointer to virt_to_page()
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Vineet Gupta <vgupta@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Russell King <linux@armlinux.org.uk>,
        Greg Ungerer <gerg@linux-m68k.org>
Cc:     linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
        linux-snps-arc@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
        linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org
References: <20230503-virt-to-pfn-v6-4-rc1-v1-0-6c4698dcf9c8@linaro.org>
 <20230503-virt-to-pfn-v6-4-rc1-v1-5-6c4698dcf9c8@linaro.org>
From:   Tom Talpey <tom@talpey.com>
In-Reply-To: <20230503-virt-to-pfn-v6-4-rc1-v1-5-6c4698dcf9c8@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2I5YnJPNEZMR1RXd1h0ZnZpUHFCL0tXelRtTHlvZ3dWSGlPYnkyZGZPOWdj?=
 =?utf-8?B?KzVXd25IYUlPSTlHV0d1MUdDU2RrUjN1dFFsWVVnbHBwWERVVkp0eHB1SlBq?=
 =?utf-8?B?di9oSVRMZ29uYXMxeE1rWTlNK1hDbm9VYmo1Rm1hM2Q1ZDZhS2xYRFRlL3pu?=
 =?utf-8?B?bXZlK3hRSUlZVDBROE92YnJyYjVpazEvZFlqL1gxUnh3WGsxaSt3clppSWV0?=
 =?utf-8?B?UXhPdys2bldkZDdEeFdLQlNaMHlzOEFnRnpKZFA0c0k3VzYxYXg3b2k5RGxH?=
 =?utf-8?B?QlVLVmMwZXRibjFVM0dQTTRIampxYnVhL0J2N2FyZWQ2VExyNFUvTXNwVFF0?=
 =?utf-8?B?VHRZdzlQN1Q1aEgrNXRMNjYwTjR4TU9yaGdrcVQyeXFMaGNDUDYzdXFXUW8v?=
 =?utf-8?B?M2JiSnE3ZWRUck96V0tVaHNwditaVHZVaGdRN2pNdTdoaEdPdGl6WUl5Y201?=
 =?utf-8?B?M1JhZFJCRTQrcUNUM0tCeEJadHFXY0xUU3JhRVdSd3E0YTVrS241Q1lZd3NB?=
 =?utf-8?B?RG9vNHd3b1IrWXErU2RyWWtSK1pPRlZ0ejhjYmF3Mm5iRG1ERm9NaDJjTkx2?=
 =?utf-8?B?UWszS0ZyYStsWWxBcU1JVzd1ODVOWnFKVU1EMVR4VEIrRFl0eitLbkhVR2Rw?=
 =?utf-8?B?Q0crQ3B5c3owemRHdmtjYXlybG5LYVZMRkJxcmtOMXBwZXFwMnNLRnl4NFZF?=
 =?utf-8?B?L0xqVlpaY1FsWjBjVDdNQ2l0SEdYemd0anRzUUZ0YWxHUVROUEJPZ0xWNXBz?=
 =?utf-8?B?OEJBdHViUzFEQzYwR21xUS9iSGhTZWJBbEl6bXk2VG1ia3VlYlNKVS9nVi9C?=
 =?utf-8?B?Vk9SMDNNV2FvNHFWRHY5SHJrR0pORFZXVHVtaFRXai9VS2VncHN5eWVaWmZT?=
 =?utf-8?B?Q3RWTUpQZUhmV3ZFU0ZGWkUveFlMSW51eHdtWWNENzhwYWM3STMzZnJtcGQ2?=
 =?utf-8?B?YlVQTHp5TmtDM1B6N05LMEpHTWprR3NRR1FBRStkU1BhNGhDb0JDQjFwWW1D?=
 =?utf-8?B?aWlLTWMzSzdDeURxYzdjRFV4Snh0dlYyN1B0VW9nUkF1WlNGclpBaWppZFFY?=
 =?utf-8?B?ZWhlTVE1Q2o2dXFKN3VLYjRKU3gwN1JHRkk1WkJMNzRGSURLM3JPOEE1KzVZ?=
 =?utf-8?B?eTNOQlBtZUhoSzUvQ2UxOE5ZeGFwc1BGbHI0V010bEtFNkFBS3hqL2MzL1RV?=
 =?utf-8?B?TzV4am5ONHB6SG5kWFBCaklMZnY0MHJLeVl4WHl0R1NqcXNSQUFsWHBJd3dp?=
 =?utf-8?B?MzM1ZjFxSTNkbUkrYXBqajN5WDUyS2h1QWZrd0VteWxhblhuMmRmbGJtWTg3?=
 =?utf-8?B?b01wcEZDZ0t5ZnFTeGdvOXZlMWgyaXV1ZGRVV2MzT1g5Yk1wdFkzeDZSNExF?=
 =?utf-8?B?KzQyc2FpUXIvN09nRUxjS1RhMnpoWGN1enFBSXM3Y29yM3JlT3dmNGdGWFhO?=
 =?utf-8?B?eXVYbHdGVWtld0RmU2Z2Q0Nia3RFdVhsMm8wSWlMSHhxZG5wYmdCSFN0WjZn?=
 =?utf-8?B?U3NrWHBZZGFtUHNYU21ZRmdvRTBlV2VtUE1XakZUdE9GMFJiODhuWCtJN0sx?=
 =?utf-8?B?bEZPMC82Wll4SWJzb2dBbXlFM3NaRDVEU1QzeFBFbXNKZkVUeSt0T1NsdVN1?=
 =?utf-8?B?NGUzM2JudVBIMzFzUU84STR4UkdTa3ZtR1FFOWFCMDFDN0xFQkF3S05vQlBl?=
 =?utf-8?B?TlRlVGRWaGd0SnVpRTVLanc0bnQybkgvakxiQ0N1NjRoejBNS3R2dlY1MVgx?=
 =?utf-8?B?d0QvM1M4UFNodUY3LzFxZDdIOUtzbkIzVGlRaHhxbVNJdjNUeVJFL0hoKzlO?=
 =?utf-8?B?aEFVaGZVc252c3J2cU0zU2ZKYUVQUkZZellRNWNQMU1UY0Eycnh6eU1UZHFm?=
 =?utf-8?B?bGt4cm8va2NzMkhDNzczWTR3SVVGNW5zWkhmS0tyd1pZQUw3eC9SMWcvNW9H?=
 =?utf-8?B?bGNuMW1uWnlFTkk3Tnlxd0FwajIvT1J1djRIcm1TSjJNZVBWV05SbGxSZWNF?=
 =?utf-8?B?YmFJYWQ3NXNremYwOEMvR2ZPOWE0K3hTcW5jUUxxWVdiOFdTaFIxUyt1STJl?=
 =?utf-8?B?a3hwejRrUUEvS0VoZ2lJcjV5YmF0VmJNMzU2Q3dCYjMzeGpBZ2VndTRKbFZj?=
 =?utf-8?Q?AGRmpbsREZZ4P3W47fx0rDU9G?=
X-OriginatorOrg: talpey.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a81b45b-99a3-4b01-b7ef-08db56df2227
X-MS-Exchange-CrossTenant-AuthSource: SN6PR01MB4445.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 14:00:55.5740
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2b2dcae7-2555-4add-bc80-48756da031d5
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wBudqqi/t63Ph2KzBu5BEfWSoeiJatGUeN2uPBgTgpvYLTCST5oPNO50SxPAp7kW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR01MB3794
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/11/2023 7:59 AM, Linus Walleij wrote:
> Like the other calls in this function virt_to_page() expects
> a pointer, not an integer.
> 
> However since many architectures implement virt_to_pfn() as
> a macro, this function becomes polymorphic and accepts both a
> (unsigned long) and a (void *).
> 
> Fix this up with an explicit cast.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

For fs/cifs:

Acked-by: Tom Talpey <tom@talpey.com>

> ---
>   fs/cifs/smbdirect.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c
> index 0362ebd4fa0f..964f07375a8d 100644
> --- a/fs/cifs/smbdirect.c
> +++ b/fs/cifs/smbdirect.c
> @@ -2500,7 +2500,7 @@ static ssize_t smb_extract_kvec_to_rdma(struct iov_iter *iter,
>   			if (is_vmalloc_or_module_addr((void *)kaddr))
>   				page = vmalloc_to_page((void *)kaddr);
>   			else
> -				page = virt_to_page(kaddr);
> +				page = virt_to_page((void *)kaddr);
>   
>   			if (!smb_set_sge(rdma, page, off, seg))
>   				return -EIO;
>