Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 May 2023 16:56:48 +0200
Message-ID: <87ilcr0zwv.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Arnd Bergmann <arnd@arndb.de>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ALSA: cs46xx: mark snd_cs46xx_download_image as static
In-Reply-To: <20230516195046.550584-1-arnd@kernel.org>
References: <20230516195046.550584-1-arnd@kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 16 May 2023 21:50:41 +0200,
Arnd Bergmann wrote:
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> snd_cs46xx_download_image() was originally called from dsp_spos.c, but
> is now local to cs46xx_lib.c. Mark it as 'static' to avoid a warning
> about it lacking a declaration, and '__maybe_unused' to avoid a warning
> about it being unused when CONFIG_SND_CS46XX_NEW_DSP is disabled:
> 
> sound/pci/cs46xx/cs46xx_lib.c:534:5: error: no previous prototype for 'snd_cs46xx_download_image'
> 
> Fixes: 89f157d9e6bf ("[ALSA] cs46xx - Fix PM resume")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied now.


Takashi