Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230517124802.929751-1-arnd@kernel.org>
In-Reply-To: <20230517124802.929751-1-arnd@kernel.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Wed, 17 May 2023 08:43:40 -0700
Message-ID: <CAD=FV=X8pAgFUngLd475d9-zkF13Fzs35-O4tCSHR+jX4YBBXw@mail.gmail.com>
Subject: Re: [PATCH] kdb: include kdb_private.h for function prototypes
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Jason Wessel <jason.wessel@windriver.com>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Wed, May 17, 2023 at 5:48=E2=80=AFAM Arnd Bergmann <arnd@kernel.org> wro=
te:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The kdb_kbd_cleanup_state() is called from another file through
> the kdb_private.h file, but that is not included before the
> definition, causing a W=3D1 warning:
>
> kernel/debug/kdb/kdb_keyboard.c:198:6: error: no previous prototype for '=
kdb_kbd_cleanup_state' [-Werror=3Dmissing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  kernel/debug/kdb/kdb_keyboard.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>