Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3f980e49-e555-0415-092d-70e581f25dc2@intel.com>
Date:   Wed, 17 May 2023 08:46:52 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [PATCH V5 00/11] vfio/pci: Support dynamic allocation of MSI-X
 interrupts
Content-Language: en-US
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>
CC:     "jgg@nvidia.com" <jgg@nvidia.com>,
        "yishaih@nvidia.com" <yishaih@nvidia.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "darwi@linutronix.de" <darwi@linutronix.de>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Liu, Jing2" <jing2.liu@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "tom.zanussi@linux.intel.com" <tom.zanussi@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <cover.1683740667.git.reinette.chatre@intel.com>
 <20230516165320.229b4928.alex.williamson@redhat.com>
 <BN9PR11MB52766D2B3D4EEA58D540FA858C7E9@BN9PR11MB5276.namprd11.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <BN9PR11MB52766D2B3D4EEA58D540FA858C7E9@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3N6TlljSUM3dnlKcUNxZFo1R1pBT3IwbElUdHh2Z09OaHc5YkN4ZGwyOFNP?=
 =?utf-8?B?eTNEOTFPZWM4NFhmR2tsSDB3TTJueFJBcGRVMXc2ZWhWSjZJVk9rZW1KZzZF?=
 =?utf-8?B?aDlKUzI2dVRmWWVlbWZVdmJ6WXZ2cXRPdWQzY0hqdHU5b1Z5L0t3NC8vZk8z?=
 =?utf-8?B?M1IwNnVKWkd1MlVYNlFlZ1FVWE91Nm92eDU0YW9HeG9QUkFtaUU4SDhabE10?=
 =?utf-8?B?ekkyZVNWRS9FTFBYWnZMOGVIMGxJa1ozUnM1M1hsWTQyYUhkRGt2bk5lMmxm?=
 =?utf-8?B?aXlTTmF2ZzliQlNCZG1VTVlQczV2N0Vxcmk1aGhaTmtneWZRaGtFYUVDcjFG?=
 =?utf-8?B?bUpiWlNOM1BYNXFaSVhha1NscHNPZjdTUm5jOWxsU05xQ2ppRWg5bXpFcjdz?=
 =?utf-8?B?WktSUDdJRWxFdzFlMllzNitqMlk1QlFhSXNtWEQ5a1J0Zi80ZFhiK2VBV0xr?=
 =?utf-8?B?OEQyUHV5VFJHRXYvajBLZ0JQaGRkME5qeGdudWM0SHcvbUJJckpzbUpvTEZn?=
 =?utf-8?B?NDdwb3BseC8rYUhTNEIxaWhmTlZoTWtVMlcvL0VoZzRQcVBuZnVxVi9DZlpV?=
 =?utf-8?B?NDg4Qmgza01nSmVPVzdsVlpHY1RPRmU0emJBc2hFZGdEcE9hWlpUOHFZV20z?=
 =?utf-8?B?OEF0OWg0Nkc0SE94QkZyZEZCcmJTOWVnUXpqWmR4c1V5ZUhiRnpiQlhMYlIx?=
 =?utf-8?B?SDFWNWJtTXN6TXBXa3BLN25SUWs2bVRHQzloM21sdFJDNUdYUmZ1YXZhSjZZ?=
 =?utf-8?B?a0ZKZ3c2NXlRTVh1cmJTZTVMei9YZS9ZZFhocDJnSUlvdzVYbk5vTVFuZW9S?=
 =?utf-8?B?d0NqZG5NWC9yMUpjWVArcUNjQlBSSXgzN3AyMzV4dFhTY2diOFIxT2RoR3VV?=
 =?utf-8?B?aFlKb2tVT2MzR091NmZkZzZESDExL21ZQVArblErRFBaaS9vek42ZFJkNEFP?=
 =?utf-8?B?MGdGMnAvUTE1WGxXRVJyUWdmNXVBWWhHbTU0TG1SY0dRN1RwMENlUUdVMTVF?=
 =?utf-8?B?dXVyU2VZNnZDV1ljbVFWVEg1MWQ1Q2xUS2xUVkJwMXRodE5RT01EVWoyTm5F?=
 =?utf-8?B?eVUyR3N4Um1ZSDN2TkhjcTcxZG1LNWhZQmVZN1Jwa2ppOW1zcU1jTExaMGto?=
 =?utf-8?B?YjB6Q09UVTdxUmdKZEExS3FTd1JveW1jTy9MRGJLS0w1d2FGRk1lKys0Q1dl?=
 =?utf-8?B?bndRYXN6V2VXQWtoVnhETjFwb2xtK3VwYStQWmxsZmFENkhIMXAvcGVJSXI5?=
 =?utf-8?B?RHM3ZHVzSHk4U2Q2WEpZUEswOXpjVEM4SnBCRXJ3UU1SalNsQVNvbk9EaG84?=
 =?utf-8?B?MndqajN4U1N0eUp3a2ZEMkpkdDR4NWplbTdaZnZCTitCSUZHb1NVT0lhVzZH?=
 =?utf-8?B?a2lmY0h2TFFGUTJzb2ZXOWVLQ1dQSTJaeWdQdFlJOGhMNFpDQkkwWDZYeHlU?=
 =?utf-8?B?anc3QVR5N3pzN3RMdlpJaFpSa1NidjlaWjhVdG5PTGxtZFdDUHVEcm03SExv?=
 =?utf-8?B?SnhHa3dMS3hBTUJFeHhTaFU1U0kvS24zSDJybWV6K1BQVld2eTFIend6STVk?=
 =?utf-8?B?bHAwRnhXdU5aV2JsMjUva0tBeVFPUGtKSlRNN0ZYL0VMRlBXSGtVMWlJdnZ2?=
 =?utf-8?B?QXpaYmdabzNMaVFwcndFY3c0Nmo0aFpaSE1DVUxQcE9iS1l2YmJldWZobjhQ?=
 =?utf-8?B?UXJaQ0NaYlowZXdpVUJjWmlMK2RCU2tlaTNNZmxJSlFueFJKVVhTbHZjbDlF?=
 =?utf-8?B?UDIvMGFhRlF2bCtLY00rN0pwYzAyMW5sSGZZcjJXZmRUNXJhMXlScWtlSFU4?=
 =?utf-8?B?VUVyaU9waU1QK2hNQkRpTXNsTUZ2ZE9udnM2cnNON2VqSkJhNFF1V3EvTDd4?=
 =?utf-8?B?U2lmcWJFa0VCalhkdUZRcUQ3dGd4WitTaUNlRVJMZk1tellIYUhjSmJIN1Yy?=
 =?utf-8?B?Q2VsZWtGNTJDQXo4bzFrL0JUbDQ2cmhYZGEwOG9IYmFTbkVxSDNhRFFsVkNP?=
 =?utf-8?B?N2Q1eWxtQmQ1VE9vTEI1WmEvSDdPUzJsZ1lRZVd4NlRMa00vOHV6MTIwVlhs?=
 =?utf-8?B?Y0xYTklkNkIrYTVPZE5TTWIvbTJtM2Qvcjh1SGMzVlRDL21HL0txMkhVcXlS?=
 =?utf-8?B?Ui9SKzJrc3h0U05iQWo1cE05LzNickllOHE3SFJIS2xhTmV1UWgrZG9QVjg5?=
 =?utf-8?B?RkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b4831ba-0d02-45cd-e16b-08db56edf116
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 15:46:55.7687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ng9BpPS7WwOKCaYn5YLH6wzBIhkIcweWRi2MQ4rNAxFPdzgJtd4nY6tMM1QxJyAsWLio2RgOdaw9h7mHZ6DwCnNCn9Dwf2UIZxy5A3yLxEI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6390
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/16/2023 7:14 PM, Tian, Kevin wrote:
>> From: Alex Williamson <alex.williamson@redhat.com>
>> Sent: Wednesday, May 17, 2023 6:53 AM
>>
>> On Thu, 11 May 2023 08:44:27 -0700
>> Reinette Chatre <reinette.chatre@intel.com> wrote:
>>
>>> Changes since V4:
>>> - V4:
>> https://lore.kernel.org/lkml/cover.1682615447.git.reinette.chatre@intel.com
>> /
>>> - Add Kevin's Reviewed-by tag as applicable.
>>> - Treat non-existing INTx interrupt context as kernel bug with WARN. This
>>>   exposed an issue in the scenario where INTx mask/unmask may occur
>> without
>>>   INTx enabled. This is fixed by obtaining the interrupt context later
>>>   (right before use) within impacted functions: vfio_pci_intx_mask() and
>>>   vfio_pci_intx_unmask_handler(). (Kevin)
>>> - Treat pci_irq_vector() returning '0' for a MSI/MSI-X interrupt as a kernel
>>>   bug via a WARN instead of ignoring this value. (Kevin)
>>> - Improve accuracy of comments. (Kevin)
>>> - Please refer to individual patches for local changes.
>>
>> Looks good to me.
>>
>> Kevin, do you want to add any additional reviews or check the changes
>> made based on your previous comments?
>>
> 
> Good to me too. I've given the remaining reviewed-by's.

Thank you very much Alex and Kevin. 

Reinette