Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <868405bc-cb04-8bd8-a3db-fb35a2a6beb2@linux.ibm.com>
Date:   Wed, 17 May 2023 18:11:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 3/5] s390/uvdevice: Add 'List Secrets' UVC
To:     Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc:     kvm@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Viktor Mihajlovski <mihajlov@linux.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Nico Boehr <nrb@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Hendrik Brueckner <brueckner@linux.ibm.com>
References: <20230512093153.206378-1-seiden@linux.ibm.com>
 <20230512093153.206378-4-seiden@linux.ibm.com>
 <20230517180335.05599c6a@p-imbrenda>
Content-Language: en-US
From:   Steffen Eiden <seiden@linux.ibm.com>
In-Reply-To: <20230517180335.05599c6a@p-imbrenda>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Thanks for your review.


On 5/17/23 18:03, Claudio Imbrenda wrote:
>> static int uvio_list_secrets(struct uvio_ioctl_cb *uv_ioctl)
>> +{
>> +	void __user *user_buf_arg = (void __user *)uv_ioctl->argument_addr;
>> +	struct uv_cb_guest_addr uvcb = {
>> +		.header.len = sizeof(uvcb),
>> +		.header.cmd = UVC_CMD_LIST_SECRETS,
>> +	};
>> +	void *secrets = NULL;
>> +	int ret;
>> +
>> +	if (uv_ioctl->argument_len != UVIO_LIST_SECRETS_LEN)
>> +		return -EINVAL;
>> +
>> +	secrets = kvzalloc(uv_ioctl->argument_len, GFP_KERNEL);
>> +	if (!secrets)
>> +		return -ENOMEM;
>> +
>> +	uvcb.addr = (u64)secrets;
> I think you need virt_to_phys()
The UV expects a virtual address here.

> 
>> +	uv_call_sched(0, (u64)&uvcb);
>> +	uv_ioctl->uv_rc = uvcb.header.rc;
>> +	uv_ioctl->uv_rrc = uvcb.header.rrc;
>> +
>> +	if (copy_to_user(user_buf_arg, secrets, uv_ioctl->argument_len))
>> +		ret = -EFAULT;
>> +	else
>> +		ret = 0;
>> +
>> +	kvfree(secrets);
>> +	return ret;
>> +}

Steffen