Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2494927rwd; Wed, 17 May 2023 10:26:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6aKRqFLGbk95W/GtvQ0EhoKaCvNypas5YTdaaxWWeQTsOwRGGbF0BouzU1WqqVHozld9l+ X-Received: by 2002:a17:90a:9bc2:b0:250:d293:5da0 with SMTP id b2-20020a17090a9bc200b00250d2935da0mr429179pjw.17.1684344415137; Wed, 17 May 2023 10:26:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684344415; cv=none; d=google.com; s=arc-20160816; b=cF4eIWGYUvQSLfnUsB4zDzCtDx3su6UWjtYAe4nvIL0soC7FxkVHww2I37qp9Z/may 94qHo/uuY8Z6V26LIUcLUcNCRD1yflw4yWjjxXOuSUvsvn6UPBQH/0j+poFj94Ui7eGj tXfhxzvYbxE93jFW6enPG9NpR0vMas601oIrTm/rIf4e+uIlhkXbijzZASeprsm1RSAy 7cWJxaHFgIPg23bg0X/yh77IDq0TvLUoHF7SC4NVs4nCLcSS6S3BpNyWIL/8aaUD2WjL 17gyGH9pGTH1eJJOkoJv2DcdN3OgT5RNfT/AmDnKRX+T+lQ5flwk2OAYnRaqkCpbQfnU wiPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Ydp0nzIqTf9GiPFxJfFUQZhMHTtnoSpeoV+NHzLr6E4=; b=lkEGbbiqm+JOotd3xS1II3qw4DLd4EVUMmUXwXOVlRiZNiVLoKX/WKbWAqK6TN6ju/ KcZ1RuFk8HcB1VISSC4IA0oU2sy8MLUh/Q6rHOZ6OlcwbhmSI8EMkvuDYXUqkITgnonE xXkk93N4XKTjkZzWumLDmE9bUPfWA77dPcS6Db7N1Un7GQkaOw3A4hvkwQo7GwLEKBzK +WVOWopuhJQHk/khlLABKq/HwRdvyzoIqRntDeOuyQ6MmExjccfmhrVz0NznVk5wjpKS Hvqc0LhuHYw4bOmhCid1CW6x/ifxLJXbzkUNnZ8o2jMrSg+oMAue1iUzGvgY7aQ8Jzcc AAcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=r4B62BFb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p6-20020a17090a930600b0024bfc621e23si2097733pjo.42.2023.05.17.10.26.42; Wed, 17 May 2023 10:26:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=r4B62BFb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbjEQRZO (ORCPT + 99 others); Wed, 17 May 2023 13:25:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbjEQRZK (ORCPT ); Wed, 17 May 2023 13:25:10 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA3FB93F7 for ; Wed, 17 May 2023 10:24:54 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-510b154559fso1811036a12.3 for ; Wed, 17 May 2023 10:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684344291; x=1686936291; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ydp0nzIqTf9GiPFxJfFUQZhMHTtnoSpeoV+NHzLr6E4=; b=r4B62BFbS7AmMFV5HoMdEg0dcw8fXjpKt8dMdOraIXcuiW8WxxXKc+E3Amka7WhJeK 6R3WVymoGOszC7ipCN0+dtYSTLx5clCCAi/DZmq0+M7Bdz9/t5biJVH8u+ldKXHoKV0o tZB3EYg79tj+51BuP+PRlWxE8ZXFsUG637Gmk4aAFzfIh/Y93N9DB8K2ey16bs3YliwH pR1VOZ9oL2eDSLuecpttUZ5rFGj5YLHsPAxY03jxchARCvSiHFD33s38RuXNShCB6w8t SL6luzV1wPMP7p6U8kN3Fk2ltKHiPjaODJ4/Dmf/A0UZFazk9qMZZ8JGyJT9oUsIFpKY tMoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684344291; x=1686936291; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ydp0nzIqTf9GiPFxJfFUQZhMHTtnoSpeoV+NHzLr6E4=; b=ainB/iKMt0REFrrQOSyH1/2DaXeoR0K7wi79xGK7ozNZv92Ie/uJSFGUyhfgp37JCR Gmcw6XnMBTrk8r3dPO9PEMWDyOypE4TM0BM9OrYD0d1u+2VDI2LsmuqgD5AMs7Np+lxP DDRmiKw6bjLdHGyKmqhAJ3m7UqF2gEBG5h0ARK0uhanMigC7E5scZbqBW3lhKKVr7KeD BFTnJJtQp833IwcCDZTUHvTxl8k3k8DXwE8yxhmpGN7iuJPE1+b57D7/MG4CpbEhsLU1 7L90u+U2T8jc+w0xDN0OvISRZkzVbhZIgMGkQgWIRIof6SbQ5Ld0GganxnM97zHiCZff SCZw== X-Gm-Message-State: AC+VfDz1AsAeLXWcZJqb8UMPM+QzsngISyORklI6jJ7s3PIFTD2RY2Fr aF2dyQlhBt15wgzbdejDKWo= X-Received: by 2002:a17:907:74c:b0:965:6aff:4f02 with SMTP id xc12-20020a170907074c00b009656aff4f02mr36680500ejb.41.1684344291101; Wed, 17 May 2023 10:24:51 -0700 (PDT) Received: from Osmten.. ([103.84.150.101]) by smtp.gmail.com with ESMTPSA id d1-20020a1709067a0100b0096b0e93193asm5440858ejo.90.2023.05.17.10.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 10:24:50 -0700 (PDT) From: Osama Muhammad To: nm@ti.com, ssantosh@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Osama Muhammad Subject: [PATCH] wkup_m3_ipc.c: Fix error checking for debugfs_create_dir Date: Wed, 17 May 2023 22:24:31 +0500 Message-Id: <20230517172431.13507-1-osmtendev@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the error checking in wkup_m3_ipc.c in debugfs_create_dir. The correct way to check if an error occurred is 'IS_ERR' inline function. Signed-off-by: Osama Muhammad --- drivers/soc/ti/wkup_m3_ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c index c9197912ec24..3aff106fc11a 100644 --- a/drivers/soc/ti/wkup_m3_ipc.c +++ b/drivers/soc/ti/wkup_m3_ipc.c @@ -202,7 +202,7 @@ static int wkup_m3_ipc_dbg_init(struct wkup_m3_ipc *m3_ipc) { m3_ipc->dbg_path = debugfs_create_dir("wkup_m3_ipc", NULL); - if (!m3_ipc->dbg_path) + if (IS_ERR(m3_ipc->dbg_path)) return -EINVAL; (void)debugfs_create_file("enable_late_halt", 0644, -- 2.34.1