Received: by 2002:ac8:3b51:0:b0:3f3:9eb6:4eb6 with SMTP id r17csp1132870qtf; Wed, 17 May 2023 11:00:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ769Bbhv8/8cPoIRv7gk0SOdy2upZdlngYmjw/MqbBU3J6o8Y2RY81qBgQ0WCFEyABMqX2d X-Received: by 2002:a17:902:c946:b0:1a5:22a:165c with SMTP id i6-20020a170902c94600b001a5022a165cmr54322051pla.0.1684346419325; Wed, 17 May 2023 11:00:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684346419; cv=none; d=google.com; s=arc-20160816; b=rmmiRuZq9NnR1BQvuSQNIe7YfeXfkbovToRhJfR1kUUktgdncM8lXdUioEydBlXTSp 8BRYG1L6AcxHn7wca4kpdKpfleF/8qN/ruBGB0KdmeuNDBj2KJv/8BceE/M8XtrvYmHY HRqurSXgup/kNo6lOhv7X0ryt00dPIyGE1As6+Ser12D6Pawh2UU0gsK91eW2vFDS8YA 4UrZXWVWuOBFzGD+FeAgutZ32oe133ojTKvoAttYnP+rMIKptYHC+dc3idlXy8YQ1Dpu ytNabxVt3yXJPDmDFO5K6fi/0Qdoo/73xRXGeuYtDZnr2rgydXPrAPH9aqsxR1kxW4e3 EoaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZdFx4WJk7gaa50DEFIuKLu7bef6RAjGgSB7wWhI1fE0=; b=xLpEeXdadbrciU8BQ+QuXIG+rCbjeU+klFZ/toFyo2dvCnRhOkw/Zh0GRDwcxqYUad C97l1JxSMO/Vspr/F2G+DQPWlAmRLbWuuxLhbX9KdGD/qrUwvntJeTzHxJLAfW++1Kle RQnYi+5MMaflx7Pv/QO8Ky3jx13i5HcDSv/wcJ6asJR7FGFCbCL0wdwcOhqRKbN3fSGN MGz/8eLVsNzdFwWSlUL1LOT5jmvx0GJfrJwGnbjCIi34IFXSCoWoVjvI2zWgNXLm4t8g d7KhKYACI5aBRWrmKSwJfxzJHa+DfBOUJolpRxbQ7qLtDCLQ8iHnYud1eFEJQT1HTmmw aSzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="Zj5/EobO"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h7-20020a170902704700b001aae1eefc9bsi20611895plt.238.2023.05.17.11.00.02; Wed, 17 May 2023 11:00:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="Zj5/EobO"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229564AbjEQRzo (ORCPT + 99 others); Wed, 17 May 2023 13:55:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbjEQRzd (ORCPT ); Wed, 17 May 2023 13:55:33 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4522AE48 for ; Wed, 17 May 2023 10:55:32 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 34HHtGuQ007084; Wed, 17 May 2023 12:55:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1684346116; bh=ZdFx4WJk7gaa50DEFIuKLu7bef6RAjGgSB7wWhI1fE0=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Zj5/EobOmHNK6dbld/PufMWVa6QAmdKJ0g2Yp/sY6EQjnji4GK9a13D8riZA79kWP QPThPn4sKRzio4cBccuMvG3XxebaAI/Re0BDCnuMdK4cerRJqbvxQMTRfSxzIRskO+ OwcE8U0xQKb5u0KF70j3o3hnewe0jKWG/eKyr+PY= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 34HHtGQm023786 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 17 May 2023 12:55:16 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 17 May 2023 12:55:15 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 17 May 2023 12:55:15 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 34HHtFjM104816; Wed, 17 May 2023 12:55:15 -0500 From: Nishanth Menon To: Santosh Shilimkar , Simon Horman CC: Nishanth Menon , Nathan Chancellor , Nick Desaulniers , Tom Rix , , , Subject: Re: [PATCH] soc: ti: pruss: Avoid cast to incompatible function type Date: Wed, 17 May 2023 12:55:15 -0500 Message-ID: <168434598652.1537118.16232593863715460020.b4-ty@ti.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230418-pruss-clk-cb-v1-1-549a7e7febe4@kernel.org> References: <20230418-pruss-clk-cb-v1-1-549a7e7febe4@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Simon Horman, On Tue, 18 Apr 2023 13:41:48 +0200, Simon Horman wrote: > Rather than casting clk_unregister_mux to an incompatible function > type provide a trivial wrapper with the correct signature for the > use-case. > > Reported by clang-16 with W=1: > > drivers/soc/ti/pruss.c:158:38: error: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict] > ret = devm_add_action_or_reset(dev, (void(*)(void *))clk_unregister_mux, > > [...] I have applied the following to branch ti-drivers-soc-next on [1]. NOTE: I think this is trivial fixup, which I think is better off for the next window. Thank you! [1/1] soc: ti: pruss: Avoid cast to incompatible function type commit: 413552b360e72604b8c0cf3f60f9e6f01c8ff963 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D