Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 May 2023 22:26:17 +0300
From:   Sakari Ailus <sakari.ailus@iki.fi>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Arnd Bergmann <arnd@kernel.org>,
        Patrice Chotard <patrice.chotard@foss.st.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Hugues Fruchet <hugues.fruchet@st.com>,
        linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: c8sectpfe: convert to gpio descriptors
Message-ID: <ZGUqWZoxXRGGJ9Kv@valkosipuli.retiisi.eu>
References: <20230130131003.668888-1-arnd@kernel.org>
 <ZGUbDFssUwXKTiDt@valkosipuli.retiisi.eu>
 <ZGUnBfqBLWkD7ZgD@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZGUnBfqBLWkD7ZgD@google.com>
Precedence: bulk

Hi Dmitry,

On Wed, May 17, 2023 at 12:12:05PM -0700, Dmitry Torokhov wrote:
> On Wed, May 17, 2023 at 09:21:00PM +0300, Sakari Ailus wrote:
> > Hi Arnd,
> > 
> > On Mon, Jan 30, 2023 at 02:09:47PM +0100, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > > 
> > > The gpio usage in the function is fairly straightforward,
> > > but the normal gpiod_get() interface cannot be used here
> > > since the gpio is referenced by a child node of the device.
> > > 
> > > Using devm_fwnode_gpiod_get_index() is the best alternative
> > > here.
> > > 
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > 
> > I've picked
> > <URL:https://patchwork.linuxtv.org/project/linux-media/patch/20230130131003.668888-1-arnd@kernel.org/>
> > instead. I hope that's fine. Also cc Dmitry.
> 
> What do you mean "instead"? This is the exact patch that started this
> thread, and it is broken (uses wrong name of the GPIO and wrong polarity).
> 
> I'd much rather you picked up
> https://lore.kernel.org/all/Y92VLGLQJZ%2FUDRx1@google.com/
> 
> Thanks.

Ah, the URL in my e-mail was wrong. I have
<URL:https://patchwork.linuxtv.org/project/linux-media/patch/Y92VLGLQJZ/UDRx1@google.com/>,
i.e. the same patch.

-- 
Regards,

Sakari Ailus