Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2696823rwd; Wed, 17 May 2023 13:09:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6HGcmIwZFCSUwUnRMy0CKHMZzphAS4suEzzQhtJUqyBonZQD+7QXx4vsA6hqn1iy1e2n5R X-Received: by 2002:a05:6a00:198b:b0:643:afd0:aaef with SMTP id d11-20020a056a00198b00b00643afd0aaefmr1097193pfl.18.1684354165985; Wed, 17 May 2023 13:09:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1684354165; cv=pass; d=google.com; s=arc-20160816; b=Z+hh29uhZfaBT3EeFP5Tj8SO9AEqc/Fe0CJrYKCC99bQ9+Q6PZM4vKbzjcuiW7OtMg MmMrFouEEvNvXg84+KIvj0FXAwHDEY0mLqUPxWFXgprv0O91PTAQ9jXaJ06yfJJSD8Q9 U7Ncj+HPWa5wsO6IT7BxqqjZ9cR9ttDFu8GSDKDMED7kKSWoKG9s1S3NV6KJ0B+XBPLT QqF47PTZsMv4CLoMMuhJhMR8xWNk49L2ApXGsGjSbRLGVVPBfZxKkMqt7pV8FnthxIW/ p7HV6SDViZLY611LbV4DjGS4gWURufzqvI436IbUPm+DuoSiJBbauo+CCGXL1cuBpku+ KOVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uT4QeccEOPKkK7gGYPYPm3Y9FH1yk/CYJCXvyI1gFcg=; b=0cdSt8VXfZwOx0pcGfz7JDPoqkQ+M+UNXsC4x081+XVut7mvBFtgDfSmZhH8y2DJTe tRkM50P45Lp4m8WdqpJ22QHTwNtALoQH/ABTWMMAqJK7x0TLtD6Z9aGjlcAHiGyG3267 YO79LknDPcBB3ljsAY42naUEeIK5+KiRSfTqtjm/3v0J9mK5Pejatb2x0I3jbwP3J8vP CEEUxcPObeTDjM89Jix5ZHWwD7IZYXOXN2TZZQMbuuk7uiZjRB7+injxtaPTvkkLzeVs hhShJGjGCths8wCysuAsuQrQB7XoK/VLWeV7Y/UlxALFBQjSl3BK7t1PMswmhUiykmMl Wj+w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@iki.fi header.s=meesny header.b=WZFEpJpu; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z23-20020a63b917000000b005098590f1edsi22098731pge.757.2023.05.17.13.09.13; Wed, 17 May 2023 13:09:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@iki.fi header.s=meesny header.b=WZFEpJpu; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229544AbjEQT7o (ORCPT + 99 others); Wed, 17 May 2023 15:59:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjEQT7V (ORCPT ); Wed, 17 May 2023 15:59:21 -0400 Received: from meesny.iki.fi (meesny.iki.fi [IPv6:2001:67c:2b0:1c1::201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3E47E67; Wed, 17 May 2023 12:59:20 -0700 (PDT) Received: from darkstar.musicnaut.iki.fi (85-76-146-199-nat.elisa-mobile.fi [85.76.146.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: aaro.koskinen) by meesny.iki.fi (Postfix) with ESMTPSA id 4QM3pT6zgSzyWs; Wed, 17 May 2023 22:59:13 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1684353557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uT4QeccEOPKkK7gGYPYPm3Y9FH1yk/CYJCXvyI1gFcg=; b=WZFEpJpuxHgdL66a5PaD1yNk7SpgMp9G9guhbNAaUh3HEUxnbuFWcPk8rHcB/dQQJaayMK upe+8t3l5YMswlkboqSxW1TMcS8P/5RX1nVRVXD5ExA19T8y7uQqsCZL1U0nsnp5cTTAW4 WqLdFf44BWpW+Gcb+Kix2JvPsvJMOEE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1684353557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uT4QeccEOPKkK7gGYPYPm3Y9FH1yk/CYJCXvyI1gFcg=; b=uqZALiO1J2n/ZSQ1Zg25g0VKOhsOJ/6Qt1tM/2HyGw+suNSH0P3c0GzRaRzizaWMSFNnCo kXUNe5mMx5fBj+8WBcmDkoSMxVBjAarDMIXN1vF1ZIB9LxTfhPvbYuxL0RtKrJA9x3X5j+ m2hOXBKV8p6FLsSV8qUVN62sMFztjCM= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=aaro.koskinen smtp.mailfrom=aaro.koskinen@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1684353557; a=rsa-sha256; cv=none; b=RKAECBWDBO58k84XgosU1UrhQq2r0jPWNipNo3Gi0fMRoUGJZblm+3P1vXugNvU+LqaNyh c2O6jMu7dk5j7DzRa8mJccrAhHhiOFueDQPGfrq0HfU5IqmE4NrXeiRgdWhUIROwa4xfNf 00KimNUa/R4AbP591nbysQnVZMJjE/A= Date: Wed, 17 May 2023 22:59:11 +0300 From: Aaro Koskinen To: Linus Walleij Cc: Janusz Krzysztofik , Tony Lindgren , Russell King , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Thomas Bogendoerfer , Dmitry Torokhov , Mark Brown , Bartosz Golaszewski , Andreas Kemnade , Helge Deller , Ulf Hansson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-input@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes Message-ID: <20230517195911.GG271152@darkstar.musicnaut.iki.fi> References: <20230430-nokia770-regression-v4-0-9b6dc5536b17@linaro.org> <20230430-nokia770-regression-v4-1-9b6dc5536b17@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230430-nokia770-regression-v4-1-9b6dc5536b17@linaro.org> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This does not compile as nokia770_ads7846_props is declared twice, and nokia770_cbus_props and nokia770_mpuio_gpiochip_swnode are missing. On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote: > +static const struct software_node_ref_args nokia770_cbus_gpio_refs[] = { > + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 9, 0), > + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 10, 0), > + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 11, 0), > +}; These should be nokia770_mpuio_gpiochip_node. > +static const struct property_entry nokia770_ads7846_props[] = { > + PROPERTY_ENTRY_REF_ARRAY("gpios", nokia770_cbus_gpio_refs), > + { } > }; This should be nokia770_cbus_props. A.