Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 May 2023 22:14:49 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Yeqi Fu <asuk4.q@gmail.com>
Cc:     mw@semihalf.com, linux@armlinux.org.uk, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ivan Orlov <ivan.orlov0322@gmail.com>
Subject: Re: [PATCH] net: mvpp2: Fix error checking
Message-ID: <ZGU1uVuP7nJvigtr@corigine.com>
References: <20230517190811.367461-1-asuk4.q@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230517190811.367461-1-asuk4.q@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bjWWW+LEU434nDa/8iaP/b+e2QeGUApQe/35E8QsbyCv0XnS+TGQmwIVL4T2?=
 =?us-ascii?Q?xeJpYRTUyZ5vwKOJ4CACgdvIlVvPjrJP6om4I14QeHiOcJrJ1vOVxE+sG1Ik?=
 =?us-ascii?Q?bPx5hRG5oH7QXpNP1pLJqGnigqXOrVkQkMmPI3Dg9bCKN2i3eraA7FkinrgN?=
 =?us-ascii?Q?OKSvEF0So5AC6d+hSaxmVjgrSXWGYjlUxvlfpXJqJOjZrSOLVaczHinXRWXZ?=
 =?us-ascii?Q?NXVWB4pY3H+5y5TRaPk0dv3EtxZp/UPTb54fBT4T2TLs5F8vrWHPnzt4ZbAT?=
 =?us-ascii?Q?mk4SI/+1bLJgWbEMI7YzfmKLmaAV0Fz4EEOFmgLj2ZIeCORuA0xw+tv3yyfs?=
 =?us-ascii?Q?w9q6z5vveRrqp7HGDqdIJmwrf2SHywLLyapbO3s97B107E4ffOkhyPEIlnFN?=
 =?us-ascii?Q?/fFQIox+iO9H5BHUBZD2gxzCofGIb8/ZXb0Ic8wefDak5v7heo1MA9n2KZf4?=
 =?us-ascii?Q?kAauOH3B2KioTK4HhvRxHr1zBjTPu9AdnuHr4sqIBJnMbNRXVJVubRfsDYKw?=
 =?us-ascii?Q?kBufqW4UqYCzchy5zSTRyK7Cn0ZpjLgnSWe7trCyeqL+6S8Y92wg2xKps2/P?=
 =?us-ascii?Q?6Xm75Gt2Tn/wtBoECYTSXZmP1jXRhYemeC0Il9IouBP8Xp6XrLB07axlZYMQ?=
 =?us-ascii?Q?/ojfz22jBProSHo1W3FIrNDbJx8BR5r4tOWR2lpeYqz1bKo/IdWfqEa2AyAn?=
 =?us-ascii?Q?uhiTF7KnCphJed8Mk1OalAGxledtR36+VVEASf78iIV5ayFWntsY/vr7bEg1?=
 =?us-ascii?Q?Xq5ZatD8iAQ2lmy5Qn9aHN32hysW1kf9oNeSjca1gIyOMOd4qMJI3+37Pl5v?=
 =?us-ascii?Q?OSJKzyIa1yy31VFiINNHI7Boi9yDlXCV5mdpi2HTnzWJWLERBTXQ8uZxNkkF?=
 =?us-ascii?Q?+0i5wyBlpEgLD20/YLqD0mDg3Eh57Y7oVmVQGIX/VKO3PktlwgnwwOGcLhfy?=
 =?us-ascii?Q?b2NzeAMGFolWJSdhOrWL/ukPXj320nuWB0OWZf8YqBrO8yCWd4OQAk2Qd6v+?=
 =?us-ascii?Q?3WMQDeBObLBHmj08KvMmEhuNpA3QpbFxkj0sz/aAQq8FJt6vCgC4sO3KDYGQ?=
 =?us-ascii?Q?mVnqjjXyWucTIHwOFFgiLEa4R49luGC5CHO9ICchSe/3UfMj5+IQMOYDj4Et?=
 =?us-ascii?Q?vuUhe1uPSzLkEwOFHBYsbVch2ALSBupd6HBakzI9NI12+PNWjv4XMFA2NARQ?=
 =?us-ascii?Q?gT/bz2ovHh1wjjdqw340cQiGfKIXpr2baqpnF4dFQrM74zsnmKLlI8MsfRAF?=
 =?us-ascii?Q?7UQK0QrNee9H9SptuefZJ3HtWBksP55FFxbDKzMh85Ufw6HEJ9H+ILMxZRBt?=
 =?us-ascii?Q?CJPiov3H1983dN8WNXcsBxnu59zpcOKNkeGPai1al/8UK4Kw6tSWMWDodXjf?=
 =?us-ascii?Q?7JHFUNIojuiYrnq5LYf1/8M+/YHsUv3Oe1bfRTF2u0d9gkYqKDXL35DNUVvZ?=
 =?us-ascii?Q?FIMiefcrB9SCYBiDGxDA6tZpsm5YbCFQ6rt7W/GtRBpjXH7SBRUIQWdSIa6h?=
 =?us-ascii?Q?QwEcSgGHw8LvQj/Rue/w03ZikOlKFc7xzbMbGe+nQQBAiiKKZRcwolGTCFci?=
 =?us-ascii?Q?5kCv8DDcaHJBpaYqlSMV7WIBPht8mirZcOmYNRORGFRebwiVcl89CLfpUVUw?=
 =?us-ascii?Q?xUArmBvwUol7Q9iGAhNa30bWunn/BFVKHezvKUk3MU62/ci23qAVVvCCwTPK?=
 =?us-ascii?Q?qglx7A=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bcf7454e-baf3-4f9d-73b5-08db571361ee
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 20:14:56.5024
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: El4fmWMiLzxsnLGzON8+6MXKs0vo91CMYiVIJtCgE70/mpWG9n65Q18BfRIHQ41CGaS+n7CkfzZLiTexFqolXmXrE386fXIqqlUhHxzIzGE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR13MB6047
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 18, 2023 at 03:08:11AM +0800, Yeqi Fu wrote:
> The function debugfs_create_dir returns ERR_PTR if an error occurs,
> and the appropriate way to verify for errors is to use the inline
> function IS_ERR. The patch will substitute the null-comparison with
> IS_ERR.

The comment above debugfs_create_dir includes the following text.

 * NOTE: it's expected that most callers should _ignore_ the errors returned
 * by this function. Other debugfs functions handle the fact that the "dentry"
 * passed to them could be an error and they don't crash in that case.
 * Drivers should generally work fine even if debugfs fails to init anyway.

And I notice that in this same file there are calls to debugfs_create_dir()
where that advice is followed: the return value is ignored.

So I think the correct approach here is to simply remove the error
checking.

And, to answer my own question while reviewing this. I don't think
Fixes tags are warranted, as debugfs_create_dir() is not expected
to return errors, so there shouldn't be a but in practice. At least
that is my reasoning.

--
pw-bot: cr