Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230514152739.962109-1-masahiroy@kernel.org> <20230514152739.962109-9-masahiroy@kernel.org>
In-Reply-To: <20230514152739.962109-9-masahiroy@kernel.org>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Wed, 17 May 2023 13:58:43 -0700
Message-ID: <CAKwvOdk7u5Yj8+Y6WeSpdohz25Tcrpo9Gc9BuAhpbac7RibEjQ@mail.gmail.com>
Subject: Re: [PATCH v5 08/21] modpost: pass 'tosec' down to default_mismatch_handler()
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nicolas Pitre <npitre@baylibre.com>,
        Nicolas Schier <nicolas@fjasle.eu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, May 14, 2023 at 8:28=E2=80=AFAM Masahiro Yamada <masahiroy@kernel.o=
rg> wrote:
>
> default_mismatch_handler() does not need to compute 'tosec' because
> it is calculated by the caller.
>
> Pass it down to default_mismatch_handler() instead of calling
> sec_name() twice.

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>  scripts/mod/modpost.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 49357a716519..2cc9c2a4aadc 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1203,9 +1203,9 @@ static bool is_executable_section(struct elf_info *=
elf, unsigned int secndx)
>
>  static void default_mismatch_handler(const char *modname, struct elf_inf=
o *elf,
>                                      const struct sectioncheck* const mis=
match,
> -                                    Elf_Rela *r, Elf_Sym *sym, const cha=
r *fromsec)
> +                                    Elf_Rela *r, Elf_Sym *sym, const cha=
r *fromsec,
> +                                    const char *tosec)
>  {
> -       const char *tosec;
>         Elf_Sym *to;
>         Elf_Sym *from;
>         const char *tosym;
> @@ -1214,7 +1214,6 @@ static void default_mismatch_handler(const char *mo=
dname, struct elf_info *elf,
>         from =3D find_elf_symbol2(elf, r->r_offset, fromsec);
>         fromsym =3D sym_name(elf, from);
>
> -       tosec =3D sec_name(elf, get_secindex(elf, sym));
>         to =3D find_elf_symbol(elf, r->r_addend, sym);
>         tosym =3D sym_name(elf, to);
>
> @@ -1276,7 +1275,7 @@ static void check_section_mismatch(const char *modn=
ame, struct elf_info *elf,
>         if (!mismatch)
>                 return;
>
> -       default_mismatch_handler(modname, elf, mismatch, r, sym, fromsec)=
;
> +       default_mismatch_handler(modname, elf, mismatch, r, sym, fromsec,=
 tosec);
>  }
>
>  static unsigned int *reloc_location(struct elf_info *elf,
> --
> 2.39.2
>


--=20
Thanks,
~Nick Desaulniers