Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp183160rwd; Wed, 17 May 2023 16:54:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6wLdF7tGjvNS9zspQFmcPJ5yo3jnDbBvhV0jXSPEZG7M8iO8F8oGpaubWAz5vywiX2icCc X-Received: by 2002:a05:6a20:3d8a:b0:106:4e09:151e with SMTP id s10-20020a056a203d8a00b001064e09151emr15749394pzi.39.1684367678089; Wed, 17 May 2023 16:54:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684367678; cv=none; d=google.com; s=arc-20160816; b=YPZRk7ylSK38clBvA67kaXTFXEuCMA+5ogknFoJCkGDFWioqLOluxTMZLtUY46tLaK Cwecjvhom2hV2wlxJ1OaE3i+wkkVXZtdMwBYQuw+ClrN88KfeW3bqyx/KLIhUBmLE0qQ JnBAOP3beRV91W75RCr1URn1fnYFO2gKI9GO5WeFajHyaBoLpR4XlYDxagSC7C6OBCdd SC4a+FP3UygOiC7OvAm1xMkM1WxWqE199WmmxiXNcv1ixJtOlq8n4038jCFfIhcGQMAD 22JFm6/5Qn5WSKbFpBTmKRu984Du4pwNtTgTaj6CchgcubouS7XLR73dwg7yTmd83c/D 6lYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=7cQ8MHnnkw+u4jPFTbH2QZwg15cKSVff/yxwNCVRTfw=; b=CcfCuvzpIXoODq9jSXkimDKxD2PJcKz7TnnIOzcM17Cl3IumsMVWDwazytOERyzVQU V+Hbh8Q0hEJEoROVEst29AN/WmgPCptdfBc+UO5QhYXwak08QoLkVJavGb9zQ44+JaMu EJuUj6FBOR95aeBiAI5mc1702cV2gDzObjXlSywAzNIORjwmWaS0o0LxknOXHM0SHTQO NmoO+kV+rTFhWkmfjXl07pGSXdLns6b4sAkFGsYCh3eShfrZYiL6tDGRDUDD7cEBkUXe fN8rK2gCu/eA7AFzhtzwCBJNevH/L11Cf4BhZe1OHa9LTEOsnRTZMov1hNtZTxssc5zT TXIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=dMOrzvFm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=denx.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i189-20020a636dc6000000b0051b4eaac57esi22571767pgc.583.2023.05.17.16.54.26; Wed, 17 May 2023 16:54:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=dMOrzvFm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=denx.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbjEQXeG (ORCPT + 99 others); Wed, 17 May 2023 19:34:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbjEQXeE (ORCPT ); Wed, 17 May 2023 19:34:04 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4954F40EF; Wed, 17 May 2023 16:34:00 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 1170D860F1; Thu, 18 May 2023 01:33:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1684366439; bh=7cQ8MHnnkw+u4jPFTbH2QZwg15cKSVff/yxwNCVRTfw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dMOrzvFm2psxlRz97auMZAlBgFKUPxr0qVAEAwL0I4CBChLUN3FZNjMd5xTXFGf9V 407aBtxtJOSZYzjQdTsWcPV+3YoNk/Tq0R1G1NNqTpehT1S/3/GtcBwX88w8ajV6Ey bXGEm+RodWF1m32wYr1rOXSx7ExznKr+ZEWhGPp4JO2Fo3DBtPFGGHlH0m9C2knCea xbYa4t/i5Z5XukvYQy9MFc3Gp9EmHJk210wOuzVGgg5clYiiMtWdx/rhmqL8FtRc8N V2y5ll2MlozQCOJwg+o9qudMMXAWf2G8GU+rd1w0NIphJ3VZCvOtFKvpPShl+PPYTE vUcw9SuDwEKiQ== Message-ID: <5f201903-17cb-5054-763c-f03b1066db1d@denx.de> Date: Thu, 18 May 2023 01:33:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 3/3] ARM: dts: stm32: fix several DT warnings on stm32mp15 Content-Language: en-US To: Raphael Gallais-Pou , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Philippe Cornu , Yannick Fertre Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@dh-electronics.com References: <20230517143542.284029-1-raphael.gallais-pou@foss.st.com> <20230517143542.284029-4-raphael.gallais-pou@foss.st.com> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/17/23 19:04, Raphael Gallais-Pou wrote: > Hi Marek Hi, > On 5/17/23 17:41, Marek Vasut wrote: >> On 5/17/23 16:35, Raphael Gallais-Pou wrote: >> >> Hi, >> >>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi >>> b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi >>> index 0f1110e42c93..a6e2e20f12fa 100644 >>> --- a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi >>> +++ b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi >>> @@ -457,8 +457,7 @@ <dc { >>>       status = "okay"; >>>         port { >>> -        ltdc_ep0_out: endpoint@0 { >>> -            reg = <0>; >>> +        ltdc_ep0_out: endpoint { >>>               remote-endpoint = <&sii9022_in>; >>>           }; >>>       }; >> >> This LTDC port/endpoint stuff always scares me, because I always feel I get it >> wrong. >> >> I believe the LTDC does have one "port" , correct. >> >> But I think (?) that the LTDC has two endpoints, endpoint@0 for DPI (parallel >> output out of the SoC) and endpoint@1 for DSI (internal connection into the >> DSI serializer) ? > > You are correct indeed, I rushed the patch and did not thought about this. I > agree that this can be confusing, as I also take some time to think through it. > >> >> Only one of the endpoints can be connected at a time, but there are actually >> two endpoints in the LTDC port {} node, aren't there ? > Yes, they are mutually exclusive. >> >> So the original description should be OK I think , maybe #address/#size-cells >> are missing instead ? > > Thing is: this file is only included in two device-trees : stm32mp157c-dk1.dts > and stm32mp157c-dk2.dts. > > Among those two files there is only one which adds a second endpoint. Thus if > the fields are set higher in the hierarchy, a warning yields. I do not understand this one part, which warning are you trying to fix ? I just ran '$ make CHECK_DTBS=1 stm32mp157a-dk1.dtb stm32mp157c-dk2.dtb' in latest linux-next and there was no warning related to LTDC . I think if you retain the stm32mp151.dtsi <dc { port { #address-cells = <1>; #size-cells = <0>; }; }; part, then you wouldn't be getting any warnings regarding LTDC , and you wouldn't have to remove the unit-address from endpoint@0 . btw. I do use both endpoint@0/endpoint@1 in Avenger96 DTOs, but those are not submitted yet, I have to clean them up a bit more first. > One way to do it would be to make the endpoint@0 go down in the device-tree with > its dependencies, so that both endpoints are the same level without generating > noise. I'm afraid I really don't quite understand which warning you're referring to. Can you please share that warning and ideally how to trigger it (the command-line incantation) ? -- Best regards, Marek Vasut