Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3e4b8bed-005e-1b12-82f4-45b5cf3e7b71@amd.com>
Date:   Wed, 17 May 2023 18:03:19 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 2/3] drm/amd/display: drop unused function set_abm_event()
Content-Language: en-US
To:     Hamza Mahfooz <hamza.mahfooz@amd.com>,
        amd-gfx@lists.freedesktop.org
Cc:     kernel test robot <lkp@intel.com>, Tom Rix <trix@redhat.com>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Qingqing Zhuo <qingqing.zhuo@amd.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Hersen Wu <hersenxs.wu@amd.com>,
        Stylon Wang <stylon.wang@amd.com>,
        Wenjing Liu <wenjing.liu@amd.com>,
        Leon Huang <Leon.Huang1@amd.com>,
        Mike Hsieh <Mike.Hsieh@amd.com>,
        Cruise Hung <Cruise.Hung@amd.com>,
        Nasir Osman <nasir.osman@amd.com>,
        pengfuyuan <pengfuyuan@kylinos.cn>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230517183350.314082-1-hamza.mahfooz@amd.com>
 <20230517183350.314082-2-hamza.mahfooz@amd.com>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20230517183350.314082-2-hamza.mahfooz@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RndKTnZ3TjJLU2RhTy9LZENKSDZZdHZUeFE5VWVMd2x1YVB2dlpGdzdrekpq?=
 =?utf-8?B?WVEydGUxeWJCY3RlWHBFc3dad2Q5MHNZaFNDNkNHMmJtSnNKUXUvUTdsWXJz?=
 =?utf-8?B?OFo0MXNaM0hEZzZWNXEzcktqRHlVSklJVVlsVXp3V2h3Mmx3K1FjWHlCQytq?=
 =?utf-8?B?T2YxOVJaMFE5cE5lektjK1hUWG92Rm94ZVJRYTdyV0JiZlFVeEtqbHAxaWpj?=
 =?utf-8?B?Q0RvUmR0RTNvOW8zT3dnWkN6dmJPdnRJdk9JR3NHdUhYcDIvQlIyU1l3TnRq?=
 =?utf-8?B?YXBYQlVmUlg3U3F3bDdLekMwWVdvcjVncG9YRmJpbS9WTjJMRVlNZ1luSzgx?=
 =?utf-8?B?NHNJOFVnNnVDaTFubG9QelI2M1BTK3JOekdKb3UrUjl5bDdUckFHbDg0ci9R?=
 =?utf-8?B?UkJseHhNblBQR1dTTzYxMERHVEE0SE1JYWhMYk91WE9qam1wSTJuZ2JUcEg0?=
 =?utf-8?B?eFdjK3RLLzhZUG03K2dMbkNOR0crVCtEc2Q0emFSbWo1Q3g5RXFpNDNoaThv?=
 =?utf-8?B?STF5R3ZDWEtySks2T2dSY2I5OWVTZHNwdTVKYVREeHRQN2k1cEtPOTh1bTZ3?=
 =?utf-8?B?Vlc2WmdicjdaSjVRenJ6LzBhS2JSSmFQYnNEOEpFRVE4bG5YYWpWaEpXYWx6?=
 =?utf-8?B?a3NsWlo3VUk5dUZVc0ljTldCQkM1aHhoOXVKR29ncUJpWEtrNXVoWWZ3L3NC?=
 =?utf-8?B?aTVJbUI2R1FXZGFlMWJNQ0xybENCMkpMcE9XNTRQWk9iakZKYWpiSEd2LzdP?=
 =?utf-8?B?RGxlY3psUC8xQUNMKzRGbWVWMVlkck1heEhYUzJIaWpyckh1T0pnQ1poaitH?=
 =?utf-8?B?MElPRUFvR1NVa2dEZXY2TzNwVGVUVVNmcDEvUmRNNENMTWhtWjgxWVd1N0hr?=
 =?utf-8?B?VFpGZmN6ZGNGTC9rdG1qdFZmQ2tMMjVoSm9NMHQzMU5yYlJNaVhTQ202N1lj?=
 =?utf-8?B?QnIzTXhZaVFnKzJrVjJPdXRDdEVrMUhlM3FnN1lYVGoyWWdQYm14RWJkWW9l?=
 =?utf-8?B?MXdEbFpRZGtDYzNudjYvMDlWc3FBRFFqajQ1WVhteGZ3L1FjRy9yUEt5K1Q2?=
 =?utf-8?B?QTRFVlVJSU80clVBTWFML2pHNXBTZGN5Y2l1MGNhS0tWQWtEVHlrWkxjWTBp?=
 =?utf-8?B?NDZrMGhiVmhwYVIzZzA3UEIyYU9JZCszQ3B2OENUNzNjSTlaU3BxQ3RlOTJh?=
 =?utf-8?B?akphd0Q5OG42L004MUhqdHpCdjdzTE1LUWhyL1VNZkZKNkQwOTRRaDIyY3Nm?=
 =?utf-8?B?NlF5WTBlR3BaMGpWMGVjYW0vOTdWa2ZKSktFWkpzZk5rWXZaK0JRZUQ5VldU?=
 =?utf-8?B?aXd3Qk85RFlLeC80Q1RKQkMwelYzbHlxMk5tT254bVNXcUxHbGVmVExGUFN1?=
 =?utf-8?B?WXZwVXUwOHBJOEVKTkM2a2xrR2FiNFFmaHYzT1RobDhGWHBPcUFCOVppSmJT?=
 =?utf-8?B?R1pzeUFRRDJIeG8zd1FTdkNKK0gwU3A5TW45Yk54cHNwY1pYNFlaWUtscGRF?=
 =?utf-8?B?VzdxTjY5eTByU2Zkd0h4dGIycitTYkg1aVlPOEVvM1dtTHFLYU92b1UvVmtE?=
 =?utf-8?B?M3E3R3lkT0U1bDBwcE5tK1FlUnduWkhvOTJ5VXFXSGk1MU9ZT2hoakNsWUVv?=
 =?utf-8?B?anpldUo2Rjl2NWNteW5oWS9CbmJFMGlwWGRyOGxmRm9EQUcwUk44c09VcmIw?=
 =?utf-8?B?VU5Vam5kanpnVmhQUVF3cHZJaXJ3Z28rR25PeWpMTjZ1S1RPZER2dTFLTitU?=
 =?utf-8?B?K2pjZ1hUTWZkdkJKYWxXdVBJSGI2aFRJaSt5MnhOUmFmTE0xRDNmL3c5Q3JU?=
 =?utf-8?B?UGtXWDdVMFB2QjhVOFdzOUpzb2RtYXo3ME9XRy82d0JDTGFwSzhyUHk5S0JN?=
 =?utf-8?B?azJSUWNYSGd6ZlRuMm5GSG95Nk1WbjF6a0Y0dUx1N1pTQWhYUTdUMnpjVXZY?=
 =?utf-8?B?V1hMVmJWaWdVdlUrOGFQYmFpandzRUZDS3JXc25mVm9oazUxRXZzbjhDbUdF?=
 =?utf-8?B?ZlA5dFY1dWk5YTBhb0RFY09WWGJvd1k1c2htTVloVGpvLzVldjhkSG9OQkUv?=
 =?utf-8?B?UjE2OEJseC9uVTg3THhMZFBoODlmZ25xZ1NidkZZT09OOEdNSDVWOWhNRUJv?=
 =?utf-8?B?bzVJWGpZVmswaURwb2NOQVNwdndzSVZQeEMrdDJNVUlsa1JlRUh6anU1S1Nu?=
 =?utf-8?Q?stptw+fnBbGmeAHEDAw7789WeLDtB4UY2sXsGEe5R8aM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9dc94623-7dac-4f00-b483-08db57334bae
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 00:03:23.1824
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vqp/9rJv4Q3NrhM7majZRy7ZljNVkvVkFjbiQeenPYs7ukZYJk6YvbusviDhEaR+/i6do6BzQPRSdSrdEgmL4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5236
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/17/23 12:33, Hamza Mahfooz wrote:
> set_abm_event() is never actually used. So, drop it.
> 
> Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Tom Rix <trix@redhat.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12 ------------
>   drivers/gpu/drm/amd/display/dc/inc/hw/abm.h   |  2 --
>   2 files changed, 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> index a66f83a61402..2fb9572ce25d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> @@ -131,17 +131,6 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op
>   	return ret;
>   }
>   
> -static bool dmub_abm_set_event_ex(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> -		unsigned int hdr_mode, unsigned int panel_inst)
> -{
> -	bool ret = false;
> -	unsigned int feature_support;
> -
> -	feature_support = abm_feature_support(abm, panel_inst);
> -
> -	return ret;
> -}
> -
>   static bool dmub_abm_set_backlight_level_pwm_ex(struct abm *abm,
>   		unsigned int backlight_pwm_u16_16,
>   		unsigned int frame_ramp,
> @@ -167,7 +156,6 @@ static const struct abm_funcs abm_funcs = {
>   	.init_abm_config = dmub_abm_init_config_ex,
>   	.set_abm_pause = dmub_abm_set_pause_ex,
>   	.set_pipe_ex = dmub_abm_set_pipe_ex,
> -	.set_abm_event = dmub_abm_set_event_ex,
>   	.set_backlight_level_pwm = dmub_abm_set_backlight_level_pwm_ex,
>   };
>   
> diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> index db5cf9acafe6..d2190a3320f6 100644
> --- a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> @@ -59,8 +59,6 @@ struct abm_funcs {
>   			unsigned int otg_inst,
>   			unsigned int option,
>   			unsigned int panel_inst);
> -	bool (*set_abm_event)(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> -			unsigned int hdr_mode, unsigned int panel_inst);
>   };
>   
>   #endif

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>