Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <77868d83-c213-86ad-76ff-3949c075995a@amd.com>
Date:   Wed, 17 May 2023 18:01:16 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 1/3] drm/amd/display: drop redundant memset() in
 get_available_dsc_slices()
To:     Hamza Mahfooz <hamza.mahfooz@amd.com>,
        amd-gfx@lists.freedesktop.org
Cc:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Qingqing Zhuo <qingqing.zhuo@amd.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Hersen Wu <hersenxs.wu@amd.com>,
        Stylon Wang <stylon.wang@amd.com>, Jun Lei <Jun.Lei@amd.com>,
        Wenjing Liu <wenjing.liu@amd.com>,
        Leon Huang <Leon.Huang1@amd.com>,
        Mike Hsieh <Mike.Hsieh@amd.com>,
        Cruise Hung <Cruise.Hung@amd.com>,
        Nasir Osman <nasir.osman@amd.com>,
        pengfuyuan <pengfuyuan@kylinos.cn>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230517183350.314082-1-hamza.mahfooz@amd.com>
Content-Language: en-US
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20230517183350.314082-1-hamza.mahfooz@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tmc1MzkvMmhYeGRmdEZxQzBWSU96b0NaK2pkanFKc3EzRWdBT3NZQXFsZ1pC?=
 =?utf-8?B?aWdKbGZ4Y0Rpa1VpcUdMckY5UWNiMTZya2xUN0hiRjRwc0xLY3prVTl2RVY1?=
 =?utf-8?B?YWhwRzY5THdPRjdlSUhRZXJvblFFcmtOZ2JpbXhXYm9ONU9OUjFTOXFHbE4z?=
 =?utf-8?B?NDVwbmY2eldSb2lmVElRQzJSNnJwOCtuMS9WVGdVY2xpTUlFeWg4eVljYTBa?=
 =?utf-8?B?RVVZN1M4Vk1QaFRKVndGblM3N1JaYjcxQUowN1V0V1dua29UUW1sQk9PR3Bq?=
 =?utf-8?B?M1RwME10OC9oSnJxTDlCYWd1cS9aVTdoS2FyVzl1a1UvNXdVa3VUVDNJMEJt?=
 =?utf-8?B?NVdMSUxsTzFTeVcvU3ZxZjlFVjlqTCtXU2loTFhQRVpmQ0RJT3o2SlpIbmxy?=
 =?utf-8?B?ZmpzY3RDc2lJWG1WSThhMXlhMFhKbU91Y3JWQlA0RDFzNVFldG1IS2Z6amVa?=
 =?utf-8?B?cVlocWszT2sxK25FVkxjNWl3YnJBbS91RjNyM2pzcTBIbmZadGdmUFNmMGxS?=
 =?utf-8?B?dzk5Y1hjS0dZOVFHeFRmcXdsYy84b1daOWpSc3BLbUF3Z1Z4SzNoMURGT1Bu?=
 =?utf-8?B?L2RqdVRsSXdNOGZpODRCQWd4a0h6VTJ5eThUVnV2Wk13Q2REdUFoSjZjb3ZU?=
 =?utf-8?B?NTBIMk96UDROeEZZUGRvMHdjc1RHeFBRWDUxK2RsVUI5NGFQM1BSNjNvSlZO?=
 =?utf-8?B?T1hUSXAxaTRlbktkbi94LzRaTG1zalg5UnpsemQyNGEreHBiVmthVUw3YnNN?=
 =?utf-8?B?dUw0WCtJUzNzRzBBK1NIcDlBTnE1N2NNVWJhOEdjT1hsTjcvL1FJRHFPb0kw?=
 =?utf-8?B?U25QdVdaNzJ2S3FCOEdySC9sZC9tckhoL0ZOdW1PdWIreWlJM0U2UXJ3VGFR?=
 =?utf-8?B?TmdteHptUUhubmxOamJwL1lhMXZWYkEwcTJSMW1GbXR1M28vaHRmWTREVHJo?=
 =?utf-8?B?V01HdUxRVkhjYkdNVHJGTkhCNTd0Z1BWb1ZJVzVYbEdnRmlRaktGR0Fuekdo?=
 =?utf-8?B?d25ReThwZi9tclJXaFMzcUsyR1hSeUNiTjhEc0YzSzRjOTZRNTd1bHBIUUg2?=
 =?utf-8?B?S20yclhKQmFzdWFpakcyVWdnNWV6WXhUQk9COUhoQmRVNS91WHV6NTdrMHN0?=
 =?utf-8?B?Q0NMc3RHV0h3YWN3SGcwTno3c1hoZmxFT1R2cU0vVDNjKzc1VnFkVzFZWWxW?=
 =?utf-8?B?aStzTGNLWTErWGZ4S3R5Sm4ydWZvbkx0NlBBRU9zVEhqek8rUGFoYUpvOStp?=
 =?utf-8?B?Z0xoT2dkV1k0SnhYQVN2Y3ljRDlNV0JFTHdhQmEyYzNOZmVFSEEyd3BTV29O?=
 =?utf-8?B?Y25tOFhxY2Y1Y3IwRW1Ncy8vb1g1bkFibW03NG5JeEFIQmZoeVdmdDhaVWlU?=
 =?utf-8?B?dW1PZVRqZmt3T3RhVUhNYmQ5aXIrYTNlZGxXeVBJam5vV3k3ZldOTXZ4RVoy?=
 =?utf-8?B?b3pnb1Q3S3BycnNMTGk4QTZNMEoxcGpLdURqbjdSdnBEdEVGaHhwQXhwTytr?=
 =?utf-8?B?VlNJQlFLRXJmakNuUloyNFdhcWhiNG8wQVhtVzBQakhPMklxZW5xUUM2U2NM?=
 =?utf-8?B?ZnE5ODY4RE1YUXBpdEVtYUV3a2ZFYk1ocmZIa3hTbDdFMHNFeUo4ZHJwUG1F?=
 =?utf-8?B?MkllU1c5MHBwVy8vem9SR2tsR0k0Z2NmQnRSVGcvU3NqQXVHMDNUU01SczRE?=
 =?utf-8?B?SkdQb04xWnVXSzZQb3J1Qk1tcXNUVVJ1d0taUi9MenFpR0ptbWl3Uy80ZGh0?=
 =?utf-8?B?a0NoV3h3NXM5WVdZbXFtU01FaWxGaEJCM1NOa1FBbk5ucEVhSDFFaXdNeHd4?=
 =?utf-8?B?RFFJY3crSWVGUHIwMDBsaEEwYSs1blZQL2w2aDBBeWo3V2pCV2Z5TDdua1d1?=
 =?utf-8?B?V3FaalNzY2h4bGxlQmdUK2pEVjc1V0I4Yk03amlFTWV6OUE1MG4xd2NEbDMz?=
 =?utf-8?B?dWwrcFkxY3JMbXBicjg4eHZmSExXOVZSbkIrMlRhVFBEUjI0TnhGb2dhSW5Y?=
 =?utf-8?B?Z0JTNDJKT2phYjNLeGhOVkxUZXVObnI1dzlQdXpzbmt5QkZNWGN3K1NzaWh3?=
 =?utf-8?B?VU9QVFJsdmV3dDZrM1QxWlR3YW9kd3dlU0V5Zk1WVjZDYjFOa3hJalRseTJh?=
 =?utf-8?B?cjNGNEljQ3RySGV2bDhmYkFVNGd4WWR4d0xUT1c4aDJSWTREVWhqR2RlUFNx?=
 =?utf-8?Q?IOA/mqE4NCFwjFn4z/qJ4v5Cu2xQeYgx4KIbKWDKRCIT?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 108934a3-fc93-4007-c980-08db573302ab
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 00:01:20.6654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RWsrnucVlk0JudvdPUtg3WPRvPc7Png/EmeVtOg5x1hNnJHBbIOG1AfQynDSvaCWyT7l+kaz9keLOeLdn410vA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5236
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/17/23 12:33, Hamza Mahfooz wrote:
> get_available_dsc_slices() returns the number of indices set, and all of
> the users of get_available_dsc_slices() don't cross the returned bound
> when iterating over available_slices[]. So, the memset() in
> get_available_dsc_slices() is redundant and can be dropped.
> 
> Fixes: 97bda0322b8a ("drm/amd/display: Add DSC support for Navi (v2)")
> Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> index b9a05bb025db..58dd62cce4bb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> @@ -645,8 +645,6 @@ static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *av
>   {
>   	int idx = 0;
>   
> -	memset(available_slices, -1, MIN_AVAILABLE_SLICES_SIZE);
> -
>   	if (slice_caps.bits.NUM_SLICES_1)
>   		available_slices[idx++] = 1;
>   

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>