Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f424478c-dc1e-a75d-d7ea-853546dd582c@amd.com>
Date:   Wed, 17 May 2023 18:04:45 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 3/3] drm/amd/display: drop unused count variable in
 create_eml_sink()
Content-Language: en-US
To:     Hamza Mahfooz <hamza.mahfooz@amd.com>,
        amd-gfx@lists.freedesktop.org
Cc:     kernel test robot <lkp@intel.com>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Qingqing Zhuo <qingqing.zhuo@amd.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Hersen Wu <hersenxs.wu@amd.com>,
        Stylon Wang <stylon.wang@amd.com>, Jun Lei <Jun.Lei@amd.com>,
        Leon Huang <Leon.Huang1@amd.com>,
        Wenjing Liu <wenjing.liu@amd.com>,
        Mike Hsieh <Mike.Hsieh@amd.com>,
        pengfuyuan <pengfuyuan@kylinos.cn>,
        Nasir Osman <nasir.osman@amd.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230517183350.314082-1-hamza.mahfooz@amd.com>
 <20230517183350.314082-3-hamza.mahfooz@amd.com>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20230517183350.314082-3-hamza.mahfooz@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2VrRzczcGd5ZXlSN2dOUHl1ZnFNcnRhV0xmS2lmdnZtZzN6cDczL2YyWVQr?=
 =?utf-8?B?YldSQUFHMjhiL3Aya1ozZHM0cUZ1Rk85WFNmVTFSODhBbmxwT2h3dVJNTFJm?=
 =?utf-8?B?QWVnRnliSHBJVTZJemZhMHRnZzNyZkxsKzAzRnFSbEhLT1Frb1JFU3lhYm9W?=
 =?utf-8?B?VzMzS3F5NFU4NGw1Z3VMNS9MTGhwR05nMStseHl2RUNlcUVaQTNZaWtmOFFE?=
 =?utf-8?B?VHhMemhBWlNFdnFBN081cFBheXZYUWRKKzFlSVFYR1FwY0RlWklBV05sNXJk?=
 =?utf-8?B?ejhVQXZWQU9Jc2dvbzRXZU5BSERkcWVCTDc2WWpMcytFNkcvUDh0VDZWWitJ?=
 =?utf-8?B?T3Q5WXMvMUlMMnhhdkxqLzZlQzFaRVlMai94ZEQ3bTFEUlpJNmk5NVBNcFJ0?=
 =?utf-8?B?L2tUTFM3bmt0QlhFWWVGU3I3ODJoelRlQW5DcVFWcGVOSXZmWVhpaGlUbkY4?=
 =?utf-8?B?NEFwSmliVXpiRUZqWlBTcEU3N0N2ZFhPR1ZHaUNkNVZpOEowVEhaUndkR1RH?=
 =?utf-8?B?bzBDMnl1VE1mRlNkREFSYWUrQUpYb2RNck9WM0hTaDJEYU9GRHdzaE1qV1FL?=
 =?utf-8?B?WXowTFBtQnpJZ1dTUDhZQ0c4YTNrOWt6bHNZcmtWeWxqQndDbDE0OEwvbG5u?=
 =?utf-8?B?L05VNE9qelRGMDB6cDNqZHgwNmJrSG8zUDloL01NUHFUQXljakNqa09wdVlY?=
 =?utf-8?B?WXBjRUF2bVlNQVBOblNJZlo3djFrVDNzdDRjb0pKcnNJaTI2RkkyT2tjUkNN?=
 =?utf-8?B?QTZUbWNoT2NPcktBeWFFWjVoWXVBRXlhVEtYOWpGU25vT3NaTWVFOUFPZ3Nh?=
 =?utf-8?B?dHVNZ2hlYVpiM0lLZUQ4RFV1RnZCZU9iSGUxOUk5cUFlSW5wRVpxUDZkR0N6?=
 =?utf-8?B?OXdqa3RUNTcxWDNLakk2N1U3RDZlU29STmx4MUFnamlTb0FlWThOVDg3cDBL?=
 =?utf-8?B?RzlnS0J3SDVpakxlSnIyZyt3SWI0WWpsNzQwNmxrTU1ybzR2SzBIRXZQeUp0?=
 =?utf-8?B?Q1Fxbi92dlROak5DNlprUG92ZHBBdWMwdjVCYk9qQzhvYVZPWGwrK1JqWDRu?=
 =?utf-8?B?elZFUndBQUprbVlGMVVJcHlQRmhRaFJWOUVwYWkwSXlta3BUMW1pOGo5RVp0?=
 =?utf-8?B?VlluNGJYQVFZdjhrYWl1Q3lyZDRFUGlRcU1lRW1HTTA1QUxuR0FPcC9NRVA4?=
 =?utf-8?B?RHhrS0s5MHpnWmtqMlJDbEVlOEdqUWZoaWpZb0RrdERMcWc2QlFoMzZWM0tw?=
 =?utf-8?B?NjJUdDc4YkdwRjFWMUlSdG5nVmdST2YzT0F4UDNSL0lwNXg5V0hRTVYzeUFn?=
 =?utf-8?B?VVZraUY1L01jeEczbjdzTld3bHlxcG5ad09vdmM5WE1yVm54VTUyWW5HQTNB?=
 =?utf-8?B?cmZyYnVhaWNqT215M055RVdSZmpzOEQzRWh0SExtNkhFVUJiMUFiVkhUQXBY?=
 =?utf-8?B?aXBGZFhxUk95N1YrNjhyNlNhd0tYSVd6cmdmdDZ4bVFoVkFDVy9ianl5RDdW?=
 =?utf-8?B?T2NrSzg4SHhYdXJKS1lxYkJWcmZHRFVmQ0NtT3VqbHpLZFQveTdWSVlGTkRh?=
 =?utf-8?B?clFJS1MzZTJqZjZlYUdqSWRseUZkS2RJYktqa1hXVTJCOW42eVd1VlhQa2Nl?=
 =?utf-8?B?V1FsTUF3UzZQQS9oRjJsR1MrWFhoZWRWdkJPVklwTE9CNzdLTjV2OVVUTFpy?=
 =?utf-8?B?ZURtT2FjZnJTU29tMTZTWk5hKzZGdk54QmhVSHA5WTNhR3pxbTIxa04vV1Bu?=
 =?utf-8?B?aUZKY2w4SmF6aUR2Qzg3MnAvWlhjTjFJekpoWi80UU96QzAvbFNReGtKRktO?=
 =?utf-8?B?RzdZTVZyekZBVHRXSzJhQjNYcHpnMlVFS3FzUlRnaHRVaDZEZ2dreWhObFpH?=
 =?utf-8?B?Nit4b2w4dGttQ2ErRkNIVE1sTVhadGhNeDRsWUVrbkd1cXc4ejVjdWZJTWhk?=
 =?utf-8?B?Zm9TSnRLcFQyTjZqOHNBMzExZy9rOHkvUFlvWHhJRU9xSnA2cFI0NjlKMUVR?=
 =?utf-8?B?aUx6VTRKRjBsb3A0ODl6RU50R3h1WnF0eStGbHN5NThtVzRheTdBTkR1aFhr?=
 =?utf-8?B?QWVibGdKbXY5bGgvWkdhVTdhYTZXc1hnaUI3NjlGVnFyS0VoSjZOVWlyOEJ0?=
 =?utf-8?B?SDMvak1uLzVPSnRRVG9kWmpEU0ZzZWd0bjYva1J3aURGSTJ5Y2hLbGoxaE1x?=
 =?utf-8?Q?iQdGrurwRSOVXPPon6DlikPLDtOSi3PrVAfKcTo686uD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e944c35-b1d8-4eb7-6475-08db57337f3a
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 00:04:49.5141
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b3NsDLDwmZdSUgSKVfxoovSNEmgnFDGv1I/TAoAnUNcTDC45YwFFl70vdKaI7MCcrgbNaOf+CzMoDoHbW67QiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5236
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/17/23 12:33, Hamza Mahfooz wrote:
> Since, we are only interested in having
> drm_edid_override_connector_update(), update the value of
> connector->edid_blob_ptr. We don't care about the return value of
> drm_edid_override_connector_update() here. So, drop count.
> 
> Fixes: 068553e14f86 ("drm/amd/display: assign edid_blob_ptr with edid from debugfs")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 14b296e1d0f6..5a2d04f47276 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6396,9 +6396,8 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
>   		/* if connector->edid_override valid, pass
>   		 * it to edid_override to edid_blob_ptr
>   		 */
> -		int count;
>   
> -		count = drm_edid_override_connector_update(&aconnector->base);
> +		drm_edid_override_connector_update(&aconnector->base);
>   
>   		if (!aconnector->base.edid_blob_ptr) {
>   			DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>