Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp248692rwd; Wed, 17 May 2023 18:03:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Y5yR33HTzFajb0efn8V5zeDwcpy5Jl+Z/l+xMssZwSxkUWl93SfNKoMoONLrj6AgVFJcg X-Received: by 2002:a05:6a21:9011:b0:103:9c25:99a3 with SMTP id tq17-20020a056a21901100b001039c2599a3mr106610pzb.59.1684371803884; Wed, 17 May 2023 18:03:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684371803; cv=none; d=google.com; s=arc-20160816; b=YQidt1fw4uKB9NC8r6l5QZGlqMGGqUKPnq1nf52Cxj/s/BayF5Rv8FVHrZH83bdjln UPSMRY0RkTAsaRcLcW1J91akGhUJ7W0ZGTVB8uuToFv98qQ46Ylz++rlMJXBSHHcjKd6 Le/XZsM7EO9q0uALH2qrw8CVRb6meO5fwWHeNrbnlXJz5vcMH4SXmLMKoExRNEtAO4ot 63Qp22lkf+c2KJPGVKg1x7CEGvglOg6Zc5vYV5DNnTvBBLlAHmil4vOeXy6SbZtRcmdU K54XrLKhl8i53w68PAamvC/OuhfozblZszgMs669gImB/+rZ8ucWtF9x8P+1CKwIJPlr tMGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=SghvpISWOr2Xb/wbBKmrX8f/G7elt4qY32AMimXheQA=; b=NjNj7iLdKd5c96CKUJew8kRyksZX+5dJFxFn6V1O73YoOzhig+NNSRe2Qp55ZCyeje S+vvMObLp+42r99ujAkPPyclg+oQAKbma8RS9gONaUXUNRJHwsFlbhSR10S4c//MzzxP BFELReNwdRLcp6t6n5BrSKiOcMkCM7XwkWSzqQPHFgB+2j1fx+Ey+IhQZCNzgAd3Secd s03Gqc/0yR76KcFT4IYkZDqY7iF3HzXGlZLj2MMd2nwSr1cRb8mg9tvNIpQcn4gAUDCY 1kfv6LHD8LpcV/aMEjb21KXeE+LfjciftOaLjsFlgckQmpfMSJqu18SECR3Ng7H0lWaA ul4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=IBG+nTw6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a3-20020a17090a854300b00247ad6e4188si2937994pjw.51.2023.05.17.18.03.10; Wed, 17 May 2023 18:03:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=IBG+nTw6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229579AbjERARV (ORCPT + 99 others); Wed, 17 May 2023 20:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbjERART (ORCPT ); Wed, 17 May 2023 20:17:19 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2701A3AA1 for ; Wed, 17 May 2023 17:17:16 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-965a68abfd4so256663666b.2 for ; Wed, 17 May 2023 17:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1684369034; x=1686961034; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SghvpISWOr2Xb/wbBKmrX8f/G7elt4qY32AMimXheQA=; b=IBG+nTw6a9S41RaiATt9FaOTVAM8BW0SsRpKBG70mIJk1VQkCVz9FI5ORG0C0yMpoY KxRGxWy2rKXekTI0rpU+i2MyGHQo/IkfC9eD0Jsi34Kun68q4BGKjK7GrclveLWn2h+L T3nYGmA4/giGGqGgCrg54sbdj8a7PPdD5Htz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684369034; x=1686961034; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SghvpISWOr2Xb/wbBKmrX8f/G7elt4qY32AMimXheQA=; b=Q3mUz7Gqc74sPJFpLzPgurrUkDtXuECkOGmpaVyadHTJWFSTxQVKHu0E6JccINx2+z 0I498pATqKxrhA0vBW6/nbpqWLwEvnCcThrK22GpM1ELICDxwdP17dPwZJ/OSJ90s3EL LUyIkqUdebAhYsf0DurrWL1OY2fyduuAWUxXv3yPcq1tg6JPdj5cf7hFD4Gs5fWlWkRm QzZmX3KQjF97ZJu6LocJ1BMfJEzHHjN5OIuWgUaV6DGzWtpn9HAfpe/vikKFiWPJJ74n E3DmWYLHw9Uv8MFpow9dp/NqO8UrhfM9TPwgdDxkwax8zCPDWcabyfDMJJjYaBlRbkEr fqbg== X-Gm-Message-State: AC+VfDy4mlyUiR7UWc/T7htn7RGsldQGs1VMOEmbElm71thUwfLAQ112 NOGeRJ976aUTG2KenMPxuQFkjDQEXye8YQPqDwU3LN8/ X-Received: by 2002:a17:907:1c19:b0:94a:3ff1:53ad with SMTP id nc25-20020a1709071c1900b0094a3ff153admr40005965ejc.75.1684369034431; Wed, 17 May 2023 17:17:14 -0700 (PDT) Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com. [209.85.218.50]) by smtp.gmail.com with ESMTPSA id ke25-20020a17090798f900b00965f31ff894sm207384ejc.137.2023.05.17.17.17.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 17:17:13 -0700 (PDT) Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-965e4be7541so256907566b.1 for ; Wed, 17 May 2023 17:17:13 -0700 (PDT) X-Received: by 2002:a17:907:97c8:b0:961:b0:3dfd with SMTP id js8-20020a17090797c800b0096100b03dfdmr42523477ejc.7.1684369033423; Wed, 17 May 2023 17:17:13 -0700 (PDT) MIME-Version: 1.0 References: <20230518000920.191583-1-michael.christie@oracle.com> <20230518000920.191583-3-michael.christie@oracle.com> In-Reply-To: <20230518000920.191583-3-michael.christie@oracle.com> From: Linus Torvalds Date: Wed, 17 May 2023 17:16:56 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 2/8] vhost/vhost_task: Hook vhost layer into signal handler To: Mike Christie Cc: oleg@redhat.com, linux@leemhuis.info, nicolas.dichtel@6wind.com, axboe@kernel.dk, ebiederm@xmission.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, mst@redhat.com, sgarzare@redhat.com, jasowang@redhat.com, stefanha@redhat.com, brauner@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 17, 2023 at 5:09=E2=80=AFPM Mike Christie wrote: > > + __set_current_state(TASK_RUNNING); > + rc =3D get_signal(&ksig); > + set_current_state(TASK_INTERRUPTIBLE); > + return rc; The games with current_state seem nonsensical. What are they all about? get_signal() shouldn't care, and no other caller does this thing. This just seems completely random. Linus