Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 May 2023 19:13:07 -0700
From:   Bjorn Andersson <andersson@kernel.org>
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Bhupesh Sharma <bhupesh.sharma@linaro.org>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] arm64: dts: qcom: qrb4210-rb2: Add GPIO LEDs
Message-ID: <20230518021307.z63xrx5v2lhd3byf@ripper>
References: <20230515-topic-rb2-bits-v1-0-a52d154a639d@linaro.org>
 <20230515-topic-rb2-bits-v1-3-a52d154a639d@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230515-topic-rb2-bits-v1-3-a52d154a639d@linaro.org>
Precedence: bulk

On Mon, May 15, 2023 at 03:04:14PM +0200, Konrad Dybcio wrote:
> Add the three LEDs (blue/yellow/green) connected to TLMM GPIOs.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 36 ++++++++++++++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index 9b539720f05d..eeee268ebfe2 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -5,6 +5,7 @@
>  
>  /dts-v1/;
>  
> +#include <dt-bindings/leds/common.h>
>  #include "sm4250.dtsi"
>  
>  / {
> @@ -30,6 +31,38 @@ hdmi_con: endpoint {
>  		};
>  	};
>  
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led-bt {
> +			label = "blue:bt";
> +			function = LED_FUNCTION_BLUETOOTH;
> +			color = <LED_COLOR_ID_BLUE>;
> +			gpios = <&tlmm 45 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "bluetooth-power";
> +			default-state = "off";
> +		};
> +
> +		led-user0 {
> +			label = "green:user0";
> +			function = LED_FUNCTION_INDICATOR;
> +			color = <LED_COLOR_ID_GREEN>;
> +			gpios = <&tlmm 52 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "none";
> +			default-state = "off";
> +			panic-indicator;
> +		};
> +
> +		led-wlan {
> +			label = "yellow:wlan";
> +			function = LED_FUNCTION_WLAN;
> +			color = <LED_COLOR_ID_YELLOW>;
> +			gpios = <&tlmm 47 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "phy0tx";
> +			default-state = "off";
> +		};
> +	};
> +
>  	vreg_hdmi_out_1p2: regulator-hdmi-out-1p2 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "VREG_HDMI_OUT_1P2";
> @@ -385,8 +418,7 @@ &sleep_clk {
>  };
>  
>  &tlmm {
> -	gpio-reserved-ranges = <43 2>, <47 1>,
> -			       <49 1>, <52 1>, <54 1>,
> +	gpio-reserved-ranges = <43 2>, <49 1>, <54 1>,

How come pin 49 becomes inaccessible here? Was this intended for the
previous patch?

Regards,
Bjorn

>  			       <56 3>, <61 2>, <64 1>,
>  			       <68 1>, <72 8>, <96 1>;
>  
> 
> -- 
> 2.40.1
>