Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1683615352-10794-1-git-send-email-yangtiezhu@loongson.cn>
 <CAAhV-H7waE0gmSU09YKJMHDAnj7BV7ukiLqWs+JzzLrHDG5z8w@mail.gmail.com> <20230518030618.GB1068119@leoy-yangtze.lan>
In-Reply-To: <20230518030618.GB1068119@leoy-yangtze.lan>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Thu, 18 May 2023 11:12:26 +0800
Message-ID: <CAAhV-H6L9kNyGU2UrX7jyN_6O_pafSVSamP7DYHkzfMgmCxVXA@mail.gmail.com>
Subject: Re: [PATCH] perf symbol: Add LoongArch case in get_plt_sizes()
To:     Leo Yan <leo.yan@linaro.org>
Cc:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users@vger.kernel.org, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 18, 2023 at 11:06=E2=80=AFAM Leo Yan <leo.yan@linaro.org> wrote=
:
>
> On Thu, May 18, 2023 at 10:11:27AM +0800, Huacai Chen wrote:
> > Queued, thanks.
>
> The patch is fine for me.
>
> Should not perf patches are to be merged via Arnaldo's tree?
I think both are OK, if Arnaldo takes this patch, I will drop it.

Huacai
>
> Thanks,
> Leo
>
> > On Tue, May 9, 2023 at 2:56=E2=80=AFPM Tiezhu Yang <yangtiezhu@loongson=
.cn> wrote:
> > >
> > > We can see the following definitions in bfd/elfnn-loongarch.c:
> > >
> > >   #define PLT_HEADER_INSNS 8
> > >   #define PLT_HEADER_SIZE (PLT_HEADER_INSNS * 4)
> > >
> > >   #define PLT_ENTRY_INSNS 4
> > >   #define PLT_ENTRY_SIZE (PLT_ENTRY_INSNS * 4)
> > >
> > > so plt header size is 32 and plt entry size is 16 on LoongArch,
> > > let us add LoongArch case in get_plt_sizes().
> > >
> > > Link: https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dblob;f=3Db=
fd/elfnn-loongarch.c
> > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > > ---
> > >
> > > This is based on 6.4-rc1
> > >
> > >  tools/perf/util/symbol-elf.c | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-el=
f.c
> > > index b2ed9cc..5d409c2 100644
> > > --- a/tools/perf/util/symbol-elf.c
> > > +++ b/tools/perf/util/symbol-elf.c
> > > @@ -411,6 +411,10 @@ static bool get_plt_sizes(struct dso *dso, GElf_=
Ehdr *ehdr, GElf_Shdr *shdr_plt,
> > >                 *plt_header_size =3D 32;
> > >                 *plt_entry_size =3D 16;
> > >                 return true;
> > > +       case EM_LOONGARCH:
> > > +               *plt_header_size =3D 32;
> > > +               *plt_entry_size =3D 16;
> > > +               return true;
> > >         case EM_SPARC:
> > >                 *plt_header_size =3D 48;
> > >                 *plt_entry_size =3D 12;
> > > --
> > > 2.1.0
> > >
> > >