Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Angus Chen <angus.chen@jaguarmicro.com>
To:     akpm@linux-foundation.org, masahiroy@kernel.org, vbabka@suse.cz,
        peterz@infradead.org, ndesaulniers@google.com, paulmck@kernel.org,
        rppt@kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Angus Chen <angus.chen@jaguarmicro.com>
Subject: [PATCH] init: Add bdev fs printk if mount_block_root failed
Date:   Thu, 18 May 2023 11:53:21 +0800
Message-Id: <20230518035321.1672-1-angus.chen@jaguarmicro.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TxyNJMDnOFDxpN5KQoSThWRdwFMeWL+8J+hRVXfjXOLS6q5TJWQe2ulQ3OKr?=
 =?us-ascii?Q?0DL5l4oqOeU5a/MRvvZo1UQKmvwxWh9Av2XOyqCoqUaY99nYK8jqtX+hgJJn?=
 =?us-ascii?Q?Ij+VYJGwG7UKcYS8/2l8VYsdyRJ+iVPvX1jm8hWG5mhsXKZ/RLG2cjNP7XwW?=
 =?us-ascii?Q?dVjA3RgkFJ6HJi5hjDZF7S9t+90HqXFMs/CQfDdfiTpoQmAD2zKCg0Gbx505?=
 =?us-ascii?Q?/PDVPxH1R8X7tLyyJVTq0vYO9RhOXhT5b+cAIG3SdsdBYZsgPUuPdWpFPPXT?=
 =?us-ascii?Q?gCKpzMNMXxsJCFKTN/ondcY7kE46CSlqpjM35tbqA/pAcZgLXeLtCXQxzHdx?=
 =?us-ascii?Q?5yMoN9AfqKSkwG5jAQoOzqo5vAMn/q481M9J2YQE71CLGi5hIvzcAS7ggCTy?=
 =?us-ascii?Q?jfVqKiZo39oMElqjZqM7c1M2yDORpDd0BThRWNGWzijMNUxZRZ+ZgPnBaRHv?=
 =?us-ascii?Q?zr1W7lGeGFmguYMnw8+E7Q1fFx6y0T0sMQzk1lraTNAwx98ddwShiT1/OhJd?=
 =?us-ascii?Q?HcA6m4LAEfgCYU8NkOQDo/NXL42l4LNeo9tLZoFSGvLMazMRGLHdoZmmsap9?=
 =?us-ascii?Q?NFCtRnmyj/1VZB3ijCq91CLpeKuTA6AL9qCrCCwz7h4FcE2D32ZVBB6HYtoi?=
 =?us-ascii?Q?jWZStQTFmwryKSem7lntcIZut8ZidQaWYbC3TB5cd2pSkkjM5EY9Gl29n5jE?=
 =?us-ascii?Q?MiUjngRlSSCEACb0PWhNxlFpJTBoZIKvamRCDU6hGuRY+xAJb0auASjnEzA+?=
 =?us-ascii?Q?ZyVWJ/UiGzbVIVJiQf+HXWvuJcri86mW/QyyzoCtVDJmPFfXWviTqCAuoaMD?=
 =?us-ascii?Q?McjF1UBrtUgFLgSxq/V+PTU5WAlv/tiGmfSQhdfQR4+nT3X4ogWL6cbS1foh?=
 =?us-ascii?Q?Cd5oxmpwY6F9iu0GLrrDdSLsVaFqFm61HcIl5vDp+5u/+H7W69fCKirs+bbQ?=
 =?us-ascii?Q?fg09TL2thJtuYKV9mEz3ZYplOhATolsZmmEpbZlRbCsDgMYFoD4SH7rm1dOP?=
 =?us-ascii?Q?O3UR7AQNbcWQjkbz0cxgf1MYahJPEnluYJYK+3NGQpktOrk3po4bLm2NLoJ1?=
 =?us-ascii?Q?bf/puIgCZXiM+HWEwOv092smPH04V8pfLBFIqwVWJK9z6SfakCMJ6XMnF+3y?=
 =?us-ascii?Q?4cvmjrp92hmIMFcDQfnjegnXKHYMEe1rxVaH1HadxK0NydkYZA33/cdhbpxK?=
 =?us-ascii?Q?v1EydIHlNPL9n9ihKljiOp6H/0BuqEugtrkQSgZoFkVMIP62ex53m2cGQs6m?=
 =?us-ascii?Q?HO3WM0vQ4BFqcoR5Ucp9/5FD9QuAwdgp8G3hi9Wrc/AGDmU4H8bXo/cQfocV?=
 =?us-ascii?Q?APJf/0zKC0a28PnmWKmNfBiLr1S6Dl5YKqaUYu39ZGIbuC4vctiZO0u6zyI6?=
 =?us-ascii?Q?gqCDkXauFO7+8kTZ6y4t6hnP3nYo9KXWsZwuFYa84WXokTxNL7v75wsN+D09?=
 =?us-ascii?Q?1eu2hsdq0OD5cIxcDbmPy3rzI89xjzID+83Fvc3UjbBDOHtfImqJNdIZecnL?=
 =?us-ascii?Q?kTlx3SOzbpnTX09K8m8QHwRE9hTs56O8t/afEFiXEPOSUd8Id5OGA3GVfXFQ?=
 =?us-ascii?Q?8l7PIrVHIBuGAxWSc1nHi1mjS71KpCxdjsvVyJJ6oUjIofN3gTYlSjoRyILU?=
 =?us-ascii?Q?Rw=3D=3D?=
X-OriginatorOrg: jaguarmicro.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a690bd9-aa3a-471e-ab4b-08db57537a82
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3424.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 03:53:45.5445
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 1e45a5c2-d3e1-46b3-a0e6-c5ebf6d8ba7b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e5IlzbKWIO83ZJQHJfpgSjx/vVnSlHTw1Fd7oiMTOsAISiOar+TQpA/UdoBi1nEwCPBjvbPQ4Ie4HURtbHpINY+ycnGQnKXZFEKQja1q1HI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5451
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Attempt to printk all bdev fstype as root gives the following kernel panic:

[    1.729006] VFS: Cannot open root device "vda" or unknown-block(253,0): error -19
[    1.730603] Please append a correct "root=" boot option; here are the available partitions:
[    1.732323] fd00          256000 vda
[    1.732329]  driver: virtio_blk
[    1.734194] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(253,0)
[    1.734771] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.4.0-rc2+ #53
[    1.735194] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.10.2-1ubuntu1 04/01/2014
[    1.735772] Call Trace:
[    1.735950]  <TASK>
[    1.736113]  dump_stack_lvl+0x32/0x50
[    1.736367]  panic+0x108/0x310
[    1.736570]  mount_block_root+0x161/0x310
[    1.736849]  ? rdinit_setup+0x40/0x40
[    1.737088]  prepare_namespace+0x10c/0x180
[    1.737393]  kernel_init_freeable+0x354/0x450
[    1.737707]  ? rest_init+0xd0/0xd0
[    1.737945]  kernel_init+0x16/0x130
[    1.738196]  ret_from_fork+0x1f/0x30

QEMU command line:
"qemu-system-x86_64 -append root=/dev/vda rootfstype=ext4 ..."

This error is because ext4 is not buildin and request ext4 module fail.

As a hint, printk all the bdev fstype available for prompts.

Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
---
 init/do_mounts.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/init/do_mounts.c b/init/do_mounts.c
index 811e94daf0a8..7fa48590c681 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -427,8 +427,19 @@ void __init mount_block_root(char *name, int flags)
 		printk("VFS: Cannot open root device \"%s\" or %s: error %d\n",
 				root_device_name, b, err);
 		printk("Please append a correct \"root=\" boot option; here are the available partitions:\n");
-
 		printk_all_partitions();
+
+		if (root_fs_names)
+			num_fs = list_bdev_fs_names(fs_names, PAGE_SIZE);
+		if (!num_fs)
+			pr_err("Can't find any bdev filesystem to be used for mount!\n");
+		else {
+			pr_err("List of all bdev filesystem:\n");
+			for (i = 0, p = fs_names; i < num_fs; i++, p += strlen(p)+1)
+				pr_err(" %s", p);
+			pr_err("\n");
+		}
+
 		panic("VFS: Unable to mount root fs on %s", b);
 	}
 	if (!(flags & SB_RDONLY)) {
-- 
2.25.1