Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 May 2023 12:07:59 +0800
From:   Hongren Zheng <i@zenithal.me>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Indan Zupancic <Indan.Zupancic@mep-info.com>,
        "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] UIO: Let uio_pdrv_genirq support cached memory
Message-ID: <ZGWkn89Xr1YAP9K4@Sun>
References: <436ea1f019d26d28ab4fce4ee28f609b@mep-info.com>
 <20220505121518.46054-1-Indan.Zupancic@mep-info.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220505121518.46054-1-Indan.Zupancic@mep-info.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/eocpg3BlQoNvv0kOPzPVIT9+eheNmnuLvyXF772xOaNeoxdD4V/eq+5UmyO?=
 =?us-ascii?Q?cIpe8Z/5V7L2VyFfFV3FBQGH6hd+DEcfPdupl+oTxH5DYzpD0a8ijtXBmCHM?=
 =?us-ascii?Q?lQpxAxbMDciMb7GxMqYiMUduGvcXEr63fB1PZBn/wUc3JL+5GZWCoNX+pvNq?=
 =?us-ascii?Q?H34F7WuiojhD+k9N3seYed/2lvGRLWrbbNqe2MRncXV31qhdBpa0icYNDdSM?=
 =?us-ascii?Q?1DZVK2SkSxTNOyo4Oihyf8lVhatW6HfM2jjYHFCX3RAbP/ZbTuq3C9sDI2ud?=
 =?us-ascii?Q?RmJY9bmEQGWdach1jI9dEpbhtqZlcGK9CM6orUjn/ZCx+XG3DmuClHuOC+4F?=
 =?us-ascii?Q?2l0tP8fpmkGaxkRYOgsz6tg7CtBGtfBtkVB0FgBfV2XROO9V5z/Nu0ITJNIG?=
 =?us-ascii?Q?IQI51NshyxlngpYPX6xV1fX2nevIlX6A6Qnuu7su+OAoZT6f1Is0IXa93caJ?=
 =?us-ascii?Q?KTuFXYrr1Vr4m4x+2Vzw4lQA5PBafbRDbAp32hmXDPDt4cFFeqD3WV83K1+8?=
 =?us-ascii?Q?OkrcK/7mdvK4ZmiDzcihe4ub6tWr0ge/SR9jrbxao49qMZMpvm/ucVA2/Xec?=
 =?us-ascii?Q?OH9kq5jrKXYlA3I7KJcwrvgfG8Ks3bO9H+xXa1m985ZQpr98g0TV9z3fR8HL?=
 =?us-ascii?Q?VjkOZ0NhLWXVFITgp2NZOwYV3Vw3ymZI1JrYopgKjU9yMOhx4WRCpo4FtP/w?=
 =?us-ascii?Q?0z5427ObtBloXiWlHaPTUZiZpgUhoK25X+7OtM1ydOzrFiUYMRpdyOBVxtSS?=
 =?us-ascii?Q?BMR7ANwGaErMtehXC0Y4W4HRke5roRmTV28hlavWPKjXBETMWq+41wTI7DTb?=
 =?us-ascii?Q?Oef7p6Hs6564i0+ztySblwfEz43HK/hfn6eJx39GZPUKueoJ7oa2vukBWZm+?=
 =?us-ascii?Q?3tiQw8tsoXLOexXxmeTNmewSC8zzRXcSe4JtpYNtYP1EarMMhBTrGX7lunu8?=
 =?us-ascii?Q?SsZQ6MmrRbFuo7LU4hYZdDYAD7GlL/g135RDEFRlsuaL6sOC23cJoVZMbDHM?=
 =?us-ascii?Q?kZbpeiNLKMpZFFTrL/fCJFeSPVbdLpVtMx86HfbMJKjT1EI/q5dK9kgyr96c?=
 =?us-ascii?Q?8yVo75b+T9AZJwKiU9JQTJ9unWEiFFJfRnPCr5/v9g7Gb7ffG2FltmkbaN8I?=
 =?us-ascii?Q?v2kHQSkhqu+C90UWOpwED7zEqC3xRhFVFHSGrKQIiJllHBnhUoef/4qyB2Pr?=
 =?us-ascii?Q?w/nz6epACTeinMbiEvN+v/IOi/Kam/a1uRhKArJouFibY33MuCKeQtKgIcl2?=
 =?us-ascii?Q?EAIxIcQv4l72JUprAPm0y6wjjTqMY45RWoZyRfu8Y6CnG3q9I10ZKnHdhX9a?=
 =?us-ascii?Q?DeeRqPR2wWMZiCVzcLEYuoBOTaqwj3kSS5pbyksoBcKajpJYiMzNpwNnlfSv?=
 =?us-ascii?Q?Yuo3RWSHKsEfiE+H41++y+RAGvF91wG8pB2jbqp3/2JYtxbcelOB7hYpwACk?=
 =?us-ascii?Q?v26oWAjkil9Vccf1itlJfOLZPD+8vlUolmLdl0yfc/HhSYL1ELFY2ueOJFFr?=
 =?us-ascii?Q?3ts5h/SAh8iKDWOqGZYTH4CwNvHLl9l90s1CrWgor+9H6SV4JIrhwhtmWrBa?=
 =?us-ascii?Q?SdOQWl/HLRl6h7jIlAtQ0Rj/eTnRXdiD9BGTZ0PO?=
X-OriginatorOrg: zenithal.me
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a1c9779-6794-41c0-4cb9-08db57557e80
X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB1393.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 04:08:11.1626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 436d481c-43b1-4418-8d7f-84c1e4887cf0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D8NbCG1/xTaGlWYSJU8RVkCXi6yP3O/vSpjcCfRhp7g29g86MgOTpr3vw+h0dPzj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB2302
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 05, 2022 at 02:15:19PM +0200, Indan Zupancic wrote:
> If 'cacheable' DT property exists, the memory mapping will be
> done with UIO_MEM_IOVA instead of the default UIO_MEM_PHYS.
> 
> Signed-off-by: Indan Zupancic <Indan.Zupancic@mep-info.com>
> ---
>  Documentation/driver-api/uio-howto.rst | 3 ++-
>  drivers/uio/uio_pdrv_genirq.c          | 8 ++++++--
>  2 files changed, 8 insertions(+), 3 deletions(-)

I assume this is fundamentally OK? What else should be done to get this merged?

I plan to add similar functionality for uio_pci_generic,
especially for the RedHat IVSHMEM pcie device where
bar2 is just normal memory and should be marked
as UIO_MEM_IOVA as this has performance implication,
is that acceptable?

Cc'ed uio_pci_generic maintainer here.

> 
> diff --git a/Documentation/driver-api/uio-howto.rst b/Documentation/driver-api/uio-howto.rst
> index 907ffa3b38f5..3cb48fc757d9 100644
> --- a/Documentation/driver-api/uio-howto.rst
> +++ b/Documentation/driver-api/uio-howto.rst
> @@ -413,7 +413,8 @@ probed with the ``"of_id"`` module parameter set to the ``"compatible"``
>  string of the node the driver is supposed to handle. By default, the
>  node's name (without the unit address) is exposed as name for the
>  UIO device in userspace. To set a custom name, a property named
> -``"linux,uio-name"`` may be specified in the DT node.
> +``"linux,uio-name"`` may be specified in the DT node. If a property
> +named ``cacheable`` exists, the memory will be mapped cacheable.
>  
>  Using uio_dmem_genirq for platform devices
>  ------------------------------------------
> diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
> index 63258b6accc4..269784ce0ba3 100644
> --- a/drivers/uio/uio_pdrv_genirq.c
> +++ b/drivers/uio/uio_pdrv_genirq.c
> @@ -115,6 +115,7 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
>  	struct uio_mem *uiomem;
>  	int ret = -EINVAL;
>  	int i;
> +	int memtype = UIO_MEM_PHYS;
>  
>  	if (node) {
>  		const char *name;
> @@ -132,7 +133,10 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
>  		else
>  			uioinfo->name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
>  						       "%pOFn", node);
> -
> +		if (of_get_property(node, "cacheable", NULL)) {
> +			dev_info(&pdev->dev, "%s cacheable\n", uioinfo->name);
> +			memtype = UIO_MEM_IOVA;
> +		}
>  		uioinfo->version = "devicetree";
>  		/* Multiple IRQs are not supported */
>  	}
> @@ -204,7 +208,7 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
>  			break;
>  		}
>  
> -		uiomem->memtype = UIO_MEM_PHYS;
> +		uiomem->memtype = memtype;
>  		uiomem->addr = r->start & PAGE_MASK;
>  		uiomem->offs = r->start & ~PAGE_MASK;
>  		uiomem->size = (uiomem->offs + resource_size(r)
> -- 
> 2.30.2
> 
>