Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230518033310.19893-1-po-hsu.lin@canonical.com> <20230517205130.0b44e3d0@kernel.org>
In-Reply-To: <20230517205130.0b44e3d0@kernel.org>
From:   Po-Hsu Lin <po-hsu.lin@canonical.com>
Date:   Thu, 18 May 2023 12:30:49 +0800
Message-ID: <CAMy_GT8=eiF5GaoUungL6d7w4Lp7s=NOE_YpBf4GEFpqrHG++Q@mail.gmail.com>
Subject: Re: [PATCHv2 net] selftests: fib_tests: mute cleanup error message
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        roxana.nicolescu@canonical.com, shuah@kernel.org,
        pabeni@redhat.com, edumazet@google.com, davem@davemloft.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 18, 2023 at 11:51=E2=80=AFAM Jakub Kicinski <kuba@kernel.org> w=
rote:
>
> On Thu, 18 May 2023 11:33:10 +0800 Po-Hsu Lin wrote:
> > In the end of the test, there will be an error message induced by the
> > `ip netns del ns1` command in cleanup()
> >
> >   Tests passed: 201
> >   Tests failed:   0
> >   Cannot remove namespace file "/run/netns/ns1": No such file or direct=
ory
> >
> > This can even be reproduced with just `./fib_tests.sh -h` as we're
> > calling cleanup() on exit.
> >
> > Redirect the error message to /dev/null to mute it.
> >
> > V2: Update commit message and fixes tag.
> >
> > Fixes: b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit")
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
>
> missing cc netdev
Sorry my bad, wrong copy-paste, will improve the workflow to make sure
this won't happen again.
V3 is on its way