Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b16040e8-06f4-5c0e-7379-daa8226dc2a1@kernel.org>
Date:   Thu, 18 May 2023 07:49:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: linux-next: Tree for May 15 (config SERIAL_CPM)
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-serial@vger.kernel.org
References: <20230515141235.0777c631@canb.auug.org.au>
 <1538d954-864e-3a07-594a-dfe6d3178a72@infradead.org>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <1538d954-864e-3a07-594a-dfe6d3178a72@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16. 05. 23, 4:51, Randy Dunlap wrote:
> 
> 
> On 5/14/23 21:12, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20230512:
>>
> 
> commit e3e7b13bffae
> Author: Jiri Slaby <jirislaby@kernel.org>
> Date:   Thu Apr 21 12:17:08 2022 +0200
> 
>      serial: allow COMPILE_TEST for some drivers

That commit should be reverted. I didn't realize it wouldn't link, while 
it compiles fine.

> See this portion of that commit:
> 
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -783,7 +783,7 @@ config SERIAL_PMACZILOG_CONSOLE
>   
>   config SERIAL_CPM
>          tristate "CPM SCC/SMC serial port support"
> -       depends on CPM2 || CPM1
> +       depends on CPM2 || CPM1 || (PPC32 && COMPILE_TEST)
> 
> 
> When PPC32=y and COMPILE_TEST=y but CPM1 is not set and CPM2 is not set:
> 
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_release_port':
> cpm_uart_core.c:(.text+0x598): undefined reference to `cpm_uart_freebuf'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_set_termios':
> cpm_uart_core.c:(.text+0x8e0): undefined reference to `__cpm2_setbrg'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_break_ctl':
> cpm_uart_core.c:(.text+0xb10): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0xb6c): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_startup':
> cpm_uart_core.c:(.text+0x1d48): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_request_port':
> cpm_uart_core.c:(.text+0x1ddc): undefined reference to `cpm_uart_allocbuf'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2170): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_probe':
> cpm_uart_core.c:(.text+0x2474): undefined reference to `cpm_uart_map_pram'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2724): undefined reference to `cpm_uart_unmap_pram'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2838): undefined reference to `cpm_uart_map_pram'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_shutdown':
> cpm_uart_core.c:(.text+0x2aa8): undefined reference to `cpm_line_cr_cmd'
> /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2ba4): undefined reference to `cpm_line_cr_cmd'
> 
> 

-- 
js
suse labs