Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp580899rwd; Thu, 18 May 2023 00:36:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ilsGhc2orCWHTilX1YsCcWPBy4bla7G0sNFByythsvCEMimqO9v7oOGjILjisC6/8w/+Y X-Received: by 2002:a05:6a00:18a8:b0:646:6d5e:1d25 with SMTP id x40-20020a056a0018a800b006466d5e1d25mr3679854pfh.16.1684395382949; Thu, 18 May 2023 00:36:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684395382; cv=none; d=google.com; s=arc-20160816; b=VjNUo4Jx/4hek7PK5AlO0diYSFeyB/xfgtXxczNgO0YH4TYBCYICwBnoukaQchUpJf QKH+XFCb+wkjWtGCo50a3JzPXd+i8NIEiSKaD0a8isH10vdDNYnpqQfyNb1V6jcLpN0v YpxpxLFNKQYXn/J+gdp7Ow23FYUvXg7MhpaTXZvAyBoApMrGOGre0r9g/fEkSoWMAPYq 7Kbve9Hm2bi2a8b2FsnCeiEGUrPvUQii1LtO3VjEPRn1dD2ouTUqf4TWe/IyEUPuO7R+ 1tHa197mRQpu9/Mr9YFbi13UddtuW4CDVjcT0LJs9S4+EUyz3Ryz9SY9Inik/lph8cDy dsOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=6/pMkDHqpQee7Q5QnzaROcishnayyd/TZbSD01jovy8=; b=Qt/45emJVX2G4aXCA1uP0ZSMfVJJp/YF7vDJjHg612TM0e2C6TQt6sVR91Ocnajc9x WPbxUy2S19hSyZ9r3JpPXNXdqwckA1Nv05AHWyKFeJq1ogEDRTPwcVs/pFl5249/Go7x HmWsYy9HyOLAf3WNBcuNq1WArRr0k7BbgzcCwUnneT70PDKLdXLD8B2CGobt5xVkNTzi DcMf3C9AS9U5dbqgAGievBrd5oVsh5yrkw6LIm5qeFcF9QrKWjdaoxsvuHJPVG2EuBE2 aQLWRVCdsuKH6T6S1nd0nPSPuBZX5Tz30dI/EMwx2XivXlsmaFBsXXRIfB7MWNcOucfy xcMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Tx7Z33B3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v28-20020aa799dc000000b00645c34972a1si1018476pfi.234.2023.05.18.00.36.07; Thu, 18 May 2023 00:36:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Tx7Z33B3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbjERHbb (ORCPT + 99 others); Thu, 18 May 2023 03:31:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjERHb3 (ORCPT ); Thu, 18 May 2023 03:31:29 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D8EB213A; Thu, 18 May 2023 00:30:09 -0700 (PDT) Received: from booty (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7F2251BF204; Thu, 18 May 2023 07:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1684394930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6/pMkDHqpQee7Q5QnzaROcishnayyd/TZbSD01jovy8=; b=Tx7Z33B3eVZShtKikhLKhfxKEn0I3M0zPi6qXKlztvv0WPqWAUnDaTGJ/vuKHs+/5YQ9MR dUhfbCwqVN+7iXFC4I1x+qhAAdkMj+073xPwYtjpzOFNfsGcYJZRAhwll5VmEyRnKI+O9c 7KCWfqBtXqrUbC6bsTE0Ysih9q1tgPc9hu9J5ldSdgidhf7Inr5oCuNsJMY4lEfuizt6YS ay/in2/LvjycUMlmTIIXeJjhS9uZ2KF9Q7vfyd3yWrgjSS+Rsm7bNCsIMvgMs8VXIy2DpI 1iygqIKW5xgKTvf19jdlDw+mP1d+cjWhbPzC8XNJw0727qxXe4y8gRM2dpIDYQ== Date: Thu, 18 May 2023 09:28:46 +0200 From: Luca Ceresoli To: Uwe =?UTF-8?Q?Kleine-K=C3=B6nig?= Cc: Arnd Bergmann , Greg Kroah-Hartman , Bartosz Golaszewski , Jean Delvare , Eric Piel , Vladimir Oltean , Srinivas Pandruvada , Javier Martinez Canillas , Serge Semin , Wolfram Sang , Hans Verkuil , Justin Stitt , Yuan Can , Dan Carpenter , Adrien Grassein , Andy Shevchenko , Petr Machata , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH] misc: Switch i2c drivers back to use .probe() Message-ID: <20230518092846.2012482c@booty> In-Reply-To: <20230517220135.170379-1-u.kleine-koenig@pengutronix.de> References: <20230517220135.170379-1-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Uwe, On Thu, 18 May 2023 00:01:35 +0200 Uwe Kleine-K=C3=B6nig wrote: > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert > back to (the new) .probe() to be able to eventually drop .probe_new() from > struct i2c_driver. >=20 > While touching these drivers, fix alignment in apds990x.c and bh1770glc.c. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig It's finally happening, thanks! \o/ Reviewed-by: Luca Ceresoli --=20 Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com