Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c503c773-137c-0d76-9762-7ea6d3ee868c@quicinc.com>
Date:   Thu, 18 May 2023 13:17:28 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] remoteproc: qcom: pas: mark adsp_segment_dump() static
To:     Arnd Bergmann <arnd@kernel.org>, Andy Gross <agross@kernel.org>,
        "Bjorn Andersson" <andersson@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Sibi Sankar <quic_sibis@quicinc.com>,
        "Yogesh Lal" <quic_ylal@quicinc.com>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Abel Vesa <abel.vesa@linaro.org>,
        <linux-arm-msm@vger.kernel.org>,
        <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230516202332.560123-1-arnd@kernel.org>
Content-Language: en-US
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20230516202332.560123-1-arnd@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/17/2023 1:53 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The function has no other callers and should not be globally defined.
> Making it static avoids this warning:
> 
> drivers/remoteproc/qcom_q6v5_pas.c:108:6: error: no previous prototype for 'adsp_segment_dump'
> 
> Fixes: a376c10d45a8 ("remoteproc: qcom: pas: Adjust the phys addr wrt the mem region")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

This seems to be posted already

https://lore.kernel.org/lkml/20230507144826.193067-1-krzysztof.kozlowski@linaro.org/

-- Mukesh

> ---
>   drivers/remoteproc/qcom_q6v5_pas.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index e34d82b18a67..a1d69721a0e7 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -105,8 +105,9 @@ struct qcom_adsp {
>   	struct qcom_scm_pas_metadata dtb_pas_metadata;
>   };
>   
> -void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
> -		       void *dest, size_t offset, size_t size)
> +static void adsp_segment_dump(struct rproc *rproc,
> +			      struct rproc_dump_segment *segment,
> +			      void *dest, size_t offset, size_t size)
>   {
>   	struct qcom_adsp *adsp = rproc->priv;
>   	int total_offset;