Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230517223007.178432-1-boerge.struempfel@gmail.com>
 <CAOMZO5CqMMCCOsAB3YgJUUampE=iZru57d=qoX13-GkSaaC5gg@mail.gmail.com>
 <CAEktqcuMrqiwDfGM=SAoHiKPY-hupS+jipt=6Tasr1q8VUvRQQ@mail.gmail.com>
 <CAOMZO5CJwwKmDYRxnny2JOrwucGn=q7+9xKqk_NSvZ_wyNSHEQ@mail.gmail.com> <CAEktqcue7gFk9fXMsNPxwUsUVRxpa6GE5wCHZqU2p2dDz8WYqg@mail.gmail.com>
In-Reply-To: <CAEktqcue7gFk9fXMsNPxwUsUVRxpa6GE5wCHZqU2p2dDz8WYqg@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 18 May 2023 13:57:30 +0300
Message-ID: <CAHp75VcP78MhmjzOCiGwfEwWwVxCHhy3qmZet0HqjPeLTc9h-A@mail.gmail.com>
Subject: Re: [PATCH v4 1/3] spi: add SPI_MOSI_IDLE_LOW mode bit
To:     =?UTF-8?B?QsO2cmdlIFN0csO8bXBmZWw=?= <boerge.struempfel@gmail.com>
Cc:     Fabio Estevam <festevam@gmail.com>, bstruempfel@ultratronik.de,
        amit.kumar-mahapatra@amd.com, broonie@kernel.org,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 18, 2023 at 3:27=E2=80=AFAM B=C3=B6rge Str=C3=BCmpfel
<boerge.struempfel@gmail.com> wrote:
> Am Do., 18. Mai 2023 um 01:53 Uhr schrieb Fabio Estevam <festevam@gmail.c=
om>:

...


> Okay. I have begun to implement this. During this, I noticed, that if
> I called the new option
> "--mosi-idle-low", the alignment of the help-lines (and in the c code
> itself) would break.
> Should I therefore shorten the option name by using an abbreviation
> like "--mil", which is
> probably not very helpful as a "full option name", or should I touch
> all the other lines and
> insert necessary spaces, such that they are aligned once more? (And if
> so, should I do
> this in a seperate patch, preparing the addition of the new options?)

It's a user space tool where not so strict rules of commit splitting
apply (as far as I know), I would go with indention fixes in the same
patch that adds the option.

...

> > > While looking through the code, I noticed, that the latest two
> > > additions to the spi->mode
> > > (SPI_3WIRE_HIZ and SPI_RX_CPHA_FLIP) are also missing from this tool.=
 Is this
> > > by design, or should they then be included as well?
> >
> > Looks like these two are missing and would be good to get them included=
 as well.
>
> Okay. Should this be a separate patch, or should I add the support for
> all 3 mode bits in
> one commit?

Split them logically. Are they from the same group of bits? No? then split.

--=20
With Best Regards,
Andy Shevchenko