Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   wei.fang@nxp.com
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, Frank.Li@freescale.com, shenwei.wang@nxp.com,
        xiaoning.wang@nxp.com, netdev@vger.kernel.org
Cc:     linux-imx@nxp.com, linux-kernel@vger.kernel.org
Subject: [PATCH net] net: fec: remove useless fec_enet_reset_skb()
Date:   Thu, 18 May 2023 21:00:16 +0800
Message-Id: <20230518130016.1615671-1-wei.fang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sqRlZqTmR2Vb7W6WnVHV9uYHmVQBMtzVNAFd0NiBFVcDXhjCV8H8oVNRzQxn?=
 =?us-ascii?Q?6hUUDLBBM6hwxA9dgIs37VxeYzhea7iOGrBKrp2S2m/CvFdWbfiHX+GXk+AG?=
 =?us-ascii?Q?4e0j71AgTMCn96NHNueYCSHY0kqp2vsxR6ufvsBCyt6b9KxX6ZxD1Mb6/U3H?=
 =?us-ascii?Q?niNk/12uii8fQiKuXG53qJHECT3LQc/qprAWnN4iBOd6iMXPKKo09XiT+amm?=
 =?us-ascii?Q?Bs/Ee6iAd3/XMa9c2D46f8YFa6MilMy5lnRx68HTIcIPpQSwPN6zJEl8tdek?=
 =?us-ascii?Q?9Rp5Vy7y4EpvThyHwyE9vfui7OwwATGw9plx/c635dMOVp2Z1ou+raFkV+C6?=
 =?us-ascii?Q?ivPCStbvvXM0jVWARUh8M34ayLN5K61b9lcCQ3cDLfByv7Awz/rrTh+Rc6AL?=
 =?us-ascii?Q?hH1zav35xWxktSlcjNhWEW1UClTmDmWTK7qpd6guFyKJLKS/7cHG6e0+72gz?=
 =?us-ascii?Q?DpMMKX2ltdFSS27SWAkGgyNE3VUXKqqavoaxqOavZfd0lXWYcJL7F6Y0+kH1?=
 =?us-ascii?Q?lZOlMfdFQNH8pxgoLgUyNHYrj1vGf+6H6zGIoO2FuiW3dJ43Pg4O9lJuy2Ce?=
 =?us-ascii?Q?R1O8cSkvcgm2kPELFzFrJgfyNO9FCvbC+1xT67bUrUhKdCSGQ452Hmb0sF0I?=
 =?us-ascii?Q?0b9fTot1fgmwp8eZjVpV4sAgKjKC7Iz+lCVAZQ+OTfUkJn5oQgX9UWKVY8Ir?=
 =?us-ascii?Q?oY2g6bxbQnbnndZ0X/R+Ow490N6s+KJOzf2lP5HCn/7yF6L6s3BwSnwgD7gL?=
 =?us-ascii?Q?XR8rKEwDE71NieHYdwkwD+QmNzG69xZFufyK/sM6sVJxhq63IB3DR5RPxab+?=
 =?us-ascii?Q?CJ7POjAryU/qVHc3oQYouklM1uCJCE1wvLUSOrx1BdfB/epx7E+n6jwGqJMg?=
 =?us-ascii?Q?InWQgG/UzmZm9KMZxIUivFrbWnbQkvtT1axmKQ9vnazSqNlLt3gEwsAjv7HQ?=
 =?us-ascii?Q?ISQsriIbtnOGJvcAyTluBrEuEVH7xJBvyMzPq4CUveQcVYP4qQrora1np2Di?=
 =?us-ascii?Q?/Y6IXjXg1rFe2b0fSZR5sT9atgG5LsdvZ5RF6aBZtYltm1t4PPZOCa0PuYjU?=
 =?us-ascii?Q?M49iThUqJOx0hjp6/lF6DXA1R7uY2YqFIrw5cRPBafEXO5lEUMmkd/UYht7n?=
 =?us-ascii?Q?dD7yleUE97QHFyzDHqyOZPLDbeVnOUiHLmj7nqQkNeeQGN7JgB4WQvU1xT0g?=
 =?us-ascii?Q?XtIycIqKyVfWbrckYrofEmKwxw6JqMux98fcZLmuCQtIzusUU5B7buReJ7Rt?=
 =?us-ascii?Q?GvGTx2Hoy5k+SXqci1716IVsqrrP203OLfhk2QIpdX7StVf/uAkHncGT/Kbu?=
 =?us-ascii?Q?wU+LiiwYT1V78iRyy7f6TKyEg9ueVJWhHXU0hFeZagHircu6DQJB1I1ohhWF?=
 =?us-ascii?Q?3Q2YetY5vhH7TpyPCjktcJIGvBjKI+YF0/Zqon4QuunRluxyI4ez0/vjrdBx?=
 =?us-ascii?Q?6T+jPXdgSGDSqgv7hMsRDC5slcHAhqm28CVQ/9batuyIf4dl534Jlc8TRUvA?=
 =?us-ascii?Q?XBCOaGoB+jZ/Azcypokz5zsb0d+dzKlbQ8JeZ4DDCmnZdlkjfODqEEGJCky6?=
 =?us-ascii?Q?jF0BuN1gPUSYMGAXbm0y1ncvTvENM3JCBTwuMkcl?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fa4401f-c4be-42d0-b612-08db57a07cec
X-MS-Exchange-CrossTenant-AuthSource: AM5PR04MB3139.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 13:05:00.7304
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HDD828mKiaz807BegjcrnXNh/Wc3jvp571csBKutoJxmdAPZW1gznE1f1ol5wohqfmQqYcuoMnIE/KoGeWGiCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7896
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wei Fang <wei.fang@nxp.com>

This patch is a cleanup for fec driver. The fec_enet_reset_skb()
is used to free skb buffers for tx queues and is only invoked in
fec_restart(). However, fec_enet_bd_init() also resets skb buffers
and is invoked in fec_restart() too. So fec_enet_reset_skb() is
redundant and useless.

Fixes: 59d0f7465644 ("net: fec: init multi queue date structure")
Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 drivers/net/ethernet/freescale/fec_main.c | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 577d94821b3e..70ef969e6588 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -1011,24 +1011,6 @@ static void fec_enet_enable_ring(struct net_device *ndev)
 	}
 }
 
-static void fec_enet_reset_skb(struct net_device *ndev)
-{
-	struct fec_enet_private *fep = netdev_priv(ndev);
-	struct fec_enet_priv_tx_q *txq;
-	int i, j;
-
-	for (i = 0; i < fep->num_tx_queues; i++) {
-		txq = fep->tx_queue[i];
-
-		for (j = 0; j < txq->bd.ring_size; j++) {
-			if (txq->tx_skbuff[j]) {
-				dev_kfree_skb_any(txq->tx_skbuff[j]);
-				txq->tx_skbuff[j] = NULL;
-			}
-		}
-	}
-}
-
 /*
  * This function is called to start or restart the FEC during a link
  * change, transmit timeout, or to reconfigure the FEC.  The network
@@ -1071,9 +1053,6 @@ fec_restart(struct net_device *ndev)
 
 	fec_enet_enable_ring(ndev);
 
-	/* Reset tx SKB buffers. */
-	fec_enet_reset_skb(ndev);
-
 	/* Enable MII mode */
 	if (fep->full_duplex == DUPLEX_FULL) {
 		/* FD enable */
-- 
2.25.1