Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <69f2db7c-bc3d-b08c-c85d-66bb32c3766a@quicinc.com>
Date:   Thu, 18 May 2023 19:14:01 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] sched: core: Simplify cpuset_cpumask_can_shrink()
Content-Language: en-US
To:     Li zeming <zeming@nfschina.com>, <mingo@redhat.com>,
        <peterz@infradead.org>, <juri.lelli@redhat.com>,
        <vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
        <rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
        <bristot@redhat.com>, <vschneid@redhat.com>
CC:     <linux-kernel@vger.kernel.org>
References: <20230518203416.3323-1-zeming@nfschina.com>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20230518203416.3323-1-zeming@nfschina.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/19/2023 2:04 AM, Li zeming wrote:
> Remove useless intermediate variable "ret" and its initialization.
> Directly return dl_cpuset_cpumask_can_shrink() result.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>

Acked-by : Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh
> ---
>   kernel/sched/core.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index a66960da3f5c..f3f2ece26291 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -9273,14 +9273,10 @@ void __init init_idle(struct task_struct *idle, int cpu)
>   int cpuset_cpumask_can_shrink(const struct cpumask *cur,
>   			      const struct cpumask *trial)
>   {
> -	int ret = 1;
> -
>   	if (cpumask_empty(cur))
> -		return ret;
> -
> -	ret = dl_cpuset_cpumask_can_shrink(cur, trial);
> +		return 1;
>   
> -	return ret;
> +	return dl_cpuset_cpumask_can_shrink(cur, trial);
>   }
>   
>   int task_can_attach(struct task_struct *p,