Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 May 2023 15:58:51 +0200
From:   Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To:     Tom Rix <trix@redhat.com>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and
 emu1010_pads_info storage-class-specifier to static
Message-ID: <ZGYvG2Sf9ZeeOmL6@ugly>
Mail-Followup-To: Tom Rix <trix@redhat.com>, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <20230518123826.925752-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20230518123826.925752-1-trix@redhat.com>
Precedence: bulk

On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote:
>smatch reports
  ^^^^^^ is this the best word to use here?

>sound/pci/emu10k1/emumixer.c:519:39: warning: symbol
>  'emu1010_routing_info' was not declared. Should it be static?
>sound/pci/emu10k1/emumixer.c:859:36: warning: symbol
>  'emu1010_pads_info' was not declared. Should it be static?
>
>These variables are only used in their defining file, so it should be static
							  ^^ they
>
>Signed-off-by: Tom Rix <trix@redhat.com>
>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>

(also amending one of the still pending patches. thanks!)

regards