Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Thu, 18 May 2023 15:06:22 +0100
Message-Id: <CSPGMHY9BH1S.J16A0P4WUJ9V@lion>
Cc:     <linux-arm-msm@vger.kernel.org>, <linux-leds@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <~postmarketos/upstreaming@lists.sr.ht>,
        <phone-devel@vger.kernel.org>, <amartinz@shiftphones.com>
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: sdm845-shift-axolotl: enable
 flash LEDs
From:   "Caleb Connolly" <caleb.connolly@linaro.org>
To:     "Dylan Van Assche" <me@dylanvanassche.be>, <agross@kernel.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <pavel@ucw.cz>,
        <lee@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <quic_fenglinw@quicinc.com>
References: <20230518133113.273880-1-me@dylanvanassche.be>
 <20230518133113.273880-4-me@dylanvanassche.be>
In-Reply-To: <20230518133113.273880-4-me@dylanvanassche.be>
Precedence: bulk

On Thu May 18, 2023 at 2:31 PM BST, Dylan Van Assche wrote:
> The SHIFT6mq (axolotl) is an SDM845-based smartphone with 2 flash LEDs.
> One LED is white, the other one is yellow. Define both LEDs in the DTS
> so they can be used as flash or torch and enable the flash LED
> controller to control them in PMI8998.
>
> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>

// Caleb (they/them)

> ---
>  .../boot/dts/qcom/sdm845-shift-axolotl.dts    | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm=
64/boot/dts/qcom/sdm845-shift-axolotl.dts
> index 0ad891348e0c..1eaff964b202 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> @@ -554,6 +554,28 @@ led@5 {
>  	};
>  };
> =20
> +&pmi8998_flash {
> +	status =3D "okay";
> +
> +	led-0 {
> +		function =3D LED_FUNCTION_FLASH;
> +		color =3D <LED_COLOR_ID_WHITE>;
> +		led-sources =3D <1>;
> +		led-max-microamp =3D <100000>;
> +		flash-max-microamp =3D <1100000>;
> +		flash-max-timeout-us =3D <1280000>;
> +	};
> +
> +	led-1 {
> +		function =3D LED_FUNCTION_FLASH;
> +		color =3D <LED_COLOR_ID_YELLOW>;
> +		led-sources =3D <2>;
> +		led-max-microamp =3D <100000>;
> +		flash-max-microamp =3D <1100000>;
> +		flash-max-timeout-us =3D <1280000>;
> +	};
> +};
> +
>  &qup_uart9_rx {
>  	drive-strength =3D <2>;
>  	bias-pull-up;