Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <822eda9c-6b1b-8c27-27ee-6f2855a261a5@redhat.com>
Date:   Thu, 18 May 2023 07:18:45 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.0
Subject: Re: [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and
 emu1010_pads_info storage-class-specifier to static
Content-Language: en-US
To:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
References: <20230518123826.925752-1-trix@redhat.com> <ZGYvG2Sf9ZeeOmL6@ugly>
From:   Tom Rix <trix@redhat.com>
In-Reply-To: <ZGYvG2Sf9ZeeOmL6@ugly>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 5/18/23 6:58 AM, Oswald Buddenhagen wrote:
> On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote:
>> smatch reports
>  ^^^^^^ is this the best word to use here?

I have been running smatch against the whole tree for a while, using 
this preamble.

Many fixes later, for the most part the tree has been cleaned of this 
class of problems.

Tom

>
>> sound/pci/emu10k1/emumixer.c:519:39: warning: symbol
>>  'emu1010_routing_info' was not declared. Should it be static?
>> sound/pci/emu10k1/emumixer.c:859:36: warning: symbol
>>  'emu1010_pads_info' was not declared. Should it be static?
>>
>> These variables are only used in their defining file, so it should be 
>> static
>                               ^^ they
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>>
> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
>
> (also amending one of the still pending patches. thanks!)
>
> regards
>