Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 May 2023 16:31:46 +0200
Message-ID: <87wn15hfsd.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc:     Tom Rix <trix@redhat.com>, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and emu1010_pads_info storage-class-specifier to static
In-Reply-To: <ZGYvG2Sf9ZeeOmL6@ugly>
References: <20230518123826.925752-1-trix@redhat.com>
        <ZGYvG2Sf9ZeeOmL6@ugly>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 18 May 2023 15:58:51 +0200,
Oswald Buddenhagen wrote:
> 
> On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote:
> > smatch reports
>  ^^^^^^ is this the best word to use here?

Note that smatch is a name of a static analysis tool :)

> > sound/pci/emu10k1/emumixer.c:519:39: warning: symbol
> >  'emu1010_routing_info' was not declared. Should it be static?
> > sound/pci/emu10k1/emumixer.c:859:36: warning: symbol
> >  'emu1010_pads_info' was not declared. Should it be static?
> > 
> > These variables are only used in their defining file, so it should be static
> 							  ^^ they
> > 
> > Signed-off-by: Tom Rix <trix@redhat.com>
> > 
> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> 
> (also amending one of the still pending patches. thanks!)

Applied the patch now, thanks.


Takashi