Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 May 2023 07:36:29 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Ira Weiny <ira.weiny@intel.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Dave Jiang" <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] tools/testing/cxl: Document test configurations
Message-ID: <646637ed846ae_1111d3294e6@iweiny-mobl.notmuch>
References: <20230426-cxl-fixes-v1-0-870c4c8b463a@intel.com>
 <20230426-cxl-fixes-v1-3-870c4c8b463a@intel.com>
 <20230518105020.0000424a@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230518105020.0000424a@Huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mgf5+uJ7Y+2Q6lT2ICzUYGjzy/pgEZl5NC16Aq2FDKtBfqRpWNO+1h50kypt?=
 =?us-ascii?Q?DnFyezFIC/uDbOQ8p6FNjcFULA4BAfn1OyhUW/qU622zJLVpxUZYQyVOHCyj?=
 =?us-ascii?Q?RRmI4l8pgstIqf/JIapS5MWvqgSkOFqgD55wIsK0DUBVW+v5g9MkEtXzPmnF?=
 =?us-ascii?Q?664wC4iH8TZlWsmrfxQ8daBQ5xcYeHJOz07nqHBU1tDZTKByEteRFYsYoSMf?=
 =?us-ascii?Q?fxLoVqAMUn9OSliui+vO0e4R0HZnpibzpEKLYQ4hRG+vHZ1ut/LLfy8OK8Hf?=
 =?us-ascii?Q?hou1SH37VkjwPQpkB+OykK25fAhpv8nVyjz4YPGfcgYVDpRl+vGXx1fVDBTA?=
 =?us-ascii?Q?ZJcdwl7uKmHeaPIHJkkgYAvjaHUN/UK7WeA6q6wAGBzJ8QpwmwlX23eGu8PM?=
 =?us-ascii?Q?Sht+Z0SeARSMmiA8bW36RCFwTueMy+3HIUl1UMIEJJfLYvmXahVf4bKRsBuM?=
 =?us-ascii?Q?9r79M/mzBXYEtFg62lbWdv7kYyAxIqZJqIS7UjhA2LX5XyjQO7ZnSmP36Y5w?=
 =?us-ascii?Q?27Mz4Glbf+uhqEotEeU1NqDKokulXaTGci2NkHxQYU2MCL76xKM3jKySFMjz?=
 =?us-ascii?Q?50dJGxUl8te6pOFi1NlEqPZqYSSMiz05KeHTj9WDatcqh/11e54Qa0JDbduV?=
 =?us-ascii?Q?fIeZBBvOoZiri98vvgSHzH6mddKniRsx/WJS35FDMWG3pkqXWVtRKZuMuKOX?=
 =?us-ascii?Q?wPzyNnax8jnaxqdY1QgAtGhLwt3Yl66wpMNgPUQzkUD2ZywIyBvoDb0awwNC?=
 =?us-ascii?Q?SeWV9dLr4CwgdZb3wxrHuy5l6wH7lqCxu43D9UY0wUxYs02n7PKsQTPP+Us0?=
 =?us-ascii?Q?FawUXV0mHb7IOKqDv0Z4Cc0RhgSr0DWXN6KB8n29h2CHuPXG9whF72EAzzDA?=
 =?us-ascii?Q?HP0ejBP6oSmYEJYbwzjGh7yDMK8yzS0blsA9jImQc48Hpznl/F5tXXPApc1d?=
 =?us-ascii?Q?dtLK2ckxiBW6lUz8DsNs5A8UqAcn/vFXNirqr28RVh28xqWIIWDf8fu9WnbG?=
 =?us-ascii?Q?zrV0Tj8ccWYHPknPiQOUPxAqqpXVMkwA+i6XzJtzhrAQfigATO6/XO80B0xk?=
 =?us-ascii?Q?7g5O4EnhnvPCOGHbpGhK+yLQE3nVoldZbwr8eMtJTKu8kHb0yP4O3PMw0iE2?=
 =?us-ascii?Q?z+r+mbRzxYQ0X5zFpnnQetLK6DKHlL/gF8Lxs2kqsydVcR6RH/B79aMJg87F?=
 =?us-ascii?Q?bU6hCtI5iYerpSlaopOrtPrrm/6QUpJn/tc+PKuZu4d/iNDOiGgIfO/H/HSb?=
 =?us-ascii?Q?lNPnQyVXMY4ijTnEtfFSEIeTqb/OFhLDBU5zaYZJzfYYMR+Ms3SavnPfL4QW?=
 =?us-ascii?Q?5pDcs5HxE+WZhPqcnnO8VecPxB+TrHgwJ6nO1EibGpswXrzvvdimUCf+jzIR?=
 =?us-ascii?Q?UfY8rYU6T4PxC+isFzjkDb5eBiwK9VGtgdcPe9tW4CpnrF68Ygx0eV8VMWbT?=
 =?us-ascii?Q?p5UJEW5/aqyfDFv9quyS0SyHcxk5//yJtv7sOVNZ+jjV8P9wJbXzNGWGskfX?=
 =?us-ascii?Q?5yyPxeb+/hDCZCCnpgCUoZIWiOc8iX+3aztKq8XBLLtXurwA2wgZy3wWNNrZ?=
 =?us-ascii?Q?00UGbvl9g1W59dX8MGj1kB+/j+UJKRNl91WrAAUF?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 48d13fd2-aab1-4f09-903b-08db57ad4782
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 14:36:34.7784
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SSwEBPb1gvqUKytKF10Ig+LsmrphkUxX0Gbs0gLL/eUCFHFLbANRNwlfIXigTy3snk2zCFvaJM9tPqVYw71L7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8053
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jonathan Cameron wrote:
> On Wed, 17 May 2023 14:28:12 -0700
> Ira Weiny <ira.weiny@intel.com> wrote:
> 

[snip]

> > ---
> >  tools/testing/cxl/test/cxl.c | 75 ++++++++++++++++++++++++++++++++++++++++++--
> >  1 file changed, 73 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> > index bf00dc52fe96..bd38a5fb60ae 100644
> > --- a/tools/testing/cxl/test/cxl.c
> > +++ b/tools/testing/cxl/test/cxl.c
> > @@ -23,6 +23,31 @@ static int interleave_arithmetic;
> >  #define NR_CXL_PORT_DECODERS 8
> >  #define NR_BRIDGES (NR_CXL_HOST_BRIDGES + NR_CXL_SINGLE_HOST + NR_CXL_RCH)
> >  
> > +/*
> > + * Interleave testing
> 
> Doesn't include the cfmws, which will be tricky to draw, but maybe you could
> add something to indicate they interleave over the two HB sometimes?

I was mainly looking to document the devices below.  Because they are all
'platform_device' and they are assigned type in the code which made things
a bit harder for me to follow when I was going through it the other day.

> 
> > + *
> > + *             +---------------+                            +---------------+
> > + *             | host_bridge[0]|                            | host_bridge[1]|
> > + *             +-/---------\---+                            +--/---------\--+
> Text for host bridges is right aligned.

Ah true.  I used an online ascii editor for these.  :-D  So I did not pay
any attention when I copied pasted.

> > + *             /-           -\                               /-           -\
> > + *           /-               -\                           /-               -\
> > + *   +-------------+         +-------------+       +-------------+      +-------------+
> > + *   |root_port[0] |         |root_port[1] |       |root_port[2] |      |root_port[3] |
> > + *   +------|------+         +------|------+       +------|------+      +------|------+
> and root ports are left aligned.
> I'd shrink both boxes so they are same as the switches below - or expand them to give
> a space on either side of the text.

Done.

> >  
> > +/*
> > + * 1) Preconfigured region support (Simulated BIOS configured region)
> > + * 2) 'Pass-through' decoder
> > + *
> > + *       +---------------+
> > + *       |  hb_single    |
> > + *       +------|--------+
> > + *              |
> > + *       +------|--------+
> > + *       | root_single   |
> > + *       +------|--------+
> > + *              |
> > + *   +----------|----------+
> > + *   |     swu_single      |
> > + *   +-----|-----------|---+
> > + *         |           |
> > + *   +-----|-----+  +--|--------+
> > + *   |swd_single |  | swd_single|
> > + *   +-----|-----+  +----|------+
> > + *         |             |
> > + *  +------|-----+  +----|-------+
> > + *  |mem_single  |  |mem_single  |
> > + *  +------------+  +------------+
> mem[0] etc?  Also swd_single[0] etc?
> 
> For consistency with above.
> 

Actually mem_single[0,1].  yea swd_single[0,1].

> >  
> > +/*
> > + *  +---------------+ +---------------+
> > + *  | host_bridge[0]| | host_bridge[1]|
> > + *  +---------------+ +---------------+
> > + *  +---------------+
> > + *  |  hb_single    | (host_bridge[2])
> > + *  +---------------+
> > + *  +-----+
> > + *  | rch | (host_bridge[3])
> > + *  +-----+
> > + */
> 
> Not sure what this diagram is illustrating...

Just showing how the acpi_devices array below ties in with the above
diagrams.  Mainly that their is not a 1:1 corelation between
cxl_host_bridge[] and host_bridge[].  That index 2 and 3 are other
platform devices as shown.

I could probably make that equivalency note in the diagrams above where
hb_single and rch are defined/documented.

Let me do that.
Ira