Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1154009rwd; Thu, 18 May 2023 08:34:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7cgh2L6OXwAWCQQd4LVwagIQ9u+p3AdcEr1YZeY5gHI3ssEmqo/fxnPfW2njyAKJbQJidF X-Received: by 2002:a05:6a20:a201:b0:105:4184:17dd with SMTP id u1-20020a056a20a20100b00105418417ddmr112623pzk.15.1684424076014; Thu, 18 May 2023 08:34:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684424075; cv=none; d=google.com; s=arc-20160816; b=gAjI2FTMRZat2Wr71YVd7GDH8GykQr+jSFgt6EM0KVt2kAUk0sBp+/uyHTcp3CLwHr 9XusQ+V8bfafDIjTNjf+uMrkH4cVBIg7vwpfxb4M19Nl4wWemgTG4mzK14NGEs4T9+pq zfVRr5AA8hcBB5G42eDm8O5rthFYiTx83iUU7MTyWwVlroLEyeYleQnvMqRBoFbew5wH YsWjwHEGXN6CyfSNa2KkvZK/WfCmOD3Dx2DfJmBbmqxi7/vTDLUKrKcVV2Gv5mG3xvC6 IyjkXuObTMMZTcJrQvVKw3z3YjE0G2gdjZx+2OX0alLMBIEZ+p83IgINQrfgNdg+WBSx oR9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/xpMUL0qHEnqPhp5t+FnffITn8zAREvc5/wjSBvao98=; b=iJw/YMCpd4SDkHp2Wlm2nOFyxOFIQw99UyWwdg8kFqOkeZaA4RtaZ1BkysHfT71P2F QZedhuDWW9Hg9f0XWrq/qOZVVTSPUsteRc6V3uGtIHwSlbUl1seaEit4qDzyA1lVrPsR ejrhZJq0R2rv7I8aICnVAiePWNaW1TlrMA1arRrgbvj6dBictwDfLPDKwQA92JWTFAHj mHNsjRbfPpi1ipH2CtU/04f+YQrNV0o3VyhcqmrYajDU3ICrmxFAvY9BswBiYcmbl093 elq5a2PJcST2ln3ZtYJGA69YZOYMhJFWqrB4y2Uz2ZLyeHzLWSDvhgdaJbrqbrYKGi/b dAQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uW8OufCu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z5-20020a637e05000000b005250c24fa2esi1624270pgc.428.2023.05.18.08.34.23; Thu, 18 May 2023 08:34:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uW8OufCu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231942AbjERPEI (ORCPT + 99 others); Thu, 18 May 2023 11:04:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231904AbjERPD4 (ORCPT ); Thu, 18 May 2023 11:03:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0573170B for ; Thu, 18 May 2023 08:03:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9282664FF6 for ; Thu, 18 May 2023 15:02:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E875C4339E; Thu, 18 May 2023 15:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684422141; bh=xi3asrp56sPf98pO0KbOLnYOqohykz8L/amW+nqIs+E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uW8OufCuNHQQ7nfswu1Ueu3ITdB0P2RTXIV9e6yfCUYIDzzIs3AoQlrpKZcZGpqWh V+YSitL1FBM+xQuHfKelmMh0UPmtfcC10y1z8KpUA30dzcVtLVa5muOzq/vBv/ZL53 B0M0aYFzy4IFXn6VZ6dzQxsuaxvY1/citOAINEvMEllDeEz0JwybCwSoT7so4mAQCC 9/4uKTi4VsIcphyWitNBpkhy3t6vLF4bmPmeqTDLngrUoXPRWGOSJ9GJKAN6iezcc7 +hj15JkZaXQDQ0fLcg0MOXMXu6mPaLORXIqkWqzEj02mcTH9l/xAVgukySFQCfSd6x r1KXwdCLXJQzg== Date: Thu, 18 May 2023 08:02:19 -0700 From: Jakub Kicinski To: Alexander Lobakin Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Maciej Fijalkowski , Magnus Karlsson , Michal Kubiak , Larysa Zaremba , Jesper Dangaard Brouer , "Ilias Apalodimas" , Christoph Hellwig , , , Subject: Re: [PATCH net-next 06/11] net: page_pool: avoid calling no-op externals when possible Message-ID: <20230518080219.109675cc@kernel.org> In-Reply-To: References: <20230516161841.37138-1-aleksander.lobakin@intel.com> <20230516161841.37138-7-aleksander.lobakin@intel.com> <20230517210804.7de610bd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 May 2023 15:34:44 +0200 Alexander Lobakin wrote: > And seems like I didn't get the sentence regarding "allocate and throw" > :s This condition just disables the shortcut if any new page suddenly > requires real DMA syncs (and if it does, then the sync a line below will > take way more time than 1 more `if` anyway). Right, I misread.