Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1287334rwd; Thu, 18 May 2023 10:08:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5JIQt3A0K0BqWf+DsKcWFvQJM+k8Lzd3TnnxKf4xhq7ZI49C66IyDTlTIBB/SJWwdsdyKT X-Received: by 2002:a17:903:24e:b0:1ae:32d3:43b2 with SMTP id j14-20020a170903024e00b001ae32d343b2mr3304736plh.25.1684429700099; Thu, 18 May 2023 10:08:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684429700; cv=none; d=google.com; s=arc-20160816; b=XCN6qTH40MpXF99Wb6oxesih8u8s9vrKsKaxJJ2Os8YzBOKaoEZRrZ4Wb76GwKm2GS QwQtCe3/fKQq3+CARi7Sgi7tWW/Q7v0fq3l1eXG+f8GH6GPu4hYB7pkrS/SAKh83sfAz 5LyP9XabwP3FdvZhuU8a849J5dJQksqUdGgoVtMMmXwx66pvCWpORy0EShmwZesJIR5H A6M+iu3z4byvbUOrvUXAyjVTJzZLxH4K1m9jSpsFfR6BBScD9VQT8sDiWaJcb+v6SEgf 3bYkTSEt3uOiqjs5X81MfugTbQTe13mseX6Eym9LBX4BsPpEdLHjySRIGR6FV9RVX/Lc yKNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/jgrHUXHzSXyoln0ZF9l7GnKymMwuKkUAmMRtSvQh2A=; b=RL5bPY1NRfElFJCsz7EKHJSAKPDKS/uhqV66AxcXvN2KD8jTY9mSIKnZNI4fHWySfx QWNggCGKNlne0vFfNJStjSXcJ84k4Hh5nN20m2glayR1SolqEtqlxgEmZ20d2acVd8Ld usmK0J5qshI2RswJn0LNDRUiHFsVCOsIyszho7CzLqtgsF2YAezyXiUDCod31TAARTjC FDL52v9t0Cml0CcJwA1XMkY/0SBTsnAzs7kAzUiqrNf3XlVzKTiLa5PJLErv5ppyj/7d SYpHd1n9KLn4NHZh0RmDDh8rnQ46vcOBJOeOEkNIrgs05LiiTd+tHPeFk8yMyuCgO7e2 63NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EueXkezx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q8-20020a170902dac800b001a98c0d3a9esi1775203plx.557.2023.05.18.10.08.07; Thu, 18 May 2023 10:08:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EueXkezx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229666AbjERRDH (ORCPT + 99 others); Thu, 18 May 2023 13:03:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbjERRDE (ORCPT ); Thu, 18 May 2023 13:03:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE1CB10DF; Thu, 18 May 2023 10:03:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 534BA61A1D; Thu, 18 May 2023 17:03:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D3E1C4339B; Thu, 18 May 2023 17:03:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684429382; bh=VCCeLI373vWJ8f/V7BOKXbKqCsAysHhGwbaiZFbiJmk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EueXkezxKj8nsJY6EorpUBrXyGljC2oM1QZ+ceid8fG1IVIYkpXDLZkMjfRN5QDB2 Z150nRe+/hVcuOORPtXaJpq4vHrFh8+lRXxhG/NhNmUcALYlk8/5i6PNh4+43oSnVT 4LI0+bZ40SX2fM6qVvrG0jDp5dQs+XT/WTGa2QkUUaLUvwBpF5wuoZ9PSErDbJN6cc JizqUfJeuDqzlpg2rmHRyHJcq256RFrmrFcK1qdYxA3QbC0y+2vZZzwQ7TNEfbXvgs oMjAOzZmPeCxnng3UUPTAvmK0inbvh5x+G0+ctVTPM+n0HmhH10s8Y0aZynM8QFKsz mpq6yWqZTxQhg== Date: Thu, 18 May 2023 13:03:01 -0400 From: Sasha Levin To: Jiaxun Yang Cc: linux-kernel@vger.kernel.org, "stable@vger.kernel.org" , Daniel Borkmann , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Johan Almbladh , Thomas Bogendoerfer , Alexei Starovoitov , Andrii Nakryiko , "paulburton@kernel.org" , "linux-mips@vger.kernel.org" , bpf@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.3 08/59] bpf, mips: Implement DADDI workarounds for JIT Message-ID: References: <20230504194142.3805425-1-sashal@kernel.org> <20230504194142.3805425-8-sashal@kernel.org> <50FCC591-D86A-46A3-AF4A-DD68D2FACC78@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50FCC591-D86A-46A3-AF4A-DD68D2FACC78@flygoat.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 05, 2023 at 01:04:14PM +0100, Jiaxun Yang wrote: > > >> 2023年5月4日 20:40，Sasha Levin 写道： >> >> From: Jiaxun Yang >> >> [ Upstream commit bbefef2f07080cd502a93cb1c529e1c8a6c4ac8e ] >> >> For DADDI errata we just workaround by disable immediate operation >> for BPF_ADD / BPF_SUB to avoid generation of DADDIU. >> >> All other use cases in JIT won't cause overflow thus they are all safe. >> >> Signed-off-by: Jiaxun Yang >> Signed-off-by: Daniel Borkmann >> Reviewed-by: Philippe Mathieu-Daudé >> Acked-by: Johan Almbladh >> Link: https://lore.kernel.org/bpf/20230228113305.83751-2-jiaxun.yang@flygoat.com >> Signed-off-by: Sasha Levin > >Hi Sasha, > >I think this patch should count as a functional improvement instead of regression fix. > >Please drop it from stable queue. Dropped, thanks! -- Thanks, Sasha