Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 May 2023 19:17:45 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     wei.fang@nxp.com
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, Frank.Li@freescale.com, shenwei.wang@nxp.com,
        xiaoning.wang@nxp.com, netdev@vger.kernel.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: fec: remove useless fec_enet_reset_skb()
Message-ID: <ZGZduVeDx9TvlToT@corigine.com>
References: <20230518130016.1615671-1-wei.fang@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230518130016.1615671-1-wei.fang@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NHlOS/bz8RUzNE7LN0UwkSJ4twRPsfcHohc+37wfMyicdmdhvJAjwUyHepmA?=
 =?us-ascii?Q?EsYJeUGHClY3Wy9jWhEWsRZ4PP7ulNQLImsaVHDIQdQcusOY2C1D6bVwgjsj?=
 =?us-ascii?Q?id7SNFtrSo7y3YiuADj9FA7LeNI1gg4VPYMiqeisR8WW3NUfsETR+Hw99DTd?=
 =?us-ascii?Q?r7/Qs8jKXIM4NGE4QCJH89BK0saRoOh+F1n/WU3oW2as4KW6hSZkF4iV0EEV?=
 =?us-ascii?Q?rIUEALPXzChW7kM8/j/C2pl0eePv2D+mCiVusb2ZLA264+VpPUrIc08iJoBD?=
 =?us-ascii?Q?SUz3KaYkZSqijQYiqqaRgJESqfo3pYzMne5Qgxycm/84Tlo+B6fX4PbVeiE6?=
 =?us-ascii?Q?zPZXUlnqIaYYm6QTEVnzGfcwyEqaJl8BIhsQG2D66AHdj4E1/WPe8L2jihj8?=
 =?us-ascii?Q?YXsqsUom0sYYb8lQEVgciwdmQO0I5MIK58+WNW57YlZdaoTV32ELqfr7Bxt+?=
 =?us-ascii?Q?kJt0kxki8JsjyTBn5eFCxtOnFwRyBWrGH1I8Ee0W5Dl5JKg253GvytbtW2EJ?=
 =?us-ascii?Q?Vv9PhdelDEzP0ycF8GlLF5gWf1R9HwziSBH/Bp0mdW2RfoA0JFV4I0RU4+H2?=
 =?us-ascii?Q?xOI8BXFq03qXNAYpkApVMc+wMFdggwVLhiq9+1OSGxs8qdCrwEobwfcrs3sj?=
 =?us-ascii?Q?rqFF/BYmHITgBUcATUE+UOaJFJtQXphYrstVCoei+8FmGNa7hq5t+pYCS3u+?=
 =?us-ascii?Q?EXJU1K0VNP9M58DxgLrzWvCi1KG2+GCS6scQCGOzFJeNqCADdilOLYzFNYqk?=
 =?us-ascii?Q?8b5vCFUezqFqiUhYRZJzv8X5rRSWs+NW5lKtz4WKRECE61QlrtCGK1vR+L/V?=
 =?us-ascii?Q?GAtpn1WOqI27IhVdzfEHuIY6H6WccFCKJy/N6UcpYQHkLfA6rcFqQp51Qytg?=
 =?us-ascii?Q?VKb5X8Et0ZM68F1Wp3E0YYDuMJIHNakMcs5i9GfKZvHukbVGitlGq960+okw?=
 =?us-ascii?Q?GtWe4rA3NRXE7wFiX278yTDJf/fYsWzr9JD5lEZFHIDLr00iXs6ktYj0m2ru?=
 =?us-ascii?Q?cHmm/hViyU+pLOe3i0qJdnUKKuWTYkwjX10PYMdJE6ca+elmXfNXIyFtkAEm?=
 =?us-ascii?Q?CxgK4yF3TYoa2u0KpKy6zRQNdF3jPDCvprbuhx4CXB5WaDMIzp8bRcz9673L?=
 =?us-ascii?Q?psbajzjIr1cUYGKGlFWaf+9yBA81L+Kz1Mw9+orTKG1whFhod2I6BIK6Q0Tb?=
 =?us-ascii?Q?HSXZtOpZWO8vba7K/cHcLcXAhVPnhMJt5RYWykKU7sNY9sf7WEu8emvT7iT0?=
 =?us-ascii?Q?rqTO98aPPqASpjU0v8ZRuv8d4mUvKERnF1RBnZbWcB+lBkQjVVS478CkFOJC?=
 =?us-ascii?Q?w/MF8XjRKaoIQo/nOhO8ja6K/qK9eQ9l8Eb52EX8Oaq3VNVBIlbA22nKu1sn?=
 =?us-ascii?Q?pBZN43QpF58cKIh9OPMyfqjYYk+7aNcnzyBni6pS8rbB75uvo36E22W/z2nP?=
 =?us-ascii?Q?ZX3/2syL9BORk/nwoGOcsh9XI1AxIdW06It4Cf77zKOGF6VX10z0dEb3OW6T?=
 =?us-ascii?Q?E/I4dGTF7ZnpcjU90aA3nTsQObuo0hGUhb+IIZh+KqPuYG/e6Pf3E4oJSwsr?=
 =?us-ascii?Q?xNDVmQzA69xXrGe+iBwSj9Ik0fPkJXHaRI4sQYHQ8fjV4SgJMSfrxlfh63Hf?=
 =?us-ascii?Q?OD7YZGwwF3Dw+FdWICH5oV0vaVnsTcBf/RvzpR/YXl71TsfacyNJ4uST+Rsc?=
 =?us-ascii?Q?vqdokQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d780a7e3-9fb0-47a3-2035-08db57c3d008
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 17:17:52.5151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: upkhjqLe9HPXzaoB8JKTGxP3DdNrMywXbsT/e4nq4RkXPVdr2szPDdPYhdDGzmrcdVfhkS0Fl6W8Pn78JawfMkIVS5a+rcLI7g/933dip24=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR13MB6118
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 18, 2023 at 09:00:16PM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
> 
> This patch is a cleanup for fec driver. The fec_enet_reset_skb()
> is used to free skb buffers for tx queues and is only invoked in
> fec_restart(). However, fec_enet_bd_init() also resets skb buffers
> and is invoked in fec_restart() too. So fec_enet_reset_skb() is
> redundant and useless.
> 
> Fixes: 59d0f7465644 ("net: fec: init multi queue date structure")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>

Hi Wei Fang,

this change looks fine to me.
But it feels much more like a cleanup than a fix to me:
what user-visible problem is it fixing?

If so, I suggest targeting against net-next without the fixes tag.