Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 May 2023 13:47:54 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>
Cc:     Michael Ellerman <mpe@ellerman.id.au>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org,
        arnd@arndb.de, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH AUTOSEL 6.3 6/7] powerpc/fsl_uli1575: Allow to disable
 FSL_ULI1575 support
Message-ID: <ZGZkylhlTdJoZJ3V@sashalap>
References: <20230509035455.59524-1-sashal@kernel.org>
 <20230509035455.59524-6-sashal@kernel.org>
 <62539831-1f8c-d908-bd7c-2a926702fa7f@infradead.org>
 <87jzxix9g7.fsf@mail.lhotse>
 <20230509071835.rrfefrhwtwsxlngy@pali>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230509071835.rrfefrhwtwsxlngy@pali>
Precedence: bulk

On Tue, May 09, 2023 at 09:18:35AM +0200, Pali Roh?r wrote:
>On Tuesday 09 May 2023 17:14:48 Michael Ellerman wrote:
>> Randy Dunlap <rdunlap@infradead.org> writes:
>> > Hi--
>> >
>> > Just a heads up. This patch can cause build errors.
>> > I sent a patch for these on 2023-APR-28:
>> >   https://lore.kernel.org/linuxppc-dev/20230429043519.19807-1-rdunlap@infradead.org/
>> >
>> > Michael, I think this is your area if I'm not mistaken.
>>
>> Yes. The fix is in my fixes branch as:
>>   536d948a8dee ("powerpc/fsl_uli1575: fix kconfig warnings and build errors")
>>
>> But I don't think this commit (22fdf79171e8) really warrants going to
>> stable, it's a nice-to-have but doesn't fix any pressing bugs.
>
>Exactly. And also this patch alone without 1/8 would not work as in 1/8
>https://lore.kernel.org/all/20230409000812.18904-2-pali@kernel.org/ was
>added static inline variant of function which is used when ULI is
>disabled.

I'll drop it, thanks!

-- 
Thanks,
Sasha