Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 May 2023 14:59:26 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To:     "Liang, Kan" <kan.liang@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        James Clark <james.clark@arm.com>,
        Ian Rogers <irogers@google.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Thomas Richter <tmricht@linux.ibm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v1_1/2=5D_perf_test_attr=3A_?= =?US-ASCII?Q?Update_no_event/metric_expectations?=
User-Agent: K-9 Mail for Android
In-Reply-To: <9178149c-45e8-3de4-58db-b8b8d27b3a08@linux.intel.com>
References: <20230517225707.2682235-1-irogers@google.com> <64f329a9-09a3-aa84-a354-23a919062d09@arm.com> <ZGYYJ/biKyeFNJjL@kernel.org> <f753beda-2d5e-c391-520a-450b186fd4d4@linux.intel.com> <9178149c-45e8-3de4-58db-b8b8d27b3a08@linux.intel.com>
Message-ID: <053C65F5-503E-4DF8-8882-0B9EF1581D03@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On May 18, 2023 2:45:06 PM GMT-03:00, "Liang, Kan" <kan=2Eliang@linux=2Ein=
tel=2Ecom> wrote:
>Hi Arnaldo,
>
>On 2023-05-18 8:55 a=2Em=2E, Liang, Kan wrote:
>> On 2023-05-18 8:20 a=2Em=2E, Arnaldo Carvalho de Melo wrote:
>>> Em Thu, May 18, 2023 at 08:50:14AM +0100, James Clark escreveu:
>>>>
>>>> On 17/05/2023 23:57, Ian Rogers wrote:
>>>>> Previously hard coded events/metrics were used, update for the use o=
f
>>>>> the TopdownL1 json metric group=2E
>>>>>
>>>>> Fixes: 94b1a603fca7 ("perf stat: Add TopdownL1 metric as a default i=
f present")
>>>>> Signed-off-by: Ian Rogers <irogers@google=2Ecom>
>>>>> ---
>>>>>  tools/perf/tests/attr/base-stat            |   2 +-
>>>>>  tools/perf/tests/attr/test-stat-default    |  80 ++++++++-----
>>>>>  tools/perf/tests/attr/test-stat-detailed-1 |  95 +++++++++------
>>>>>  tools/perf/tests/attr/test-stat-detailed-2 | 119 +++++++++++-------=
-
>>>>>  tools/perf/tests/attr/test-stat-detailed-3 | 127 ++++++++++++------=
---
>>>>>  5 files changed, 249 insertions(+), 174 deletions(-)
>>>>>
>>>> Reviewed-by: James Clark <james=2Eclark@arm=2Ecom>
>>> Thanks, applied both patches to perf-tools=2E
>>>
>> Could you please hold patch 1 for a while?
>
>Sorry for the noise=2E

That's not noise, I value your reviews, please keep doing them=2E

>Ian has addressed my concerns=2E The patch looks good to me now=2E
>It also fixes a "Failed" on my Cascade Lake machine=2E
>
>Tested-by: Kan Liang <kan=2Eliang@linux=2Eintel=2Ecom>

Thanks !

>But for long term, we probably need a better solution to avoid keeping
>adding such non-architectural events in the test case=2E

Yes, the situation now is different than the one when this test was put in=
 place by Jiri (IIRC)=2E

- Arnaldo