Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0b358a84-511f-f607-336d-9d5b49068972@amd.com>
Date:   Thu, 18 May 2023 19:37:26 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.0
Subject: Re: Need suggestions for smp related properties in cpus.yaml to
 support smpboot for cortex-r52 based platform
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
        geert+renesas@glider.be, magnus.damm@gmail.com,
        konrad.dybcio@linaro.org, andersson@kernel.org,
        mazziesaccount@gmail.com, conor.dooley@microchip.com, j@jannau.net,
        mailingradian@gmail.com, me@iskren.info, lpieralisi@kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        linux-renesas-soc@vger.kernel.org, Julien Grall <julien@xen.org>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Michal Orzel <michal.orzel@amd.com>,
        Michal Simek <michal.simek@xilinx.com>
References: <c5ed90c7-7126-0757-a0e3-e3d1fcab2ecc@amd.com>
 <20230515100810.ctebdbqlienbcf7t@bogus>
From:   Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <20230515100810.ctebdbqlienbcf7t@bogus>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0JTYzZXWGZMWWR4TVE3aS9FcnNiYzJzUTNUOXpOTWVWMjEyNzV5bEZ1ZnRy?=
 =?utf-8?B?M0RGL3dwelJoK25GYmsrSkFWbWVDSmJxcVRCOUVyR09qejVRZTYwM2k0anBI?=
 =?utf-8?B?VmRNK2I4d0NpbGFvNVlCY2JnSDNpVFI0aEdOTzVNYllzLzJrdVdKOUpmZ0tV?=
 =?utf-8?B?Z09zaWxEK24rTDNLT09YcWFDdGt2V2FJbjA3RWkyNy9pcklNQkI4OWZlZ2Z1?=
 =?utf-8?B?T1pYMVFCdmQvMnREZm1qdWZRS0xyQjB3alFsNC95ZjlhMnZkcTQvS1BpUGw4?=
 =?utf-8?B?ZWQ2OXZidnd2RnRZLzJobDAxOUtLaWVBWnprVWxHR3QwRGw1cjFxTEdmQmRk?=
 =?utf-8?B?Mks1QTdYNDc2Q1lsZSt6TndyOHhGRmZMakFmNU9TTGl1R0JCdWpvSjJtNkJu?=
 =?utf-8?B?Zml2VmpxWEpVNHNRUkZCemZ0RHhwQkpnVStmWmFhWElSSWFoL0FYWWcyRUh1?=
 =?utf-8?B?ZGk2aE15aTMrWGIzelhrT2x5ai9ISjRTZUZ6SmZmdFJKRFk1dkROcjVsVzUv?=
 =?utf-8?B?dzBxQWphbXdQYjR3S2tUUjBxc1JiM1AwV2FWck13RCs3UzlzRGlPYTF3S2VB?=
 =?utf-8?B?cSs3cWdBSnl5YjBkRUdvOWhRNFY4SkhlS1BtS3kxd0VVTG5DNitHcHJBK21i?=
 =?utf-8?B?SVdrUy82SFhvSEU2Q2M1YVlzZWhsMXVBejVveEhjTFZPR09GcmZtRVM5TnJV?=
 =?utf-8?B?WHlzVmxEQWF6R080VUNzTHYwV0svbGxrUU43OUR3eitqelB3OGhzczRjSUdM?=
 =?utf-8?B?ZmVON1JUNjZXbG1odlZ3dmVyamJkUElGenE0Vk4yRjl1aUs1STUxL3RlOUJV?=
 =?utf-8?B?Unlpck1mZFFtc0paZ29QTlkxQkZDYUtOUHpQZjhNM2NsUVgySDU3TkVqKzEv?=
 =?utf-8?B?MFlCS2JGMkhjQTRkOUt6MkMyTkp3STRUVnRvcHdaSG9YYzRDNnlUTllTMHpZ?=
 =?utf-8?B?UHZZaUpwZFNZQmtqM3JvbzhMbFZtUmtEb294UWZSSGJtek4zWWc1SlZMcUJm?=
 =?utf-8?B?ajlqUytkL2lWMVB0L3dVYU5GREtPY2lnTkZpSlJlc2hJeXpJSmk3SXJXZ0RY?=
 =?utf-8?B?NWhTTTVEMnpBMlhML1IyRnU0NkJhOXpCclhQNWZWa3hkdmNHc3lXSnRaMjdH?=
 =?utf-8?B?S1RsR0phVnp3YWwwd3hRUnROWm5INitXRUZxZ0RJVWZXdTkxWjZhalN4RGRZ?=
 =?utf-8?B?UVdSZmJjd1FVTUlscFZiZzZETExuZmZCSXl1Rmh4aUJTWXRaMmZKZUZxS1pn?=
 =?utf-8?B?ckN0a2VZVWdYNEh3WGtrcklIbHFxYlppeHBKaG5oWnZzdWp0bHNFOFBCakFM?=
 =?utf-8?B?di9IWkdSMy8vbXh1QzM4aEVqYVNxWnFHZFJuUkVNOTV1R2xHdkE2c0hWWVlU?=
 =?utf-8?B?SDdNTFNCcjd1Nm1MVFRoZndMNWdZSXdYa2ZwQXErT010SGFVTUYxSlRRWmRq?=
 =?utf-8?B?bmordm84Mm5adU5hZzk5Nk82Nk9Uc0VWMlMvVFRFNWlZNjY1MmZHSTQyVU5F?=
 =?utf-8?B?S0hMU213UmhkMHVQTUlPRWh0ODVtbmxyY2NiZFJRVmtISXJDZ2FUOTNQZGg0?=
 =?utf-8?B?WEV2YUd5UUNsSFVEdCtseTVDYm1xY241UklBb04yZTBjQlN2UHBUaytlTFZo?=
 =?utf-8?B?ZVYrUkhoT0orZXgvMEpZTmc2ZndSVlFXbHNGS3E3ZTNLQjk1dXJzSnQ2cG1S?=
 =?utf-8?B?eVBtbm9SZXlXTkphZHNaU0piTmVNQVZPbnZDdEw3UmNsL3FPU1lIN2ZtWDl6?=
 =?utf-8?B?MzVaYmxGVVRJY3V0eTNrUzFPbU01SkgwYTlGWWlUZGpSN0FpMEViTTZmdFlD?=
 =?utf-8?B?aXlHK0diaUZONnRFaGpNK3JMUmpMTGd6L2pEMWI3REdUUVdFK0dJaXl3NXVj?=
 =?utf-8?B?UkZYa2FPTnk0TXFTcXlTNVFSVk1LSHphMkQ3VFViYXhKUktlRzJlY2Zydm8r?=
 =?utf-8?B?aFBPWHRwTUsvMW5ZQ2J4MmtzcjJYRnNNRk5Zb3NGOWRvamc1QVhkdFhtOENN?=
 =?utf-8?B?Y2Z6ZURqbzBEWDczMk9URzdUd0xib3BDUHhZby9uVFVFSmozOHhjYVk5TE1J?=
 =?utf-8?B?V0ZvelcvdlcveXc2dkN2cm9XaVViaHRQWkptODFlUC9rUUJaQTZlbzJTYXlr?=
 =?utf-8?Q?sSOHYEhTTGNEP7Yd7nmJfKdcg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b8a866a-6bfe-4aed-c946-08db57cef29b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 18:37:35.1405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VrOYJy8l73SEZzfI+j4qMNE32ENtcOjks4Fo4ezkgjWAhb9F8/d/XTr5Zf3yZahxW4Dg9FBgHChArXUH5QE5rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4054
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sudeep,

On 15/05/2023 11:08, Sudeep Holla wrote:
> On Thu, May 11, 2023 at 10:35:37AM +0100, Ayan Kumar Halder wrote:
>> Hi Device Tree engineers,
>>
>> Recently I have ported Xen on Cortex-R52 (AArch32-V8R processor) for our AMD
>> platform.
>>
> I remember that there was some exploration on feasibility of using PSCI
> here. What happened to that ? Any summary why that was dropped ?
We are discussing internally with other Xilinx/AMD engineers about this.
>
>> I was discussing with xen-devel community about how we can properly support
>> smpboot when I was suggested that this might be the correct forum for
>> discussion.
>>
>> Please refer
>> https://lists.xenproject.org/archives/html/xen-devel/2023-05/msg00224.html
>> and the follow-ups for context.
>>
>>
>> The way smpboot works on our platform is as follows:-
>>
>> 1. core0 writes to register (say regA) the address of the secondary core
>> initialization routine.
>>
>> 2. core0 writes to another register (say regB) the value "0x1" to put the
>> secondary core in reset mode.
>>
>> 3. core0 writes to regB the value "0x0" to pull the secondary core out of
>> reset mode.
>>
>> regA, regB will differ for core1, core2, core3 and so on.
>>
> Sounds OK but will you ever need to support power management on these cores ?
> If so, just start with PSCI or provide reasons as why it doesn't fit well
> before exploring and extending the existing spin table bindings.

Power management is not in scope.

About PSCI, we are discussing internally.

>
>> Currently, I am trying to bringup core1 only.
>>
>>
>> I am thinking to use "enable-method=spin-table" in the cpu node for core1.
>> So that I can use "cpu-release-address" for regA.
>>
>> For regB, I am thinking of introducing a new property "amd-cpu-reset-addr"
>> in the cpu node.
>>
>> Please let me know your thoughts on this approach. I am also open to any
>> alternative suggestions.
>>
>>
>> Also I see that in https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/devicetree/bindings/arm/cpus.yaml#L87
>> , "arm,cortex-r52" is missing.
>>
> Yes that should be fine IMO.
>
>> Can I submit a patch (a one line change) to add this ?
>>
> Of course, it makes it easy to accept or reject rather than this question
> hidden as part of other discussion.

I have submitted a patch for this.

https://archive.armlinux.org.uk/lurker/message/20230518.152730.c91cc994.en.html

- Ayan

>
> --
> Regards,
> Sudeep