Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <432df3cf-da16-1f2a-02dc-e2c371c1f29c@linux.intel.com>
Date:   Thu, 18 May 2023 23:24:19 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [PATCH - for 6.4] tpm: tpm_tis: Disable interrupts for AEON
 UPX-i11
To:     Jarkko Sakkinen <jarkko@kernel.org>,
        Jerry Snitselaar <jsnitsel@redhat.com>
Cc:     peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
        linux-kernel@vger.kernel.org, l.sanfilippo@kunbus.com
References: <20230517122931.22385-1-peter.ujfalusi@linux.intel.com>
 <ohdpul6hax5bj5hhsnpt7i3ejbttivufmoolzunbhipexjkczi@meg3zx2yqkc7>
 <CSPMQ03V3G7G.EBWKDRE4B0XY@suppilovahvero>
Content-Language: en-US
From:   =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>
In-Reply-To: <CSPMQ03V3G7G.EBWKDRE4B0XY@suppilovahvero>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 18/05/2023 21:53, Jarkko Sakkinen wrote:
> On Thu May 18, 2023 at 9:50 PM EEST, Jerry Snitselaar wrote:
>> On Wed, May 17, 2023 at 03:29:31PM +0300, Peter Ujfalusi wrote:
>>> The interrupts initially works on the device but they will stop arriving
>>> after about 200 interrupts.
>>>
>>> On system reboot/shutdown this will cause a long wait (120000 jiffies).
>>>
>>> The interrupts on this device got enabled by commit
>>> e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
>>>
>>> Prior to this point the interrupts were not enabled on this machine.
>>>
>>> Complements: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
>>> ---
>>> Hi,
>>>
>>> This patch applies on top of mainline since 6.4-rc1 takes about 2 minutes to
>>> reboot on this machine, linux-next have
>>> e7d3e5c4b1dd tpm/tpm_tis: Disable interrupts for more Lenovo devices
>>>
>>> I'm not sure if I shouold send this on top of next or mainline is fine, please
>>> let me know the preferred way to get this to 6.4.
>>>
>>> Regards,
>>> Peter
>>>
>>>  drivers/char/tpm/tpm_tis.c | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
>>> index 7af389806643..aad682c2ab21 100644
>>> --- a/drivers/char/tpm/tpm_tis.c
>>> +++ b/drivers/char/tpm/tpm_tis.c
>>> @@ -122,6 +122,13 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
>>>  			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T490s"),
>>>  		},
>>>  	},
>>> +	{
>>> +		.callback = tpm_tis_disable_irq,
>>> +		.ident = "UPX-TGL",
>>
>> Is this the product version returned by dmidecode? If yes,
>> then the entry could be made more specific by adding a
>> DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"), and only disable
>> for this device instead of any system that matches the vendor
>> AAEON.

The version is used to differentiate the revisions of the UPX-i11
boards, and this issue present in all revisions.

> I can squash this to the commit I pushed (it is not yet mirrored
> to linux-next), if I get the dmidecode info.

System Information
        Manufacturer: AAEON
        Product Name: UPX-TGL01
        Version: V1.0
        Serial Number: Default string
        UUID: a300091d-fb1c-ce1c-1d30-0007328efc11
        Wake-up Type: Power Switch
        SKU Number: Default string
        Family: Default string

I have used this description as it it is used for SOF, probably
DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01")
should be added?

Oh, yes, the product name match should be there, we have TigerLake
specific matching, so SOF is looking for AAEON device with TGL.

Sorry for missing this.

> 
> BR, Jarkko

-- 
Péter