Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Frank Li <Frank.Li@nxp.com>
To:     Peter Chen <peter.chen@kernel.org>,
        Pawel Laszczak <pawell@cadence.com>,
        Roger Quadros <rogerq@kernel.org>,
        Aswath Govindraju <a-govindraju@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org (open list:CADENCE USB3 DRD IP DRIVER),
        linux-kernel@vger.kernel.org (open list)
Cc:     imx@lists.linux.dev
Subject: [PATCH 1/2] usb: cdns3: improve handling of unaligned address case
Date:   Thu, 18 May 2023 16:49:45 -0400
Message-Id: <20230518204947.3770236-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nnyw8wQL9qmFnUP4x9nn+S6yTR8r2EAx4vNU6coEbin7/yAS4KZbis27PvVq?=
 =?us-ascii?Q?H2hXhs1GQGj3R1vlmjuYH6Yc/t6VsmPm4NRrPJ5X/S6aoyiqeNvWqIYVFa2W?=
 =?us-ascii?Q?TK6HmCiMpy/cKP6Tp1/oDUDjdJiV2KhrR1zvzpTWYPcbh+COGGQFthdIB3jq?=
 =?us-ascii?Q?A1R2G1fMgvqwW0ysveBcpAYEiAp1epJk8rnVd4+eY8r5mwlW1Yfca65PFDRa?=
 =?us-ascii?Q?9n6p4W0SK23TQ1ljWDCiGo/farDsP2iYQEhb9tU+4yT4y5MSqQC2vuA5QKOy?=
 =?us-ascii?Q?F9pVqaBOK/sLzVlFHC54F2mA3WsX1BBLL1GfOk/cBX4c5ZGtDnPf/Xks/siK?=
 =?us-ascii?Q?4GhYglXwnJDkKHcn9zNL99/mndruA/vd8PZ1svnU248SRkmz5HHwxrBixs0e?=
 =?us-ascii?Q?8J6RbXpyDJMcA9PA3+5edlTL4VuziLDqsVJmFMela/CKzR/48rPW9w1fsN7p?=
 =?us-ascii?Q?ntBH0q9HyjgPHiADty2pYFAFaIxvTjwCvMAMFm7Ix0pQzLw56qwiii9yv9B9?=
 =?us-ascii?Q?gJ8nHKMhRaY7T3ABUvSSkhfHb0oGeKmimhbzDA3QDRn8tmum89of/lRoujYA?=
 =?us-ascii?Q?DSdddFXkEGNpDR6c/y8dwN8pDSXAj7xaBE6+MVHYzfd9k4680tuY0ePVuEjx?=
 =?us-ascii?Q?zlgl1dr9eoP7mfRIzIO3uWs0EJHkP+thpkwZYaym1Pwc99M5IxcC9Fl3RaMD?=
 =?us-ascii?Q?JztQFCc6g4YEFGwaNv8R6s9GncjCqXx11+p0v6yyQNPEU64xpO1PKSUlxXQI?=
 =?us-ascii?Q?pg5KN0e9LGXT9LBjGAzXuQ2sVQv8k0Vri4kMmJ5KyWFSUIBZZwUr5a6mgvBS?=
 =?us-ascii?Q?/RDvlbz7NNInN2ED/azcjna3ntwhfDkwmq1hPJZeoHYuxrezLkW4mmbXM3uc?=
 =?us-ascii?Q?+ugUSqQMvXq+YQ3VdrYS2aEMdfBpTtKQfaUK4ufUGKfkOyDdMh1eiwYm3A9b?=
 =?us-ascii?Q?8R+VV1plwUWGR08iWeEpfUI2sevLUU+NGim/Un4DZ5duf6YgGFy7mTBSOuHu?=
 =?us-ascii?Q?//kJx+TbWosCqVzNauxgDePqrxi4PqL/cDYnMMg4nOd8QnVhqbY3sqhObzON?=
 =?us-ascii?Q?ehkz5Y3LEsyH/jE1419GfPC1SZB/gMWaqdcf/uusRewHxR5HzznnBCv+Sz59?=
 =?us-ascii?Q?g4ToubQd/N+A8NsBB1N+cl3s4xEtPQ0Rq6GAO2Fh17/eBKbk/xQWOMFm5g0l?=
 =?us-ascii?Q?uGNCBmmlkxC8/9YmEQDgpp6yfltCvHmtEl8g5PrtahDW28epKMlqZrk7lVFu?=
 =?us-ascii?Q?9+dPkhCL3rvAB0yfxwuFXPkhZuF/yQ9/RD3jPIr+EFXX07cq+Cjt8KjKSEYx?=
 =?us-ascii?Q?bNtkvAlSFeBWF1iDS0HJhRqeODamBpiwec4aIU8EvYzJp79f9DxxNDxCWa8q?=
 =?us-ascii?Q?yWPWUqiGEApngNCYYDXiLnE1SzA9sPdv30qjabuQfh4ciCyApVVOzEe+Y8hp?=
 =?us-ascii?Q?D+H0jbgvu0o+F+ooyNZIhqaaORRuoYivINsHqNh3UyRCgbSa81wfgn/50Omk?=
 =?us-ascii?Q?8IPQGkVP3W/PGrLOuJ1jbrF1BZ8V9foPbMVCsx12vhs/vcOq+NRFw0GzkcMh?=
 =?us-ascii?Q?co8kjGjUYpL2QsnmWns=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6752f0cb-9086-4e3f-e0d1-08db57e175c8
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 20:50:05.9938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FR8QLVpBZe8oPmYqBGefso2371eEmw/jzRidje+r52r6NXSch8sGLiMKLEUTTSF8CvDtim+5U/blgKMNfIEsww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8493
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE,T_SPF_PERMERROR
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When the address of a request was not aligned with an 8-byte boundary, the
USB DMA was unable to process it, necessitating the use of an internal
bounce buffer.

In these cases, the request->buf had to be copied to/from this bounce
buffer. However, if this unaligned address scenario arises, it is
unnecessary to perform heavy cache maintenance operations like
usb_gadget_map(unmap)_request_by_dev() on the request->buf, as the DMA
does not utilize it at all. it can be skipped at this case.

iperf3 tests on the rndis case:

Transmit speed (TX): Improved from 299Mbps to 440Mbps
Receive speed (RX): Improved from 290Mbps to 500Mbps

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/usb/cdns3/cdns3-gadget.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
index 1dcadef933e3..09a0882a4e97 100644
--- a/drivers/usb/cdns3/cdns3-gadget.c
+++ b/drivers/usb/cdns3/cdns3-gadget.c
@@ -800,7 +800,8 @@ void cdns3_gadget_giveback(struct cdns3_endpoint *priv_ep,
 	if (request->status == -EINPROGRESS)
 		request->status = status;
 
-	usb_gadget_unmap_request_by_dev(priv_dev->sysdev, request,
+	if (likely(!(priv_req->flags & REQUEST_UNALIGNED)))
+		usb_gadget_unmap_request_by_dev(priv_dev->sysdev, request,
 					priv_ep->dir);
 
 	if ((priv_req->flags & REQUEST_UNALIGNED) &&
@@ -2543,10 +2544,12 @@ static int __cdns3_gadget_ep_queue(struct usb_ep *ep,
 	if (ret < 0)
 		return ret;
 
-	ret = usb_gadget_map_request_by_dev(priv_dev->sysdev, request,
+	if (likely(!(priv_req->flags & REQUEST_UNALIGNED))) {
+		ret = usb_gadget_map_request_by_dev(priv_dev->sysdev, request,
 					    usb_endpoint_dir_in(ep->desc));
-	if (ret)
-		return ret;
+		if (ret)
+			return ret;
+	}
 
 	list_add_tail(&request->list, &priv_ep->deferred_req_list);
 
-- 
2.34.1