Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1670401rwd; Thu, 18 May 2023 15:47:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ62WIU+vl1bxLhjf0vJYwIudhnw802f9Z/mI60DPd7tHISQgNbeEqZBvt66x+G+9QIFyLGR X-Received: by 2002:a17:902:e74f:b0:1ae:f37:c1a8 with SMTP id p15-20020a170902e74f00b001ae0f37c1a8mr770454plf.40.1684450022383; Thu, 18 May 2023 15:47:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684450022; cv=none; d=google.com; s=arc-20160816; b=X83UyXF19la/b3TXQrS9D31JaklTKR+kB0WeZvNc7mWoaMP5a/xeN5kvICvjzR7tFA 1LxfQURgvKn/7FUUD0S5fEkNaY5krW7t4d7pfQuleR9+pvtHsOtGYUNPWNSeugitpITX 1UCz8aYHkAFJPCcqUTSkfRhIHw5TAsTQTfFE1TwUTNh4AtaB53jQi3CZMOFPzqJkwnha LJ+Mv3hFa6cNi4087otDS7zzwd30zraluNPn/AYB14KgFlWsPto5QiKBkOaVPA3c8nXc vFo1wU88tbk9ZrycRliebsl5DLi1zoeSSHqvqOeyohr7Qf59yQhnhw1umrJo81IbIf/G 3Diw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZjH9Yv1APmyAavK/6RwG0/qX85VAXU/953EWt9r0i1w=; b=AaXO0CRQ9Hi1qiLuY2Srq2Z2tmvcsWBQgAaalgzPLk56nNYTouHg46OiFCoCrRwNMe SwMvS5oN1OdqvVlSQ7JDmLUkbmMarVaJOTUbZY3MqI+1WSTslNy9rNAshhN68NXDCoGi clONZVIloBYQ1fWy0MqhslsDxUg6Svndaqld+oThHOSG7rdcdrHC+6dkT0+nYVcm3x9q rVBw/Hk5bqa3TuviFpRm1JN8DTXR3V9yFJ47KCKDdCo76AUhuC9itLO0PXcycQpbzlTM S/xr0HzW1Qn4PQtTY3H+Tx4Xw85iQqCVngegqnIBxAUrtQr9LDa+eeRTYgn7CeEYMlES mJ9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gvGqlzOd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z10-20020a170903018a00b0019ccffb3fd3si2464680plg.509.2023.05.18.15.46.51; Thu, 18 May 2023 15:47:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gvGqlzOd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231124AbjERWk0 (ORCPT + 99 others); Thu, 18 May 2023 18:40:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230417AbjERWkV (ORCPT ); Thu, 18 May 2023 18:40:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A80D1E61; Thu, 18 May 2023 15:40:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3D876652B3; Thu, 18 May 2023 22:40:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E33EC433A0; Thu, 18 May 2023 22:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684449619; bh=pru6AOR5Vm1jRjLusfcHlb0JB0ZcJOquRSj2dOKmD7g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gvGqlzOd1Ed6Aksnz0b7RZ42saJtCqIni0wD7N022+7SqFUL2WJ5+nCSFqE19Fe8M JxhPHeidqqtUOLRzsy15e84LHkHlVga9S3F4s9x0tgA3HI5bOSN4ZawZ8PPnuuaU0C Z8Vo3d3bD7zYiMLX36XnTbTKr0a/q+GLJD2HxAECbKKV3of+nqHTsxgecCJ7vf9UYY 7AiImHhPV1Mf6JrxN16OrL4VFTd7d95wc1cjkChLXcd79xN9T9F5FSJZvQ34WEupKQ NJTbA69wTNwn7qsNNfVR1Tm3drppRIJVwOnibRgou/d5KLAeBwVXeCBIYfH+wcV2Pq KTVEsWfPPaUbA== From: SeongJae Park To: paulmck@kernel.org Cc: SeongJae Park , joel@joelfernandes.org, corbet@lwn.net, rcu@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] Docs/RCU/rculist_nulls: Assign 'obj' before use from the examples Date: Thu, 18 May 2023 22:40:06 +0000 Message-Id: <20230518224008.2468-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230518224008.2468-1-sj@kernel.org> References: <20230518224008.2468-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lookup example code snippets in rculist_nulls.rst are using 'obj' without assignment. Fix the code to assign it properly. Signed-off-by: SeongJae Park --- Documentation/RCU/rculist_nulls.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/RCU/rculist_nulls.rst b/Documentation/RCU/rculist_nulls.rst index 253ecd869fc2..94a8bfe9f560 100644 --- a/Documentation/RCU/rculist_nulls.rst +++ b/Documentation/RCU/rculist_nulls.rst @@ -54,7 +54,7 @@ but a version with an additional memory barrier (smp_rmb()) struct hlist_node *node, *next; for (pos = rcu_dereference((head)->first); pos && ({ next = pos->next; smp_rmb(); prefetch(next); 1; }) && - ({ tpos = hlist_entry(pos, typeof(*tpos), member); 1; }); + ({ obj = hlist_entry(pos, typeof(*obj), member); 1; }); pos = rcu_dereference(next)) if (obj->key == key) return obj; @@ -66,7 +66,7 @@ And note the traditional hlist_for_each_entry_rcu() misses this smp_rmb():: struct hlist_node *node; for (pos = rcu_dereference((head)->first); pos && ({ prefetch(pos->next); 1; }) && - ({ tpos = hlist_entry(pos, typeof(*tpos), member); 1; }); + ({ obj = hlist_entry(pos, typeof(*obj), member); 1; }); pos = rcu_dereference(pos->next)) if (obj->key == key) return obj; -- 2.25.1