Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 May 2023 17:27:30 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Jane Chu <jane.chu@oracle.com>,
        Dave Hansen <dave.hansen@linux.intel.com>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Gregory Price <gregory.price@memverge.com>,
        <nvdimm@lists.linux.dev>, <linux-cxl@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <ira.weiny@intel.com>
Subject: RE: [PATCH] dax: fix missing-prototype warnings
Message-ID: <6466c272e944c_682c129459@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230517125532.931157-1-arnd@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230517125532.931157-1-arnd@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zh5N2nfOrz+ejl3Pr3d89+W5pZfqpF1GwfhHB8274RdZDbtrzrwHJKUndl9H?=
 =?us-ascii?Q?Jmxs/IDEinkUumSYImmMz/pffnfSFM/Sec+kT68lzXy4bKbkGt6qN2TkZVOr?=
 =?us-ascii?Q?JjKbg3zS5kQVD8/OOon2HwqiepbfIwvSgP2qhyIDDeRuidSE8kcrvWt34PZ6?=
 =?us-ascii?Q?dz/rhmNyx5JScM0dIID5fXhbiXOQupO9xeG46VHVi20Q443hjaQ1NAHHLx3v?=
 =?us-ascii?Q?VJcG3CtKFXJ8CP9erFkWNdZngKhePnY7zdnF8egFYsE1012xic3UPSmHcHLH?=
 =?us-ascii?Q?XXoLlqfpopMR1ALPpUnk436l6+0ttV1px1ahcIvHvXNRbqjFSJ/oxhtZtAtT?=
 =?us-ascii?Q?kJa+BNsMlkBJr5m89EF76JHfLVuBBNrczYX4tKa736Y0iUoj4G3JWCrFiCo1?=
 =?us-ascii?Q?GYkoB1cxMdEXOVKOD1VRoNRnRELJzU4xpT8dlABOpSmb7GG6Clpc927dsYXF?=
 =?us-ascii?Q?bluiIdMN+FUTVLLmw5p8JmzNavgSy8o1InjNEyJlNhSDkTIyOGZal1lbgCnH?=
 =?us-ascii?Q?Ty6u6JPx2J/6w6ChW0HVKSwIuA/qSKIcnrC50tViBS6qqfH38nsHH/xvNCrm?=
 =?us-ascii?Q?7FJbFIyvEG0aonC9sEbc9vAtMTFwsiatrYSn8PawtOVg2iQ4Ih1x23QBOwRs?=
 =?us-ascii?Q?JI94DIb1t2xdPw5+h6htFbS5iX1kxIeTTUgQ+xTV0rT3+HfflknFoyWUHINX?=
 =?us-ascii?Q?pWm05S2cbWvnHEJqvFx3tvJLIGqNUkIK3l7pNjkneKILLGVGjcKp0q6d7dGN?=
 =?us-ascii?Q?ISnEX8MUwkl4ldB2ayqegh38C1tnm1EjyTOyLzkHR7QxetiE+eyTGJkKgSLB?=
 =?us-ascii?Q?7CuYLrfJceDyKBCzoBiPjfum4nUsewxPFtQv/EzAQCXjMBuzQQNa303UFnEf?=
 =?us-ascii?Q?ppdyRrGNvBIfBar4vHuZdUnesWN9AKa1fZDiuygaEYpXDO6x2Uh0UqqdMvCk?=
 =?us-ascii?Q?UeX4lu+YQDGhHW19rxBctSgzaAShJv4wc/KIYDjOe7PZv7C/mEi/u/dnH5fw?=
 =?us-ascii?Q?rBaBI0w88Dpu57gORVrziLai+u0ij9UOE6+Xh9QbohTBnCrqHM725OoSmae6?=
 =?us-ascii?Q?+Nz3L3to4C6cnBoAI3jQOuQ/qmfxiytwSiHUd4w5RiBI0GnBvvS5RD5Ps2VL?=
 =?us-ascii?Q?iG6NXXr5Ln1gq7V7o38LTy+l5YkCmvPOYusI73RklZ+Tlm2eV7rtMHhLuAle?=
 =?us-ascii?Q?E0Qbk8JPkAjB19j0Y4JWfuBVRidmnZvASllVYkguUrKGTu81uCZdyThjoAJx?=
 =?us-ascii?Q?kkj5gtSR1nWfHBGzMKyC2X+V0Lj8dORaI6sSWxpOqBq2bKlQxCIftYIJrADe?=
 =?us-ascii?Q?hbI08Y8BHYjcVKc5HkdcQi6UYIlQIc39dOAUfJucc//bsGhV38BjIqJ2FoUU?=
 =?us-ascii?Q?K5xl1gehk5inNRRfyg9CvfcK5jzDLol6x32SXKdLzcrRQ4d1eRK1ObRN5Tkf?=
 =?us-ascii?Q?N/iYrPm25ln9bav9y29jcZ0IhiIgiFQaDETOoeQgVITGmrwE5kreYc8xQQiS?=
 =?us-ascii?Q?ovZ0hFH1lC95U9a+2BNxXOmLqp3fZ5lknDJx+mfqqGtrvXwQ9ryyjg7ldlcA?=
 =?us-ascii?Q?e1lBGGjU2BggcyUVfszEYti2AxL+h3KBLkHHTf5s8QXrpcq9pbkpD/c6SjGY?=
 =?us-ascii?Q?dA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f4360d5-9a7e-4bb9-f681-08db57ffd68e
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 00:27:33.7085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BhK6c6TZEvqPvcqXSS4a3K6wRk9H+NbEXeVsYTdmz9u3Q9DmcC///0uNVDGyrQaQCfZRYW3S11Q+UvSSgySPFgzMEA+iHbOaMEcB0LDpxvg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4694
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> dev_dax_probe declaration for this function was removed with the only
> caller outside of device.c. Mark it static to avoid a W=1
> warning:
> drivers/dax/device.c:399:5: error: no previous prototype for 'dev_dax_probe'
> 
> Similarly, run_dax() causes a warning, but this one is because the
> declaration needs to be included:
> 
> drivers/dax/super.c:337:6: error: no previous prototype for 'run_dax'
> 
> Fixes: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---
>  drivers/dax/device.c | 3 +--
>  drivers/dax/super.c  | 1 +
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dax/device.c b/drivers/dax/device.c
> index af9930c03c9c..30665a3ff6ea 100644
> --- a/drivers/dax/device.c
> +++ b/drivers/dax/device.c
> @@ -396,7 +396,7 @@ static void dev_dax_kill(void *dev_dax)
>  	kill_dev_dax(dev_dax);
>  }
>  
> -int dev_dax_probe(struct dev_dax *dev_dax)
> +static int dev_dax_probe(struct dev_dax *dev_dax)
>  {
>  	struct dax_device *dax_dev = dev_dax->dax_dev;
>  	struct device *dev = &dev_dax->dev;
> @@ -471,7 +471,6 @@ int dev_dax_probe(struct dev_dax *dev_dax)
>  	run_dax(dax_dev);
>  	return devm_add_action_or_reset(dev, dev_dax_kill, dev_dax);
>  }
> -EXPORT_SYMBOL_GPL(dev_dax_probe);
>  
>  static struct dax_device_driver device_dax_driver = {
>  	.probe = dev_dax_probe,

This hunk looks good.

> diff --git a/drivers/dax/super.c b/drivers/dax/super.c
> index c4c4728a36e4..8c05dae19bfe 100644
> --- a/drivers/dax/super.c
> +++ b/drivers/dax/super.c
> @@ -14,6 +14,7 @@
>  #include <linux/dax.h>
>  #include <linux/fs.h>
>  #include "dax-private.h"
> +#include "bus.h"

This one came up before, and IIRC last time I said lets just move the run_dax()
prototype to dax-private.h.

https://lore.kernel.org/all/YiqF1a9VNiSWI5j0@iweiny-desk3

I can fix that up when applying.