Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230518230626.404068-1-aford173@gmail.com> <CAOMZO5DBefFuLWi39txu2RiU5vdHVx-0T48Fua6M5Y6Fr9PGNg@mail.gmail.com>
In-Reply-To: <CAOMZO5DBefFuLWi39txu2RiU5vdHVx-0T48Fua6M5Y6Fr9PGNg@mail.gmail.com>
From:   Adam Ford <aford173@gmail.com>
Date:   Thu, 18 May 2023 20:34:29 -0500
Message-ID: <CAHCN7xLqmMPtnHTVbApyYxY2tx97oRjsk_51abdDcZkOJmA=Tw@mail.gmail.com>
Subject: Re: [PATCH V7 0/6] drm: bridge: samsung-dsim: Support variable clocking
To:     Fabio Estevam <festevam@gmail.com>
Cc:     dri-devel@lists.freedesktop.org,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Jonas Karlman <jonas@kwiboo.se>, aford@beaconembedded.com,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-kernel@vger.kernel.org,
        Jagan Teki <jagan@amarulasolutions.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Inki Dae <inki.dae@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 18, 2023 at 7:29=E2=80=AFPM Fabio Estevam <festevam@gmail.com> =
wrote:
>
> Hi Adam,
>
> On Thu, May 18, 2023 at 8:06=E2=80=AFPM Adam Ford <aford173@gmail.com> wr=
ote:
> >
> > This series fixes the blanking pack size and the PMS calculation.  It t=
hen
> > adds support to allows the DSIM to dynamically DPHY clocks, and support
> > non-burst mode while allowing the removal of the hard-coded clock value=
s
> > for the PLL for imx8m mini/nano/plus, and it allows the removal of the
> > burst-clock device tree entry when burst-mode isn't supported by connec=
ted
> > devices like an HDMI brige.  In that event, the HS clock is set to the
> > value requested by the bridge chip.
> >
> > This has been tested on both an i.MX8M Nano and i.MX8M Plus, and should
> > work on i.MX8M Mini as well. Marek Szyprowski has tested it on various
> > Exynos boards.
> >
> > Adam Ford (5):
> >   drm: bridge: samsung-dsim: Fix PMS Calculator on imx8m[mnp]
> >   drm: bridge: samsung-dsim: Fetch pll-clock-frequency automatically
> >   drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY
> >   drm: bridge: samsung-dsim: Dynamically configure DPHY timing
> >   drm: bridge: samsung-dsim: Support non-burst mode
> >
> > Lucas Stach (1):
> >   drm: bridge: samsung-dsim: fix blanking packet size calculation
> >
> >  drivers/gpu/drm/bridge/Kconfig        |   1 +
> >  drivers/gpu/drm/bridge/samsung-dsim.c | 142 +++++++++++++++++++++-----
> >  include/drm/bridge/samsung-dsim.h     |   4 +
> >  3 files changed, 124 insertions(+), 23 deletions(-)
> >
> > V7:  Move messages indicating the optional device tree items are going
> >      to be automatically read elsewhere was move to dev_dbg instead of
> >      dev_info.  Cleaned up some of the comments to be a bit more clear.
> >      Eliminated a double variable assignement accidentally introduced
> >      in V6 when some of the items were moved from patch 6 to patch 5.
>
> It seems you missed addressing one previous comment from Lucas:
>
> "Same as with the earlier patch, this needs to be documented in the DT
> binding by moving "samsung,burst-clock-frequency" to be a optional
> property."

Aargh!
I can't believe I did that.

Inki,

Can I do a single patch to which references this one and have you
apply them together when the time is right, or do you want me to
resend the whole series with an additional patch at the end making the
two device tree items optional?
I totally forgot, and I'm sorry.

adam

A