Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Chaitanya Kulkarni <chaitanyak@nvidia.com>
CC:     Daniel Wagner <dwagner@suse.de>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
        Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH blktests v4 09/11] nvme{045,047}: Calculate IO size for
 random fio jobs
Thread-Topic: [PATCH blktests v4 09/11] nvme{045,047}: Calculate IO size for
 random fio jobs
Thread-Index: AQHZifJME1vyQKMTO0m9RnQtffwKQg==
Date:   Fri, 19 May 2023 01:36:17 +0000
Message-ID: <5duh22ydzwth2z2sd4oo22cuaqlazxq3u5m7vo5qfkp4fgec7w@elzdr6vbksgv>
References: <20230511140953.17609-1-dwagner@suse.de>
 <20230511140953.17609-10-dwagner@suse.de>
 <c5c2af7c-2b63-f30d-f568-c136dd6f6c5c@nvidia.com>
In-Reply-To: <c5c2af7c-2b63-f30d-f568-c136dd6f6c5c@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cuvy+PAvKwwuHxRni13WnSWvodY4PGEQPRZ7uvRYqY/PWXIO9LxS/kcD5+gm?=
 =?us-ascii?Q?HjHTO2CEfiYaQ1RUXGqPT5KE8M191TAtvOdJ1Yx7MjAFtQWXVE+OGG4aaUTm?=
 =?us-ascii?Q?/GP+b5I+LI8eSzkurDx56skFj6Imj+SJiWd0iJ3UFUkwyID2I89gj8fJbb5v?=
 =?us-ascii?Q?4qeZE9vC3UeRkydBTc5kt/AQLJzex0pLpBvqLFjiHRepm1q7Zbb3m7hgyDWL?=
 =?us-ascii?Q?g5eDloHapCkg8dK9K/SmbhjiuS7/xvswcc75xoeA1m7byGoRfa3pFvt8hRed?=
 =?us-ascii?Q?d6xRdkuCCNIx1vZ3ibLCQw4/VcuL3JOn/pzwHP/axtwgw4PnDzuS6TuzSRou?=
 =?us-ascii?Q?9FJ9t+rdH9CsKYsIF4spSlLt78iABQu4D6xKFmV6n91gI2N1d7RQjZbLrwYz?=
 =?us-ascii?Q?KuVmGOMBx/t6+xlJXsxFuGc2jLBLh4OSfRwMgfNi8RPCnVKcq4KHeA3uEUpo?=
 =?us-ascii?Q?Hb3PRknmr/fOz85YLxwQJCaeFDiouaTlSexrKisKsw0fnzmmRTNfD6G+9d9I?=
 =?us-ascii?Q?EBUuoQtg9yo+0TtV9s6V2h4hSLacLzNq95LZLNBNuIpr3P4+uTWI/q3XDeJ2?=
 =?us-ascii?Q?lMD4ZX/V854gyTNuXbBaO1DkNE/DOUfD4YuBAhLM440GndCuSjo2Fwg4khk3?=
 =?us-ascii?Q?XnuL/aUErnEEtEFqQUtDiMxylPr63Bdu2lFQ03jRXLe7jbzBan44J+4xyJ6j?=
 =?us-ascii?Q?tTsIhsny8jKkCky/wBoM0E8Bn+MpKEHLgLhPi9Jg7oLqcH2TI1WLTru7ZN+u?=
 =?us-ascii?Q?YbcySi8FIlJq3/qDmeQsTcLkuq+3419ffhDVJmXJWDFIi7fs2Y3Owo0ozmRF?=
 =?us-ascii?Q?T3VT41aOQALEpzLEgDEA7EYxR8EeWKH0knNFd3MMoGXOjg/ljvZNm99Gyg1h?=
 =?us-ascii?Q?IJ/lEWCspp0+PAIuP+ndlcoyRxZ+zUFRi+bqC4xL7bAwvcCBj0Q5t3hmeSpt?=
 =?us-ascii?Q?eYg1vpbwHGPFUns89bCE8YFfeu4ecQ0q6rq+ygUkXYDFeEwKXcknr2v0yyjX?=
 =?us-ascii?Q?tsLC3TtVjgHw6t/CS4dTtRzcgO9p/ZwoC6gisKl2mbL3J6g+F9iCbMoEXZz1?=
 =?us-ascii?Q?/0GtXXi+Uh7TfkvhBFU6BnRn/oK+q7LyOtygWxBJfniNw6zhi9NARHN0D5K2?=
 =?us-ascii?Q?0SreraKlNlrIciXH7//wpnKu7K7ViE0SuGWVGveELUZeWNkMFmyaHs113FWT?=
 =?us-ascii?Q?qnDOLeNNiZ8bRbD3jplj/XAbUpcHCYcHqXN0TijDGwIkZ6Lpczlk4A7v4gVD?=
 =?us-ascii?Q?1bbUkONwUsG5KA39wIvF0Y2qmk7+zrmNR/YSrae6aW0l7lJ1Pg+UCids+NcP?=
 =?us-ascii?Q?0+1RgzQV5LQ7ocYPGoEssBAONf/4HERA+2xkO8Q7aTEWo9oaSusMYSKtvxQi?=
 =?us-ascii?Q?ysypfCdio8lQUwjHwoTfQKhkFuLp/kVwi6O9+X60T3wT/zEOjQk5W+u+aY0G?=
 =?us-ascii?Q?2Ul6bU86AmrebMwIY9TCuXHitxIBG4m4fzlIf6xK5AeLUMjKLjK1WU1MCkqe?=
 =?us-ascii?Q?KNmSJDkNKatDPKkNSd+mmUZYW8EJ4wQSRMFx1yAvje9rrZa6FwnlbSQxhfZP?=
 =?us-ascii?Q?COVilz/tCp5sRPr2JdsNhoff1y/kQ0dzvWOMlg0ZOgYAyTyzzaWI+gJYjWf/?=
 =?us-ascii?Q?IO0d4prQOCyC0tdr4yUu8K0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F0DFA4A43ACE9048804FE2612BC912E4@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hnZKrtTi4Zs2tCRfVb6KJHthy5oqbIb3wMgCKt3J2CYiPLE4FkulCGD3RcsPy7wKNB2DEzPT+NzYykt8a497RUf3EkZO8lFL1fyXuFWmmzSmg9xzsyJ03EvLqjKGNeBpdHqRjijRp9cP1L6i97OQ0ACNyEIczzxy9DXcEjEShiC43Zm3BEdu7YBU/bWgWcSCrgC6l3l11bdB0egJyWf0q4apQbSYWLJljuhntbgIt9GvaNn5N+zkNDO3Ckz7zeh1xzcnUZqexeYv5jL022WNVPcIGyaLhpbprOQvkuc/iz/zlsyo7k6MlZ4LhOJuQgTQr8gp2oy+Im3tWJykEviSOQlknUo9NU3fjadN3pw6/z/1oQLmMVWZRTjLxLh0jjMfTpE5cuLm0udnrhrt3b8CSKdrXuI+hl9kVJLKWuGu6bfHaUAYldAzDj37T5gz1w6dyc2FhqzwL6JsW1NKLWmx9PpO7ISA/eB9uj5DSmXHyKAptvfhyU0bin9sArSalqz4Gg2n5xxB3AyHVD+xY2n1QZeXaoHf+HS90jqKmS0jg5zYdI+dOtleXJDBm7RWKlgpZUl4NnWTG4vAphI1akkm/RYI2ORQXzXqIcb4KWIK/dZ1/Iq+o/6dCzrUzgEzGdgvO7795a14gGqB1VGVkQWjScRcwlSiZg/YZpO6XpbumZ60DXO+oxhqWCq8W1+T7NjCj+fYGFYthjR7ZYyvi2P3Kzm7iE1TYcwhZMBo2qqzuJ4QCgnzKCM0D177/RWmsimRXJaRckFwakyjkzNU6O798uxEyN5KOnBY+YlHBvIFAz0hkDZeaaRYFDXINEmiYlW7KYWTBflvPlLrpUu0sMKivY5EsS6uiR1wPCp8ZNlKV15PYcR97iggquXnGkkdvmQWkvk4SrbxOk/Yk49H0WwJmSHXSsfrtAsx//EkWRydW2o=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b92cab8a-cd5c-4fd8-de56-08db580970b1
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2023 01:36:17.1647
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2N/EVFPtFGFl6qi0Nh9+K8AGkouwRCC6oGhTpoD6rZ548ODtUE8i+PIr1L3a6U5hgzhTfjTA39MChMt4uIbxcyN+5Kj25sDCq/QiAnZuFro=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6715
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On May 17, 2023 / 04:44, Chaitanya Kulkarni wrote:
> On 5/11/23 07:09, Daniel Wagner wrote:
> > _nvme_calc_run_io_size() returns the jobs size for _run_fio_rand_io()
> > function. The jobs size is the size per job, thus we have to divide
> > through the number of CPUs.
>=20
> sorry I didn't understand why we have to divide through number of
> CPUs ? isn't tht will change the current job size of the test ?
>=20
> unless we are increasing somewhere which I missed it .

This change reduces the I/O size per job, but it keeps the total I/O size
regardless of the number of CPUs. This will keep test case runtime reasonab=
le
on systems with hundreds of CPUs.

As for the test case nvme/045, it tests re-authentication. I don't think it
requires total I/O size proportional to number of CPUs. As for the test cas=
e
nvme/047, it exercises different queue types (write queue and poll queue). =
Does
it require total I/O size proportional to number of CPUs? Daniel is the tes=
t
case author, and I guessed he is ok with the change.=