Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 May 2023 21:46:21 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Vladislav Efanov <VEfanov@ispras.ru>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Rene Herman <rene.herman@keyaccess.nl>,
        linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] isa: Remove unnecessary checks
Message-ID: <ZGbU7YQgzGelwiGy@fedora>
References: <20230517125025.434005-1-VEfanov@ispras.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4EKlEO7L5rYoZBuz"
Content-Disposition: inline
In-Reply-To: <20230517125025.434005-1-VEfanov@ispras.ru>
Precedence: bulk


--4EKlEO7L5rYoZBuz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 17, 2023 at 03:50:25PM +0300, Vladislav Efanov wrote:
> The isa_dev->dev.platform_data is initialized with incoming
> parameter isa_driver. After it isa_dev->dev.platform_data is
> checked for NULL, but incoming parameter isa_driver is not
> NULL since it is dereferenced many times before this check.
>=20
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>=20
> Fixes: a5117ba7da37 ("[PATCH] Driver model: add ISA bus")
> Signed-off-by: Vladislav Efanov <VEfanov@ispras.ru>

I don't think the Fixes line is needed because this is removing a
superfluous check rather than fixing a bug. Regardless, here's my Ack
for Greg as the patch itself makes sense.

Acked-by: William Breathitt Gray <william.gray@linaro.org>

> ---
>  drivers/base/isa.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/base/isa.c b/drivers/base/isa.c
> index 55e3ee2da98f..675ad3139224 100644
> --- a/drivers/base/isa.c
> +++ b/drivers/base/isa.c
> @@ -149,11 +149,8 @@ int isa_register_driver(struct isa_driver *isa_drive=
r, unsigned int ndev)
>  			break;
>  		}
> =20
> -		if (isa_dev->dev.platform_data) {
> -			isa_dev->next =3D isa_driver->devices;
> -			isa_driver->devices =3D &isa_dev->dev;
> -		} else
> -			device_unregister(&isa_dev->dev);
> +		isa_dev->next =3D isa_driver->devices;
> +		isa_driver->devices =3D &isa_dev->dev;
>  	}
> =20
>  	if (!error && !isa_driver->devices)
> --=20
> 2.34.1
>=20

--4EKlEO7L5rYoZBuz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZGbU7QAKCRC1SFbKvhIj
Ky5IAQCiRVaj1Srg0+u3ajag42dujk+UQQsqAb8BYYJven/kHgEA7+pycPHYjXw5
xwWzhVadqLfbQJpdO29ogoYxQUtbnQ4=
=kz4u
-----END PGP SIGNATURE-----

--4EKlEO7L5rYoZBuz--