Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754878AbXJHMdr (ORCPT ); Mon, 8 Oct 2007 08:33:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753442AbXJHMdi (ORCPT ); Mon, 8 Oct 2007 08:33:38 -0400 Received: from general-networks3.cust.sloane.cz ([88.146.176.14]:47062 "EHLO server.generalnetworks.cz" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753870AbXJHMdh (ORCPT ); Mon, 8 Oct 2007 08:33:37 -0400 Message-id: <21044149499772302@pripojeni.net> Subject: [PATCH 1/3] V4L: w9968cf, remove bad usage of ERESTARTSYS From: Jiri Slaby To: Andrew Morton Cc: Cc: Cc: Cc: Date: Mon, 8 Oct 2007 08:33:37 -0400 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 35 w9968cf, remove bad usage of ERESTARTSYS down_read_trylock can't be interrupted and so ERESTARTSYS would reach userspace, which is not permitted. Change it to EAGAIN Signed-off-by: Jiri Slaby --- commit db38c559d37219c32b179ae005ca7e489336ec94 tree f2d606165e6ef2daa6e1a2860f87521222eeecd2 parent 6e42c2183befe136d85e6a8708ee4eabc543774b author Jiri Slaby Mon, 08 Oct 2007 14:14:03 +0200 committer Jiri Slaby Mon, 08 Oct 2007 14:14:03 +0200 drivers/media/video/w9968cf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/w9968cf.c b/drivers/media/video/w9968cf.c index 77599f2..5a1b5f5 100644 --- a/drivers/media/video/w9968cf.c +++ b/drivers/media/video/w9968cf.c @@ -2679,7 +2679,7 @@ static int w9968cf_open(struct inode* inode, struct file* filp) /* This the only safe way to prevent race conditions with disconnect */ if (!down_read_trylock(&w9968cf_disconnect)) - return -ERESTARTSYS; + return -EAGAIN; cam = (struct w9968cf_device*)video_get_drvdata(video_devdata(filp)); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/