Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 09:35:27 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     wei.fang@nxp.com
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, Frank.Li@freescale.com, shenwei.wang@nxp.com,
        xiaoning.wang@nxp.com, netdev@vger.kernel.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 net-next] net: fec: remove useless fec_enet_reset_skb()
Message-ID: <ZGcmv8LKS9ayAHRI@corigine.com>
References: <20230519020113.1670786-1-wei.fang@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230519020113.1670786-1-wei.fang@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pmRHwI6jhi9rxiKNXcMW0NU7SHyMAw9OE8CAeOhNV4ZGBKt7B3at6gw1WXkF?=
 =?us-ascii?Q?XWX7/mNXVF34AkYxp0uqQliQ/9w/Or5KXsZ7LFGD9+hz4syA9bmrsW07QWRV?=
 =?us-ascii?Q?aRKFcjRgvckcO3jEuCmd4OuerHW9jfFizIfK/IZE4agcHu3QdABM3KMeEu1d?=
 =?us-ascii?Q?mZ3wJmBGtfW9w1h2WRZCMBavJD7FCBzLJik2f6dZIfmwScY+BRHM9LSJTymN?=
 =?us-ascii?Q?WmrrsMoR6xKDHfyetZ4uKEzm2m3GuJfMqQpmuViS/Q4XTcODp1yWFAGOZWCF?=
 =?us-ascii?Q?8RUI5n3s+GAsxYXsD/I/c4N8Omf2HB/HTp83dKFAwhWxsd40o5RbAvlXh0Jb?=
 =?us-ascii?Q?6COjucOF66G5m17p0cQTFW8eA5V8Oa+ruue/nokvyIY9ejUurX6Xp90K45Tk?=
 =?us-ascii?Q?nLTpy+CD+fH6vgazCramGisyN6QjtiVHPUJlBIb6VDzu1YlDPJjtpwurjePC?=
 =?us-ascii?Q?jKfShBCsolcxSJLFNHUJmbhaGcBqC6ezJLVZ18rCfXWoION8B0Uy6McD0MBU?=
 =?us-ascii?Q?euGocbxDq2GAnQT9p1EQQUE5jCMjGcjfVKlFziptH+WibwYq1lf0W0LY1/P2?=
 =?us-ascii?Q?DI4qJUtakTbJVGgrcz7AmeSCqapVZfydq23BXxSn+ZcPTuHEufAEdpRQKhoz?=
 =?us-ascii?Q?vpxHpVEZXVDCq4yqz5FZjR/py/DTOvsCw67n7EnYz9eFNcOOvfRKe97Ul8tH?=
 =?us-ascii?Q?SDYVskUtufmJ8PvvhyHOvr14k+7i+9OknYroLOLvzPgZ+yX97uNTDpbDAJls?=
 =?us-ascii?Q?2IqcnfjQdJkBpqq6kICt5Qo2kofGolsX4n64iVIed5wm0vFQiY/Frurthlyq?=
 =?us-ascii?Q?La/67rg5Sow3WqsZzwvRSQ2hqfqCSc0jwNT6nUZXsuUJyhM6Cw5XAc6tKCJm?=
 =?us-ascii?Q?lpqUq8z3arMhUQeYGv26TYO/ZysRO4d1OrSxMJY7EnDujSDsj4dazCRxL2qj?=
 =?us-ascii?Q?v6hTEM+r+1fdYN1Gjm9v3WqWxf8adX+FuBMU09D1qKbbC5IigK5ddCT33dxW?=
 =?us-ascii?Q?IX4slZQ0wJ1Lb3yWaDjpMypifzQDw2RB7kG9nbmEDIfhoVYyUWgm2ScjxZG7?=
 =?us-ascii?Q?N58NGK4+pic0w10f+EixoYwXeKbFErAbbExp40dIP6VFbrxtZ2m+hZy3D/+g?=
 =?us-ascii?Q?Hw7yCDdEJzM62V2iARQq/QihwU/w8O8LTZqhxV2CNMBRu+O5/1q3V8crKoP5?=
 =?us-ascii?Q?jY4I97IDrA36nY5PZtITWfwA7RvrnpSyLvUbwmotrQZPLVJrXnux8M+scdR7?=
 =?us-ascii?Q?rHfQnC0E39Y+p35uZqpMhLIOyh7fnTMSPAI2l6yXmGvlCE+zgKOndglimF4A?=
 =?us-ascii?Q?TanA74oY1jC0f+JBMRq/VNh+wL5v0NDm2dek6AZ+RR1k6DbjfDMRx9FJK0WG?=
 =?us-ascii?Q?Ubk+5ozDFwLXYFalXxDpwlIvlMLh13ha+u4nKtwmyAlG+ADqQc1LFFPoxzmF?=
 =?us-ascii?Q?t9yd/LHk+mTgU/c/iHKaiQRIAwMo6Yu2FhfIsnUupczy2SrTOBoBeFaIY3DM?=
 =?us-ascii?Q?vvr1BGNkTKIlIluPuTTKysK2znRWHrFt4gX58nitysyLez+BYV2Ov3TkM7Ze?=
 =?us-ascii?Q?d7AHZcGkr3D8AqRp4fRmKq8d6NL6o+KDYVne9I5MYIs8jxLH/WDWc6q8cLSb?=
 =?us-ascii?Q?KHaqIqqeTn/US6dWJPwrNf+5D8VtIcFhcZ63KMjY8PGnQrllHQPELyOEWMR2?=
 =?us-ascii?Q?EJop9Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98a59b5f-b0ab-4bb5-5470-08db583ba235
X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4834.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 07:35:49.6694
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hjA5Wuvj6lyTilf8p0Jfy7303MKdxldiMd4r1ynjjuPXPU+V7jtxMxCH1sTtoKh8pVpeKslP3qRzIrZsbhoH2x80+jKGdbnsZmUhAeF/yos=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3779
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 19, 2023 at 10:01:13AM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
> 
> This patch is a cleanup for fec driver. The fec_enet_reset_skb()
> is used to free skb buffers for tx queues and is only invoked in
> fec_restart(). However, fec_enet_bd_init() also resets skb buffers
> and is invoked in fec_restart() too. So fec_enet_reset_skb() is
> redundant and useless.
> 
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> V2 change:
> According to Simon Horman's suggestion, it's just a cleanup and without
> user-visible problem, so change the target tree from net to net-next.

Thanks Wei Fang, looks good.

Reviewed-by: Simon Horman <simon.horman@corigine.com>