Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 11:01:07 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Andrew Lunn <andrew@lunn.ch>,
        Eric Dumazet <edumazet@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        Arun Ramadoss <arun.ramadoss@microchip.com>,
        "Russell King (Oracle)" <linux@armlinux.org.uk>,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v3 1/2] net: dsa: microchip: ksz8: Make flow
 control, speed, and duplex on CPU port configurable
Message-ID: <ZGc603g8Pjp4Umke@corigine.com>
References: <20230518092913.977705-1-o.rempel@pengutronix.de>
 <20230518092913.977705-2-o.rempel@pengutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230518092913.977705-2-o.rempel@pengutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bnaslNdFfxDprebzc/Qc7cy6tcT600XZP4Qqm2k8p9m1Hub05wK55/Dlb3Rn?=
 =?us-ascii?Q?IywLGlHSOrvoJZYasq9S6SrzK/ZZTcc1hUdztte1boY/+jdlF/Ghq8FaJ4+Q?=
 =?us-ascii?Q?j4JDbBT3AqriqDF/fynCR7PHYXmpdPT5C93brbfQnV7DMxDg8RI61r0OQx+7?=
 =?us-ascii?Q?DIYfe0hYer/bcWmKZCtIGsA+RNLn57Zsia7EBCyCAtfnJ6s7JaELUrjzYE2b?=
 =?us-ascii?Q?UsZaRMSo5TQ2dK88whtXq+E8uufCY2iBPxdRRTmAv5OhlOMWu9G6ZmEoRWeQ?=
 =?us-ascii?Q?M0tBwEYBgK0PEJT3wJPfFiAe9KfVlSPlmmhKwJjA2LVxD0WaEX0JhueJLf7l?=
 =?us-ascii?Q?cGdyISCYRBDFgOzxVEpoQ+9ZXh6rHIMx54FJKo9HUG0C2/7MYQEevNy4BoAF?=
 =?us-ascii?Q?8O4UUHbpVVFsss6YYOmk37cA497xbI0MJretKJHfF6V63Hv+eEnnXpXB98Pb?=
 =?us-ascii?Q?6kfcLFmbM7FxApPvQpcKUxmeFurB0tDHZFBeQ8/u+vmolbJp2oUVx5LVPwHK?=
 =?us-ascii?Q?bFkx8Shc6Eaw7NLhv7dsOBuhfqWOiTREnXNrO0e12JGl30sQ8UcVxLdoFiEe?=
 =?us-ascii?Q?jfY0Du0ECeLxviuU4P9PUsle52xtbbJz947J2MWvULkbZr/S0Fg/J0APj+ST?=
 =?us-ascii?Q?FzVnqGws4Trf4iNLb7roa5q1NVIbk61fayUlIu28Zu63GZYo46gLGhoTYHzf?=
 =?us-ascii?Q?9Qo0DmrongXG2mxlOdvK+UuJaMdqEgethQ1dTEfZX9L/a+ECUXnvlW/M7WlJ?=
 =?us-ascii?Q?RktwHpwmN2WtzxomuM+Ef8jW2eKnI7YgHus0bHM61Bq6n6O2XQyQrPBslE0y?=
 =?us-ascii?Q?y/0a6+nU3IRa+eYZ3xbkD6Y/F5h4MZ0nTGjWLRX1y+DIJ9QQi83QvGu8RZK9?=
 =?us-ascii?Q?bXaf4DsZIQhFSLQni3j9f6etD+zX/ke3zNjgemIwsauPKwys9QqWqdS8DgsH?=
 =?us-ascii?Q?8fj5uhGTvn/KomFgGSh5cO9k4v3bwMzMfNEKyyf5SHI26eIBU1r110X/RxXd?=
 =?us-ascii?Q?qxiyWhVXNS2/J5BdvQbYxg/9j7YfMaVwu84Q+Z7awxQUgR7Bo2Qhhq8JarnZ?=
 =?us-ascii?Q?Dw9zjSWIeuxaqh+4MpQ4Et88rTNitBfZ4FCOXuDGY4wsl+HWc/5v2GCNhIvm?=
 =?us-ascii?Q?8OCsI1cQGjCabBx7HYJytSB7MgKyGppkgNl5ihO4O4HoUpamtdwJDuFQvb5v?=
 =?us-ascii?Q?ju9A8+5me1YsZwaQ6hTmD91/oaJi2uVnqKWz8kcc/bG4LmjiJBdN8I7tjnj2?=
 =?us-ascii?Q?eICcM0t0jFsWy92kym1R6py9rIw44QDkGgHY8MRS/9Q/xewUa3TXPSVnrb1w?=
 =?us-ascii?Q?gd4NOurfJHPMH9DdIEwQx6BjvqSckWgfADgVS2me/eBMk5r1efHdeIZ91ENY?=
 =?us-ascii?Q?2a5gm4ma1LxaKyWHMRknPVa3kqcf2DrUZYsPBauOL9tyq2PY6I83+ts2vSqC?=
 =?us-ascii?Q?O2p9kVB9/R0Juqe0VPgySStZsGJCqiYniQGhCkNsKURWZpbA8OqKCavocjB5?=
 =?us-ascii?Q?zvKRsRzoZkjeeOeKGjSKVIHCKXagLfesr2Fxmz/M4Kv97pC09jvTreuRUGKg?=
 =?us-ascii?Q?/fmpJNADWJFr3vnSo1H3E2Ut6KwV08byT1jrlS4GPlTzOvZ7Zpl4x7u/VH+a?=
 =?us-ascii?Q?H+BKVr9R+61PY9zVWv1TuhZfDhsyJpbE7o/vfEdjxNKNmB9RAUMbQAaHbEJb?=
 =?us-ascii?Q?30rTcg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3aa84249-89f7-43e6-b71a-08db5847993a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 09:01:15.1876
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IFbRGvRcZbsMMeWN4F0vm5t0mEkCflhH7zkz90TZemPNLKxd4K8KAC4/1EeYpJ/aDIN+JUuyOb6RudvY2S4Kw/7juJJ8wtvDowYQe4co40U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB5169
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 18, 2023 at 11:29:12AM +0200, Oleksij Rempel wrote:
> Allow flow control, speed, and duplex settings on the CPU port to be
> configurable. Previously, the speed and duplex relied on default switch
> values, which limited flexibility. Additionally, flow control was
> hardcoded and only functional in duplex mode. This update enhances the
> configurability of these parameters.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

...

> diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c
> index f56fca1b1a22..9cfe343d2214 100644
> --- a/drivers/net/dsa/microchip/ksz8795.c
> +++ b/drivers/net/dsa/microchip/ksz8795.c
> @@ -1371,6 +1371,55 @@ void ksz8_config_cpu_port(struct dsa_switch *ds)
>  	}
>  }
>  
> +/**
> + * ksz8_upstream_link_up - Configures the CPU/upstream port of the switch.
> + * @dev: The KSZ device instance.
> + * @port: The port number to configure.
> + * @speed: The desired link speed.
> + * @duplex: The desired duplex mode.
> + * @tx_pause: If true, enables transmit pause.
> + * @rx_pause: If true, enables receive pause.
> + *
> + * Description:
> + * The function configures flow control and speed settings for the CPU/upstream
> + * port of the switch based on the desired settings, current duplex mode, and
> + * speed.
> + */
> +static void ksz8_upstream_link_up(struct ksz_device *dev, int port, int speed,
+				 int duplex, bool tx_pause, bool rx_pause)

nit: there seems to be an off-by-one error in the indentation of the line
     above.

...