Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <c1fd63b9-42ea-fa83-ecb1-9af715e37ffa@redhat.com>
References: <c1fd63b9-42ea-fa83-ecb1-9af715e37ffa@redhat.com> <20230519074047.1739879-1-dhowells@redhat.com> <20230519074047.1739879-14-dhowells@redhat.com>
To:     Xiubo Li <xiubli@redhat.com>
Cc:     dhowells@redhat.com, Jens Axboe <axboe@kernel.dk>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
        Jeff Layton <jlayton@kernel.org>,
        David Hildenbrand <david@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Hillf Danton <hdanton@sina.com>,
        Christian Brauner <brauner@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Christoph Hellwig <hch@lst.de>,
        Ilya Dryomov <idryomov@gmail.com>, ceph-devel@vger.kernel.org
Subject: Re: [PATCH v20 13/32] ceph: Provide a splice-read stub
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1743655.1684488288.1@warthog.procyon.org.uk>
Date:   Fri, 19 May 2023 10:24:48 +0100
Message-ID: <1743656.1684488288@warthog.procyon.org.uk>
Precedence: bulk

Xiubo Li <xiubli@redhat.com> wrote:

> > +	ret = ceph_get_caps(in, CEPH_CAP_FILE_RD, want, -1, &got);
> > +	if (ret < 0) {
> > +		ceph_end_io_read(inode);
> > +		return ret;
> > +	}
> > +
> > +	if ((got & (CEPH_CAP_FILE_CACHE | CEPH_CAP_FILE_LAZYIO)) == 0) {
> > +		dout("splice_read/sync %p %llx.%llx %llu~%zu got cap refs on %s\n",
> > +		     inode, ceph_vinop(inode), *ppos, len,
> > +		     ceph_cap_string(got));
> > +
> > +		ceph_end_io_read(inode);
> > +		return direct_splice_read(in, ppos, pipe, len, flags);
> 
> Shouldn't we release cap ref before returning here ?

Ummm...  Even if we got no caps?

David