Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5f43a17c-94a0-4bff-b451-e5014de36ed9@redhat.com>
Date:   Fri, 19 May 2023 11:51:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v3] mm, compaction: Skip all non-migratable pages during
 scan
Content-Language: en-US
To:     "Huang, Ying" <ying.huang@intel.com>
Cc:     Khalid Aziz <khalid.aziz@oracle.com>, akpm@linux-foundation.org,
        willy@infradead.org, steven.sistare@oracle.com,
        mgorman@techsingularity.net, khalid@kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230517161555.84776-1-khalid.aziz@oracle.com>
 <c34e3768-8a01-d155-1970-8eada8c80ba7@redhat.com>
 <87sfbubg3j.fsf@yhuang6-desk2.ccr.corp.intel.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <87sfbubg3j.fsf@yhuang6-desk2.ccr.corp.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18.05.23 03:09, Huang, Ying wrote:
> David Hildenbrand <david@redhat.com> writes:
> 
>> On 17.05.23 18:15, Khalid Aziz wrote:
>>> Pages pinned in memory through extra refcounts can not be migrated.
>>> Currently as isolate_migratepages_block() scans pages for
>>> compaction, it skips any pinned anonymous pages. All non-migratable
>>> pages should be skipped and not just the anonymous pinned pages.
>>> This patch adds a check for extra refcounts on a page to determine
>>> if the page can be migrated.  This was seen as a real issue on a
>>> customer workload where a large number of pages were pinned by vfio
>>> on the host and any attempts to allocate hugepages resulted in
>>> significant amount of cpu time spent in either direct compaction or
>>> in kcompactd scanning vfio pinned pages over and over again that can
>>> not be migrated.
>>
>> How will this change affect alloc_contig_range(), such as used for CMA
>> allocations or virtio-mem? alloc_contig_range() ends up calling
>> isolate_migratepages_range() -> isolate_migratepages_block().
> 
> IIUC, cc->alloc_contig can be used to distinguish contiguous allocation
> and compaction.  And, from the original commit which introduced
> anonymous pages skipping (commit 119d6d59dcc0 ("mm, compaction: avoid
> isolating pinned pages ")) and this patch, large number of migration
> failure during compaction causes real issue too.  So, I suggest to use
> cc->alloc_contig here.

Agreed. I further wonder if we want to special-case the !alloc_contig 
case also for MIGRATE_CMA and ZONE_MOVABLE, where we cannot have 
longterm page pinnings (e.g., vfio pinned pages).

-- 
Thanks,

David / dhildenb